Parsing error in /etc/inc/system.inc

Sergei_Shablovsky

@gertjan This “syntax error” are smallest (but annoying) issue, because of “this build are for test purpose only”.

But mostly important the fact that “if the mistakes of that level are happened so frequently, how may be errors on algorithm level, memory leakage etc, may be hides from our view”?

Gertjan

@sergei_shablovsky said in Parsing error in /etc/inc/system.inc:

“if the mistakes of that level are happened so frequently, how may be errors on algorithm level, memory leakage etc, may be hides from our view”?

The one who answers that question will also find this one "What is the meaning of live ?".
You really want to know why people make mistakes ?

NRgia

@gertjan said in Parsing error in /etc/inc/system.inc:

I do not want to argue with all that has been said above.
I even tend to say "yeah, all true".

Still, I like to throw in some more words.

Snapshots are made public for a reason.
Those who made the snapshots public, wrote this : https://www.pfsense.org/snapshots/ and the message over there was written to the ones that made the snapshots available.
Everybody is free to interpret that message as he wants, but what the author wrote should be taken in consideration.

If you are referring to the following text: "These builds are for testing purposes only" then you don't know what testing really is. Did you heard of Definition of Ready or Definition of Done in a Software Development Lifecycle? I don't think you've heard about it.
First of all, before anyone starts testing a build, the one responsible releasing that build, must make sure that the build is TESTABLE, if it's not it should not reach the QA team in the first place. A short Smoke Test like:

Install the Snapshot see if it boots
Is the pfSense GUI displayed to the user
Are all the default services(packages) loaded without errors after the boot?
Is there any error messages in the logs after booting?

should be executed

If any of that fails you should not pass that Build further. You recheck the code and rebuild.

We are all pfSense fans here, with our comments we are hopping that the process will improve, and this will not happen again. Inventing excuses that this is ok to happen is not productive, and proves to me that you don't know what you're talking about.

Also from my perspective I don't have anything to add to this issue, and it will be my last comment for this particular issue.

Hope the process will change though.

Sergei_Shablovsky

@nrgia said in Parsing error in /etc/inc/system.inc:

@gertjan said in Parsing error in /etc/inc/system.inc:

I do not want to argue with all that has been said above.
I even tend to say "yeah, all true".

Still, I like to throw in some more words.

Snapshots are made public for a reason.
Those who made the snapshots public, wrote this : https://www.pfsense.org/snapshots/ and the message over there was written to the ones that made the snapshots available.
Everybody is free to interpret that message as he wants, but what the author wrote should be taken in consideration.

If you are referring to the following text: "These builds are for testing purposes only" then you don't know what testing really is. Did you heard of Definition of Ready or Definition of Done in a Software Development Lifecycle? I don't think you've heard about it.
First of all, before anyone starts testing a build, the one responsible releasing that build, must make sure that the build is TESTABLE, if it's not it should not reach the QA team in the first place. A short Smoke Test like:

Install the Snapshot see if it boots

Is the pfSense GUI displayed to the user

Are all the default services(packages) loaded without errors after the boot?

Is there any error messages in the logs after booting?

should be executed

If any of that fails you should not pass that Build further. You recheck the code and rebuild.

We are all pfSense fans here, with our comments we are hopping that the process will improve, and this will not happen again. Inventing excuses that this is ok to happen is not productive, and proves to me that you don't know what you're talking about.

Also from my perspective I don't have anything to add to this issue, and it will be my last comment for this particular issue.

Hope the process will change though.

TOTALLY AGREE!