new System Patches v2.0

[luckman212]

Noticed the new System Patches 2.0 package this morning after upgrading my 22.05 homelab 6100. Really cool update! I saw a bit of conversation over on r/PFSENSE but as things are a bit toxic over there lately I thought I'd post here too.

Two questions about this new version:

1. Is it possible for the configuration to be saved in the config.xml? It appears that the logic around which patches are applied is stored only on the filesystem. So it wouldn't survive backups/restores. Is that intentional?

2. Since there's no "auto apply" setting on the Recommended section, does that mean they are just always auto applied?

Thanks

[jimp]

@luckman212 said in new System Patches v2.0:

1. Is it possible for the configuration to be saved in the config.xml? It appears that the logic around which patches are applied is stored only on the filesystem. So it wouldn't survive backups/restores. Is that intentional?

The patches are applied to files on the filesystem, storing anything in config.xml would only allow for the possibility that it could become inconsistent between the configuration and filesystem.

2. Since there's no "auto apply" setting on the Recommended section, does that mean they are just always auto applied?

No, they will not auto-apply because they will not be relevant version-to-version. When you upgrade the next time they will either already be a part of the new base system or obsoleted by other changes.

For example all of the recommended patches in the package available on 21.05.2 and 2.5.2 are a part of the base system on 22.01/2.6.0 and are thus irrelevant there.

[luckman212]

@jimp Understood and makes sense. Thanks for clarifying! Enjoy the rest of your weekend

[chudak]

Yeah I noticed that too!!

And see the fix packages get pushed and become available to be applied.

I want to commend Netgate guys for making this available, that's really great way to address issues. Thank you!

@jimp - I wonder if you have any notifications, messages when a new fix is available, or it's more when we see System Patches update available that'd be an indication of something new being pushed?

[jimp]

@chudak said in new System Patches v2.0:

@jimp - I wonder if you have any notifications, messages when a new fix is available, or it's more when we see System Patches update available that'd be an indication of something new being pushed?

Just that there is an update to the package, as with any other package update.

I pushed another one this morning for 22.01/2.6.0, so if you have 2.0_1 you should see an update to 2.0_2 and you can upgrade it as usual, then there will be an additional patch entry there.

No notifications or anything at the moment.

[luckman212]

@jimp This is so awesome. A great way to push urgent fixes in between major releases since those are sometimes many months apart.

[SteveITS]

Plus it doubles as a "known issues" list. I already found one fix I didn't know was out there yet.

[serbus]

Hello!

Will the list only show "recommended patches", or is it supposed to be a list of all know issues that have a patch?

I am having a problem getting custom patches to fetch and save into the config on 22.01 with 2.0_3.

Maybe this should be

		$thispatch = &$a_patches[$_POST['id']];

???

John

[jimp]

There are two lists on the page. The custom list at the top with manual entries, and the recommended patches list.

Users cannot alter the recommended list, only the custom list.

Custom patches are working fine here (adding, removing, fetch/re-fetch, etc).

If it's not working, start a new thread with more details about what you're doing and the expected/actual result.

[luckman212]

@jimp I'm tracking the 22.05 release and keep it updated daily. Just wondering, after each upgrade, there is 1 patch that I always have to re-apply. The others all auto-apply. See below

Any idea why this is?

[jimp]

@luckman212 said in new System Patches v2.0:

@jimp I'm tracking the 22.05 release and keep it updated daily. Just wondering, after each upgrade, there is 1 patch that I always have to re-apply. The others all auto-apply. See below

That is not in a commit yet -- it's just a temporary workaround until we get a proper fix in the tree, which will most likely be a binary change and not a change like this.

The others are not auto applied as they're already in the code used by snapshots.

[luckman212]

@jimp Ok got it, thank you

[JeGr]

@jimp Hey Jim,

just tested the new Patches System and custom patches that worked fine before (2.5.2 with the old system patches module) aren't fetched anymore. In particular, there's a possible fix for the GW failback regression that we tested and cherry picked from the Redmine:

• GW failback regression
• Commit ID: ec73bb89489d830ec21c4e04ffa3ec401791b55d

Entering that in the Desc/ID fields and saving worked perfectly with 2.5.2.
In the new SysPatch Package, saving and fetching that results in only the URL being expanded but nothing thereafter. Even if the URL is correct (I copy&pasted it into a browser - shows the diff just fine), it isn't fetched into system patches anymore.

Tested on: SG2100, 22.01, newest Package 2.0_3 installed before.

Edit: confirmed, on an older system with 22.01 installed and System Patches in version 1.2_7 it's working just fine. So seems 2.0.x has broken something in fetching Github IDs

Cheers

[chudak]

@jegr

Just tried that commit
It was fetched but can't be applied

[JeGr]

@chudak If you edit your "test" can you see if the ID got expanded to the URI? That seems to work but otherwise the fetch leave the content field empty. In an older version of system patches (1.2_7) that worked and still works perfectly fine. And of course - without content - nothing can be applied or reverted ;)

[Gertjan]

@jegr @chudak Jimp said in another thread / post that the patch system has a little issue : patch link is expanded, but patch is not downloaded - "Patch Contents" box stays empty.
That will get resolved 'soon'.

The expanded patch URL can be used in a browser to see the patch, then copy all, and paste in the "Patch Contents" box and you'll be fine.

[jimp]

New package is building now with fixes for the fetch issue and a couple new patches.

[chudak]

@jimp said in new System Patches v2.0:

New package is building now with fixes for the fetch issue and a couple new patches.

Updated, applied fixes, and tested fetch, all good!

Thx @jimp

[luckman212]

@jimp I had to flip my update branch from 22.05 to 22.01 in order to see the 2.0_4 version. I installed it and then flipped back to the 22.05 track. Is that "normal"?

[jimp]

Snapshots only get packages built overnight with the full snapshot build so they whole set is consistent as we may make several changes throughout the day.

It'll come along naturally when you pick up the new snapshot tomorrow morning.