Problem with multiple Interfaces since Version 22.05

OpIT GmbH

I created a Bug Report

https://redmine.pfsense.org/issues/13391

Gertjan

Recently, the 'ipfw' firewall, used for captive portal instances, was ditched and replaced by the 'pf' firewall.

'pf' is the one we use when we create our GUI firewall rules.

The conversion was a big task, and maybe ( ? ) the 'multiple interfaces' options was just omitted, or forgotten ( coders are still human ;) ).

OpIT GmbH

@gertjan
yeah it looks like the just have forgotten some things there but i also think that this should not be a big Problem to correct this.... :=)

Gertjan

@opit-gmbh

If you can edit a file :

Open /etc/inc/captiveportal.inc
Goto line 2576 ( ? )

You'll find

						$cpiplist = $cpip . ' ';

Change it to ( add a single point . ) :

						$cpiplist .= $cpip . ' ';

Now you will see in the firewall rules file :

....
# Captive Portal
table <cpzoneid_2_cpips> { 192.168.100.1 192.168.2.1  }
....

and these are the IP addresses of my two interfaces added to a captive portal zone.

I can't test drive this myself.
Can you test ?

OpIT GmbH

@gertjan

Tested it > and it seams to be working!

Many Thanks!!!

OpIT GmbH

I also found maybe another Problem. When you upload a Logo or a Background Logo, its created with 2 .. (Points) in the extension. So you have "captiveportal-logo..png or "captiveportal-background..png"

The Logos are displayed normally, so its just seams to be a cosmetic "Bug"

Gertjan

@opit-gmbh

Hummm.
The point you just added should be remove somewhere else ;)

OpIT GmbH

@gertjan

Not i add the Dot, the Netgate add it. I Upload a "logo.png" and the Netgate generates "captiveportal-logo..png"

Gertjan

@opit-gmbh

You didn't understood the suggestion.

Open /usr/local/www/services_captiveportal.php

Look for every function :

image_type_to_extension

And look closely to the example of the image_type_to_extension PHP function definition.

<?php
// Create image instance
$im = imagecreatetruecolor(100, 100);

// Save image
imagepng($im, './test' . image_type_to_extension(IMAGETYPE_PNG));
imagedestroy($im);
?>

The example :

Right after '/test there is no point included - so the point comes back with with the image_type_to_extension(IMAGETYPE_PNG) function call - so this function resturns
".png".

Now, back to our /usr/local/www/services_captiveportal.php, locate every line with image_type_to_extension and then look closely the line.
Example :

$logo_name = "captiveportal-logo." . image_type_to_extension(is_supported_image($_FILES['logo-img']['tmp_name']));

Do you see the point that you have to remove ?
It's right after captiveportal-logo

Redo the same thing for where the "captiveportal-background." is handled, and you'll be fine.

My suggestion was :you should remove some points '.' ^^

OpIT GmbH

@gertjan

ahhhh, now i know what you mean "The point you just added should be remove somewhere else" .... heheh :=)

THX!

Should all of this here be Mailed to Netgate directly, so that they can fix this stuff in the next Version or with a Patch? Our das Netgate read all the Forum Posts here?!

Gertjan

@opit-gmbh said in Problem with multiple Interfaces since Version 22.05:

Should all of this here be Mailed to Netgate directly

You opened a bug report, a regression actually, that points to this thread.
Some author will read the report, read the thread, and deal with it in no time.
Jimp already saw your report.
As I see it, 2.7.0 and 22.11 will contain the solution.

OpIT GmbH

@gertjan

i also added a comment about the "Dot" Problem in the Bug Report. So i think all should be fine for now.

THX Gertjan for your help!