23.01 php crash report

[heper]

fyi
just noticed php crash report from a couple of days ago.
does not seem to have any significant impact in operations

device is a ng6100max

Crash report begins.  Anonymous machine information:

amd64
14.0-CURRENT
FreeBSD 14.0-CURRENT #0 plus-devel-main-n255998-693fad75fe3: Fri Jan  6 06:28:49 UTC 2023     root@freebsd:/var/jenkins/workspace/pfSense-Plus-snapshots-master-main/obj/amd64/0khU7V4C/var/jenkins/workspace/pfSense-Plus-snapshots-master-main/sources/FreeBS

Crash report details:

PHP Errors:
[20-Jan-2023 07:56:18 CET] PHP Fatal error:  Uncaught TypeError: Unsupported operand types: string - null in /usr/local/www/rrd_fetch_json.php:149
Stack trace:
#0 {main}
  thrown in /usr/local/www/rrd_fetch_json.php on line 149



No FreeBSD crash data found.

[jimp]

That would be from Status > Monitoring graphs, but I'm not seeing how that would end up null there. Try this change to see if it helps.

index 78282292fcdf..a42ea83a0949 100644
--- a/sysutils/pfSense-Status_Monitoring/files/usr/local/www/rrd_fetch_json.php
+++ b/sysutils/pfSense-Status_Monitoring/files/usr/local/www/rrd_fetch_json.php
@@ -146,7 +146,7 @@ if ($timePeriod === "custom") {
        if ( $end > $last_updated ) { $end = $last_updated; }
 
        // Minus resolution to prevent last value 0 (zero).
-       $end -= $resolution;
+       $end = (int)$end - (int)$resolution;
 
        // make sure start time isn't later than end time
        if ($start > $end) { $start = $end; }

[heper]

@jimp said in 23.01 php crash report:

i have no clue how to trigger the error. just noticed the crash report when logging in on the dashboard.

will check