New copy buttons

periko

Hello guys.

Could please someone explain me this option ?

Regards!!!

mcury

@periko If you are copying a rule from interface LAN, in which you have LAN_NET in source or destination, to interface WIFI, LAN_NET will be replaced by WIFI_NET in those fields.

periko

@periko but if I don't chose that option what would happen?

I ask this because I still don't understand that difference, check this.

I copy my lan using that option to my vlan100 and latter copy the same rule with default settins(without checking that option)

But don't see any difference...?

Thanks for your help.

mcury

hmm, I just tested and the same thing happened here.
I don't think this is the expected behavior.

As I see it, expected behavior is to:
When that option is checked, make the conversion.
When that option is not checked, don't change anything, just copy the rule as is to the other interface.

SwissSteph

Tested on my version 23.05.1 and it works as expected with the check mark set.

Bob.Dig

@SwissSteph said in New copy buttons:

Tested on my version 23.05.1 and it works as expected with the check mark set.

That is not the point.
The default is good and I don't think that an option is needed at all.

johnpoz

@mcury said in New copy buttons:

I don't think this is the expected behavior.

Yeah either I need more coffee or yeah it doesn't seem right.

The way I read that if I copy a rule from lan with lan net as source to opt1, without it checked the source on opt1 would still be lan net. if I check it, it would convert lan net to opt 1 net as the source.

But from my simple test, even without it checked it still converts the source "lan net" to "opt1 net" when I copy it to opt1.

Which I would think should be a good default to do, but you should be able to check something not to convert the source I would think.

jimp

I can confirm the incorrect behavior here as well. Looks like the JavaScript trying to copy that setting from the form when it's being submitted isn't quite right,

I opened https://redmine.pfsense.org/issues/14576 and I just pushed a fix.

https://github.com/pfsense/pfsense/commit/77e168861ba43b3d6290df07fc04481c09174b28

periko

@jimp issue fixed, thanks guys!!!