haproxy broken after update to 2.8.0: nbproc is not supported any more...

Pierre 0

This problem still happens in pfsense+ 23.05.1-RELEASE (arm64) built on Wed Jun 28 03:57:42 UTC 2023 FreeBSD 14.0-CURRENT,
with package HAProxy net 0.62_1 / haproxy-2.7.6.

The fix presented in this thread works fine.

cforker

Hi,

Today I updated the HAPROXY package as it was informing to update. After updating the package all my addresses are not accessible any more and the service stopped. It is not possible to start the service. When saving the config I get the following:

Errors found while starting haproxy
[NOTICE] (47115) : haproxy version is 2.7.8-58c657f
[NOTICE] (47115) : path to executable is /usr/local/sbin/haproxy
[ALERT] (47115) : config : parsing [/var/etc/haproxy_test/haproxy.cfg:8] : nbproc is not supported any more since HAProxy 2.5. Threads will automatically be used on multi-processor machines if available.
[ALERT] (47115) : config : Error(s) found in configuration file : /var/etc/haproxy_test/haproxy.cfg
[ALERT] (47115) : config : Fatal errors found in configuration.

I tried commenting out the nbproc in the .cfg but still not able to start the service.

Anyone any idea how to fix this and where?

Thanx in advance

machbot

@royjones Better to apply the fix manually mentioned on the github marge request as shared by @davidi, manual edits to the .cfg as suggested by @nartn isn't persistent across reboots.

cforker

Hi,

Today I updated the HAPROXY package as it was informing to update. After updating the package all my addresses are not accessible any more and the service stopped. It is not possible to start the service. When saving the config I get the following:

Errors found while starting haproxy
[NOTICE] (47115) : haproxy version is 2.7.8-58c657f
[NOTICE] (47115) : path to executable is /usr/local/sbin/haproxy
[ALERT] (47115) : config : parsing [/var/etc/haproxy_test/haproxy.cfg:8] : nbproc is not supported any more since HAProxy 2.5. Threads will automatically be used on multi-processor machines if available.
[ALERT] (47115) : config : Error(s) found in configuration file : /var/etc/haproxy_test/haproxy.cfg
[ALERT] (47115) : config : Fatal errors found in configuration.

I tried commenting out the nbproc in the .cfg but still not able to start the service.

Anyone any idea how to fix this and where?

Thanx in advance

cforker

Ok, found a temporary solution:

ssh to pfsense

edit /var/etc/haproxy/haproxy.cfg and delete the line "nbproc 1"

run haproxy from command line: haproxy -f /var/etc/haproxy/haproxy.cfg

Should be good to go for the time being.

Chris

cforker

Ok,

temporary solution found:

ssh to pfsense

edit /var/etc/haproxy/haproxy.cfg and delete the line "nbproc 1"

run haproxy from command line: haproxy -f /var/etc/haproxy/haproxy.cfg

Would be nice if there will be a permanent solution.

Cheers,

Chris

SjM

@Pierre-0 Ditto for me. But when will this be properly patched?

kiddsupreme

@Pierre-0

Can you tell me how you applied the update from above? I'm in the haproxy.inc file, but I am not sure exactly "where" I should place that information. Perhaps if you have a screenshot of how you placed it so I have something to reference? I appreciate the help!

michmoor

The fix with the edit of the .cfg didnt work for me. I tried restarting the service and got the following error
This is a very bad package update...

edit: i was expecting to re-apply my changes again which breaks the package. So after i run haproxy -f /var/etc/haproxy/haproxy.cfg then everything works but you cannot make any further changes in the GUI until theres a fix

haproxy: startup error output!: [NOTICE] (94268) : haproxy version is 2.7.6-4dadaaa[NOTICE] (94268) : path to executable is /usr/local/sbin/haproxy[ALERT] (94268) : config : parsing [/var/etc/haproxy/haproxy.cfg:9] : nbproc is not supported any more since HAProxy 2.5. Threads will automatically be used on multi-processor machines if available.[ALERT] (94268) : config : Error(s) found in configuration file : /var/etc/haproxy/haproxy.cfg[ALERT] (94268) : config : Fatal errors found in configuration.

Cylosoft

I just came to report this also. I couldn't get the fix mentioned to work. I'm just running defaults for threading so I removed the lines that wrote out nbproc and nbthread. So I removed these starting at 1495.

	// Set numprocs if defined or use system default (#cores)
	$numprocs = $a_global['nbproc'] ? $a_global['nbproc'] : "1";
	$numthread = $a_global['nbthread'] ? $a_global['nbthread'] : "1";
	fwrite ($fd, "\tnbproc\t\t\t{$numprocs}\n");
	if (haproxy_version() >= "1.8") {
		fwrite ($fd, "\tnbthread\t\t\t{$numthread}\n");
	}

thebear

To bad its also dead at my end after the update.

haproxy: startup error output!: [NOTICE] (74851) : haproxy version is 2.7.6-4dadaaa[NOTICE] (74851) : path to executable is /usr/local/sbin/haproxy[ALERT] (74851) : config : parsing [/var/etc/haproxy/haproxy.cfg:8] : nbproc is not supported any more since HAProxy 2.5. Threads will automatically be used on multi-processor machines if available.[ALERT] (74851) : config : Error(s) found in configuration file : /var/etc/haproxy/haproxy.cfg[ALERT] (74851) : config : Fatal errors found in configuration.

Workarround
For those that do not want to SSH, you can do it from the pfSense GUI by going to Diagnostics->Edit File, make the change manually, then go to Diagnostics->Command Prompt and run: haproxy -f /var/etc/haproxy/haproxy.cfg

@stephenw10 is the team aware of this bug? Do you want a redmine bug report?

SjM

@kiddsupreme look for this line in haproxy.inc
==> fwrite ($fd, "\tnbproc\t\t\t{$numprocs}\n");
Wrap it in the if statement and do a resave in the WebGUI for haproxy.

kiddsupreme

@Cylosoft I also could not get it to work (which was why I was asking about how it was pasted into the file). As you suggested, I removed that information and everything popped up. Is there any negatives about running things this way? Thanks again for the help!

michmoor

@thebear A new build is coming. Give it a few hours.

https://redmine.pfsense.org/issues/14674

thebear

@michmoor great news, thanks for confirming there is already a bug report.

Cylosoft

@kiddsupreme Most people are running the defaults for these settings anyway so I wouldn't worry too much about it. Netgate is pretty quick with the fixes on these so I'm sure an updated version is coming soon anyway.

Cylosoft

Looks like 0.63_1 is out and it fixes this.

davidi

I can confirm the new package 0.63_1 fixes this issue. After updating the package, you may have to go HAProxy->Settings, click save so it writes a new config and then restart the service to clear the message saying changes were made, etc. in pfSense. Thank you devs for the quick fix!

Darkk

@davidi said in haproxy broken after update to 2.8.0: nbproc is not supported any more...:

I can confirm the new package 0.63_1 fixes this issue. After updating the package, you may have to go HAProxy->Settings, click save so it writes a new config and then restart the service to clear the message saying changes were made, etc. in pfSense. Thank you devs for the quick fix!

Yep. I can confirm this as well. I've switched back to non-dev version and saved the changes. It's working fine now.

royjones

@michmoor: Update to 0.63_1 went through without problems, error has been eliminated.

Many thanks for the quick help!