Crash on saving after deselecting all allowed ciphers

nobanzai

In the configuration page for an openvpn client one can deselect all "Allowed Data Encryption Algorithms.", but it leads to that crash:

Crash report begins.  Anonymous machine information:

amd64
15.0-CURRENT
FreeBSD 15.0-CURRENT #21 RELENG_2_8_1-n256095-47c932dcc0e9: Thu Aug 28 16:27:48 UTC 2025     root@pfsense-build-release-amd64-1.eng.atx.netgate.com:/var/jenkins/workspace/pfSense-CE-snapshots-2_8_1-main/obj/amd64/AupY3aTL/var/jenkins/workspace/pfSense-CE-

Crash report details:

PHP Errors:
[12-Oct-2025 13:29:05 Europe/Berlin] PHP Fatal error:  Uncaught TypeError: Form_Select::__construct(): Argument #4 ($values) must be of type array, null given, called in /usr/local/www/vpn_openvpn_client.php on line 942 and defined in /usr/local/www/classes/Form/Select.class.php:31
Stack trace:
#0 /usr/local/www/vpn_openvpn_client.php(942): Form_Select->__construct()
#1 {main}
  thrown in /usr/local/www/classes/Form/Select.class.php on line 31



No FreeBSD crash data found.

Is this already addressed somewhere or how/where can I report it?

allxi

@nobanzai +1

amd64
15.0-CURRENT
FreeBSD 15.0-CURRENT #21 RELENG_2_8_1-n256095-47c932dcc0e9: Thu Aug 28 16:27:48 UTC 2025     root@pfsense-build-release-amd64-1.eng.atx.netgate.com:/var/jenkins/workspace/pfSense-CE-snapshots-2_8_1-main/obj/amd64/AupY3aTL/var/jenkins/workspace/pfSense-CE-

Crash report details:

PHP Errors:
[16-Nov-2025 21:48:05 Europe/] PHP Fatal error:  Uncaught TypeError: Form_Select::__construct(): Argument #4 ($values) must be of type array, null given, called in /usr/local/www/vpn_openvpn_client.php on line 942 and defined in /usr/local/www/classes/Form/Select.class.php:31
Stack trace:
#0 /usr/local/www/vpn_openvpn_client.php(942): Form_Select->__construct()
#1 {main}
  thrown in /usr/local/www/classes/Form/Select.class.php on line 31

SteveITS

how/where can I report it?

Redmine.pfsense.org

allxi

@nobanzai +1

amd64
15.0-CURRENT
FreeBSD 15.0-CURRENT #21 RELENG_2_8_1-n256095-47c932dcc0e9: Thu Aug 28 16:27:48 UTC 2025     root@pfsense-build-release-amd64-1.eng.atx.netgate.com:/var/jenkins/workspace/pfSense-CE-snapshots-2_8_1-main/obj/amd64/AupY3aTL/var/jenkins/workspace/pfSense-CE-

Crash report details:

PHP Errors:
[16-Nov-2025 21:48:05 Europe/] PHP Fatal error:  Uncaught TypeError: Form_Select::__construct(): Argument #4 ($values) must be of type array, null given, called in /usr/local/www/vpn_openvpn_client.php on line 942 and defined in /usr/local/www/classes/Form/Select.class.php:31
Stack trace:
#0 /usr/local/www/vpn_openvpn_client.php(942): Form_Select->__construct()
#1 {main}
  thrown in /usr/local/www/classes/Form/Select.class.php on line 31

I'm temporery fix it.
Use diag_edit.php
edit /usr/local/www/vpn_openvpn_client.php &
saved history version 4b9165e "Default to an empty array for functions expecting a countable value

Do this for foreach() and count()." https://github.com/pfsense/pfsense/blob/4b9165e5ad3f47c36d1dec3a585a60b629bcdc3a/src/usr/local/www/vpn_openvpn_client.php

and edit ciphers in client.