BOUNTY: Web GUI reprogramming

charlie0440 · May 23, 2013, 9:46 PM

So I've been busy and had put this project to rest (temporarily).

I Revisited it tonight but took a different approach. I started working on it as a theme ie CSS changes as opposed to rewriting the HTML.
In the process of attempting to get twiitter bootstrap implemented I ended up with a very basic full screen theme (with no fancy features) based on the pfsense_ng theme.

Anyway I pushed it to pfsense master so maybe it will get merged.

https://github.com/pfsense/pfsense/pull/647

Supermule · May 24, 2013, 6:11 AM

Looks good but more columns are needed, they dont have to be wider…

charlie0440 · May 24, 2013, 10:13 AM

@Supermule:

Looks good but more columns are needed, they dont have to be wider…

Easier said then done.

I pretty much have accomplished this in my testing. I have a version which has 3 columns which are droppable but I haven't figured out how to save their state (Ajax code).

Problem is this can't be implemented as a theme. It requires changes to the HTML & javascript. Which I guess as most of the existing themes are fixed width would require all the existing themes to be edited :(

Edit: Does anyone know where the source code for the widescreen package is?

Supermule · May 24, 2013, 10:28 AM

Rich did some rewrite of the widescreenpackage and got it working quite well.

Maybe you should talk to him about it since the 2 column code id hardcoded into pfsense.

charlie0440 · May 24, 2013, 9:54 PM

@Supermule:

Looks good but more columns are needed, they dont have to be wider…

Something like this ;) http://youtu.be/dYNSF3zIHlM

That is achieved using jQuery no changes have been made to pfsense's core, it is added as part of the theme (so far so good). The problem is, as I said before, I can't work out how the Ajax code is working with saving the states. So as soon as you navigate away from the dash we are back to 2 columns >:(

@Supermule:

Rich did some rewrite of the widescreenpackage and got it working quite well.

Maybe you should talk to him about it since the 2 column code id hardcoded into pfsense.

How do I contact rich? Is that his forum username? or are there any devs reading this who can help. I think we all agree this would be cool for pfsense!

Supermule · May 25, 2013, 3:15 AM

This is his profile.

http://forum.pfsense.org/index.php?action=profile;u=236308

This is a further discussion about the widescreen package.

http://forum.pfsense.org/index.php/topic,62410.0.html

charlie0440 · May 25, 2013, 5:09 PM

@Supermule:

This is a further discussion about the widescreen package.

http://forum.pfsense.org/index.php/topic,62410.0.html

Damn if I had seen this thread before I would of finished this ages ago. It enabled me to understand how the save states were being loaded!

So I think I have this solved (spend far too long on it today).
new vid (sound seems screwed up so you might want to turn it down/mute): http://youtu.be/irglXyn41Ys?t=3s
new theme pull requests sent to master. Fingers crossed

Supermule · May 25, 2013, 5:35 PM

Exactly why I posted it ;)

Supermule · May 25, 2013, 5:38 PM

In the video it looks like it reverts back to 2 columns in the end??

charlie0440 · May 25, 2013, 5:54 PM

it becuase I change back to the pfsense_ng theme.

This is a new theme called full_screen. Its a theme so it doesn't touch much core code ie break anything else.

the widescreen package is quite hacky changing lots of files etc. this only changes the index.php slightly all the rest is part of the theme files (its still a hack tho)

charlie0440 · May 27, 2013, 5:24 PM

if anyone wants to test it. Download it here: https://dl.dropboxusercontent.com/u/12367642/full_screen_theme.zip

extract the zip to a folder ie tmp

you need to place the files onto pfsense.

In linux from a terminal:
cd /location/of/folder/tmp
scp -r * root@192.168.0.50:/usr/local/www/

Remeber to change the ip address ;)

Then on the webgui select the theme full_screen

Edit for 2.1 only (not sure if it'll work with 2.0.x)

Clear-Pixel · May 26, 2013, 7:26 AM

@charlie0440:

Something like this ;) http://youtu.be/dYNSF3zIHlM

That is achieved using jQuery no changes have been made to pfsense's core, it is added as part of the theme (so far so good). The problem is, as I said before, I can't work out how the Ajax code is working with saving the states. So as soon as you navigate away from the dash we are back to 2 columns >:(

Not sure what type of database pfsense is utilizing, but a record would need to be created for this task, so the column count state can be stored and be retrieved when a page loads or a refresh occurs.

OR

Look for a jquery cookie plugin and store the column value there.

OR

Haven't had a need to arise yet to try this, but you might be able to rewrite the default variable value of the column count in the jquery file itself. File of course would have to be set to read & write which I don't really like but the security might not be a concern depending on the deployment.

Note:
There is a need for a enhanced Menu. It should be in a side bar and capable of expanding and collapsing! There is a template already with a side bar menu that can be modified! The problem with the exsiting it its not collapsible!

See my previous reply's

charlie0440 · May 26, 2013, 4:57 PM

@clear-pixel Don't think you read the last few posts before posting. I solved that problem of storing the column number a few posts back.

I hear what your saying about the GUI. I think the way to go is to get all the css and as much js as we can out of the HTML/PHP pages and into .css & .js files. Then we can work on stuff like collapsible menus and fancy stuff. But until that is done, it would be a nightmare.

stephenw10 · May 26, 2013, 5:55 PM

I would personally not want collapsible menus unless there was a very good reason for it. I can't think of one, but I'm open to suggestions. ;)

Steve

Supermule · May 26, 2013, 6:49 PM

I think the one we have now is fine like in the pfsense_ng theme.

Its just the number of columns, drag and drop and especially the save issue that bothers me.

Clear-Pixel · May 26, 2013, 6:50 PM

@stephenw10:

I would personally not want collapsible menus unless there was a very good reason for it. I can't think of one, but I'm open to suggestions. ;)

Steve

The majority want and understand the purpose of collapsible menus.

charlie0440 · May 26, 2013, 6:55 PM

@supermule have you tried my theme?

stephenw10 · May 26, 2013, 10:32 PM

Perhaps I've misunderstood. Like I said I'm open to suggestions.

Steve

Supermule · May 27, 2013, 6:03 AM

Not yet Charlie.

Been busy as fook!

@charlie0440:

@supermule have you tried my theme?

c0urier · May 28, 2013, 12:24 PM

@charlie0440:

if anyone wants to test it. Download it here: https://dl.dropboxusercontent.com/u/12367642/full_screen_theme.zip

extract the zip to a folder ie tmp

you need to place the files onto pfsense.

In linux from a terminal:
cd /location/of/folder/tmp
scp -r * root@192.168.0.50:/usr/local/www/

Remeber to change the ip address ;)

Then on the webgui select the theme full_screen

Edit for 2.1 only (not sure if it'll work with 2.0.x)

I tried the following and am able to create extra coloums, but I am not able to save them. As soon as I hit "Save Settings" it jumps back to default two coloums.
I have cleared cache/cookies etc. does not chance anything, any advice would be greatly appreciated.