[solved] Firewall Aliases Edit - Add row button
-
It seems odd that the green "Add" button is in a block of its own that has the label "Add" on the left.
And the blue "Save" button does not line up nicely under the "Add" button.
So it looks a bit messy to me.
-
Thanks Phil,
I will look into ways of better aligning the add button where a repeatable class section is the last section on the page. It does look untidy now.
-
Button has been changed to Global button when it is the last element on the page. This causes it to be aligned with the "Save" button.
-
These are kind of hacks, but you could do one of the following:
-
style the #addrow id if all addrow id's are consistent.
-
use addClass() to add a class to the button and style that class
Even with that it can be hard to make it not look odd at different screen sizes.
-
-
That looks better now, thanks.
The other things on this page I have reported elsewhere but mentioning them here if someone else notices them:
a) The word "Description" appears under the description box of every row. It should appear somewhere once? There used to be headings for all the columns. But maybe it is self-explanatory and can have no column headings? Or?
b) The "Add" button says "Add host", but the selected alias type is "Network". The "Add" button text needs to either change as the selected alias type changes, or just say "Add".
-
would this solve a & b ? https://github.com/pfsense/pfsense/pull/1943
a) The word "Description" appears under the description box of every row. It should appear somewhere once? There used to be headings for all the columns. But maybe it is self-explanatory and can have no column headings? Or?
b) The "Add" button says "Add host", but the selected alias type is "Network". The "Ad" button text needs to either change as the selected alis type changes, or just say "Add".
-
PR 1943 merged.
-
This looks good. The various changes made have addressed:
https://redmine.pfsense.org/issues/5235
https://redmine.pfsense.org/issues/5224
I will mark this thread solved.