• Categories
  • Recent
  • Tags
  • Popular
  • Users
  • Search
  • Register
  • Login
Netgate Discussion Forum
  • Categories
  • Recent
  • Tags
  • Popular
  • Users
  • Search
  • Register
  • Login

[solved] Firewall Aliases Edit - Add row button

Scheduled Pinned Locked Moved 2.3-RC Snapshot Feedback and Issues - ARCHIVED
8 Posts 4 Posters 1.8k Views
Loading More Posts
  • Oldest to Newest
  • Newest to Oldest
  • Most Votes
Reply
  • Reply as topic
Log in to reply
This topic has been deleted. Only users with topic management privileges can see it.
  • P
    phil.davis
    last edited by Oct 6, 2015, 7:31 AM Oct 1, 2015, 11:59 AM

    It seems odd that the green "Add" button is in a block of its own that has the label "Add" on the left.
    And the blue "Save" button does not line up nicely under the "Add" button.
    So it looks a bit messy to me.
    Bootstrap-Alias-Edit-Description.png
    Bootstrap-Alias-Edit-Description.png_thumb

    As the Greek philosopher Isosceles used to say, "There are 3 sides to every triangle."
    If I helped you, then help someone else - buy someone a gift from the INF catalog http://secure.inf.org/gifts/usd/

    1 Reply Last reply Reply Quote 0
    • S
      Steve_B Netgate
      last edited by Oct 1, 2015, 1:19 PM Oct 1, 2015, 12:53 PM

      Thanks Phil,

      I will look into ways of better aligning the add button where a repeatable class section is the last section on the page. It does look untidy now.

      Als ik kan

      1 Reply Last reply Reply Quote 0
      • S
        Steve_B Netgate
        last edited by Oct 1, 2015, 8:31 PM

        Button has been changed to Global button when it is the last element on the page. This causes it to be aligned with the "Save" button.

        Als ik kan

        1 Reply Last reply Reply Quote 0
        • J
          jdillard
          last edited by Oct 1, 2015, 9:15 PM

          These are kind of hacks, but you could do one of the following:

          • style the #addrow id if all addrow id's are consistent.

          • use addClass() to add a class to the button and style that class

          Even with that it can be hard to make it not look odd at different screen sizes.

          1 Reply Last reply Reply Quote 0
          • P
            phil.davis
            last edited by Oct 4, 2015, 3:21 AM Oct 3, 2015, 12:48 PM

            That looks better now, thanks.

            The other things on this page I have reported elsewhere but mentioning them here if someone else notices them:

            a) The word "Description" appears under the description box of every row. It should appear somewhere once? There used to be headings for all the columns. But maybe it is self-explanatory and can have no column headings? Or?

            b) The "Add" button says "Add host", but the selected alias type is "Network". The "Add" button text needs to either change as the selected alias type changes, or just say "Add".

            Alias-Edit-Add-Host.png
            Alias-Edit-Add-Host.png_thumb

            As the Greek philosopher Isosceles used to say, "There are 3 sides to every triangle."
            If I helped you, then help someone else - buy someone a gift from the INF catalog http://secure.inf.org/gifts/usd/

            1 Reply Last reply Reply Quote 0
            • H
              heper
              last edited by Oct 3, 2015, 5:59 PM

              @phil.davis @Steve_B

              would this solve a & b ? https://github.com/pfsense/pfsense/pull/1943

              a) The word "Description" appears under the description box of every row. It should appear somewhere once? There used to be headings for all the columns. But maybe it is self-explanatory and can have no column headings? Or?

              b) The "Add" button says "Add host", but the selected alias type is "Network". The "Ad" button text needs to either change as the selected alis type changes, or just say "Add".

              1 Reply Last reply Reply Quote 0
              • H
                heper
                last edited by Oct 5, 2015, 6:34 PM

                PR 1943 merged.

                1 Reply Last reply Reply Quote 0
                • P
                  phil.davis
                  last edited by Oct 6, 2015, 7:30 AM

                  This looks good. The various changes made have addressed:
                  https://redmine.pfsense.org/issues/5235
                  https://redmine.pfsense.org/issues/5224
                  I will mark this thread solved.

                  As the Greek philosopher Isosceles used to say, "There are 3 sides to every triangle."
                  If I helped you, then help someone else - buy someone a gift from the INF catalog http://secure.inf.org/gifts/usd/

                  1 Reply Last reply Reply Quote 0
                  7 out of 8
                  • First post
                    7/8
                    Last post
                  Copyright 2025 Rubicon Communications LLC (Netgate). All rights reserved.
                    This community forum collects and processes your personal information.
                    consent.not_received