Netgate Discussion Forum
    • Categories
    • Recent
    • Tags
    • Popular
    • Users
    • Search
    • Register
    • Login

    Changing interfaces assigned to LAGG

    Scheduled Pinned Locked Moved 2.3-RC Snapshot Feedback and Issues - ARCHIVED
    8 Posts 4 Posters 1.9k Views
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • T Offline
      tcsac
      last edited by

      I'm trying to move my pfsense install to new hardware.  One of the things I need to do is modify what interfaces are assigned a LAGG I've created.  Unfortunately if I try to edit the LAGG and select new interfaces, it spits out the following on save:

      Warning: explode() expects parameter 2 to be string, array given in /usr/local/www/interfaces_lagg_edit.php on line 226 Call Stack: 0.0000 237616 1. {main}() /usr/local/www/interfaces_lagg_edit.php:0 0.0887 1816664 2. build_member_list() /usr/local/www/interfaces_lagg_edit.php:249 0.0887 1818224 3. explode() /usr/local/www/interfaces_lagg_edit.php:226 Warning: stristr() expects parameter 1 to be string, array given in /usr/local/www/interfaces_lagg_edit.php on line 234 Call Stack: 0.0000 237616 1. {main}() /usr/local/www/interfaces_lagg_edit.php:0 0.0887 1816664 2. build_member_list() /usr/local/www/interfaces_lagg_edit.php:249 0.0888 1818576 3. stristr() /usr/local/www/interfaces_lagg_edit.php:234 Warning: stristr() expects parameter 1 to be string, array given in /usr/local/www/interfaces_lagg_edit.php on line 234 Call Stack: 0.0000 237616 1. {main}() /usr/local/www/interfaces_lagg_edit.php:0 0.0887 1816664 2. build_member_list() /usr/local/www/interfaces_lagg_edit.php:249 0.0889 1818760 3. stristr() /usr/local/www/interfaces_lagg_edit.php:234

      1 Reply Last reply Reply Quote 0
      • jimpJ Offline
        jimp Rebel Alliance Developer Netgate
        last edited by

        Can you share just the lagg section of your config.xml so we can see what the existing entry looks like?

        Remember: Upvote with the 👍 button for any user/post you find to be helpful, informative, or deserving of recognition!

        Need help fast? Netgate Global Support!

        Do not Chat/PM for help!

        1 Reply Last reply Reply Quote 0
        • P Offline
          phil.davis
          last edited by

          https://github.com/pfsense/pfsense/blob/master/src/usr/local/www/interfaces_lagg_edit.php#L226
          $members_array = explode(',', $pconfig['members']);

          $members_array is never used anywhere - so that line at least could be deleted.

          But it still does not explain why $pconfig['members'] seems to be an array when it should be a comma-separated string.

          The answer to jimp's question will be of interest…

          As the Greek philosopher Isosceles used to say, "There are 3 sides to every triangle."
          If I helped you, then help someone else - buy someone a gift from the INF catalog http://secure.inf.org/gifts/usd/

          1 Reply Last reply Reply Quote 0
          • T Offline
            tcsac
            last edited by

            <laggs><lagg><members>igb1,igb2,igb5,igb6</members>

            <laggif>lagg0</laggif>
            <proto>lacp</proto></lagg></laggs>

            I ended up manually editing it and putting in the interfaces needed and it works fine, but that's what it did look like.

            1 Reply Last reply Reply Quote 0
            • P Offline
              phil.davis
              last edited by

              This should fix the obvious bugs in the way the LAGG Edit GUI works: https://github.com/pfsense/pfsense/pull/2318

              Then you can try to really use and modify your LAGG setings and see what else happens :)

              As the Greek philosopher Isosceles used to say, "There are 3 sides to every triangle."
              If I helped you, then help someone else - buy someone a gift from the INF catalog http://secure.inf.org/gifts/usd/

              1 Reply Last reply Reply Quote 0
              • T Offline
                tcsac
                last edited by

                Not sure if the fix has been pushed or not, but I just tried editing the lagg and got the same behavior:

                Warning: explode() expects parameter 2 to be string, array given in /usr/local/www/interfaces_lagg_edit.php on line 226 Call Stack: 0.0001 237224 1. {main}() /usr/local/www/interfaces_lagg_edit.php:0 0.1673 1824440 2. build_member_list() /usr/local/www/interfaces_lagg_edit.php:249 0.1673 1826048 3. explode() /usr/local/www/interfaces_lagg_edit.php:226 Warning: stristr() expects parameter 1 to be string, array given in /usr/local/www/interfaces_lagg_edit.php on line 234 Call Stack: 0.0001 237224 1. {main}() /usr/local/www/interfaces_lagg_edit.php:0 0.1673 1824440 2. build_member_list() /usr/local/www/interfaces_lagg_edit.php:249 0.1679 1826392 3. stristr() /usr/local/www/interfaces_lagg_edit.php:234 Warning: stristr() expects parameter 1 to be string, array given in /usr/local/www/interfaces_lagg_edit.php on line 234 Call Stack: 0.0001 237224 1. {main}() /usr/local/www/interfaces_lagg_edit.php:0 0.1673 1824440 2. build_member_list() /usr/local/www/interfaces_lagg_edit.php:249 0.1682 1826584 3. stristr() /usr/local/www/interfaces_lagg_edit.php:234 Warning: stristr() expects parameter 1 to be string, array given in /usr/local/www/interfaces_lagg_edit.php on line 234 Call Stack: 0.0001 237224 1. {main}() /usr/local/www/interfaces_lagg_edit.php:0 0.1673 1824440 2. build_member_list() /usr/local/www/interfaces_lagg_edit.php:249 0.1684 1826768 3. stristr() /usr/local/www/interfaces_lagg_edit.php:234 Warning: stristr() expects parameter 1 to be string, array given in /usr/local/www/interfaces_lagg_edit.php on line 234 Call Stack: 0.0001 237224 1. {main}() /usr/local/www/interfaces_lagg_edit.php:0 0.1673 1824440 2. build_member_list() /usr/local/www/interfaces_lagg_edit.php:249 0.1687 1826952 3. stristr() /usr/local/www/interfaces_lagg_edit.php:234

                2.3-ALPHA (amd64)
                built on Wed Dec 23 05:35:02 CST 2015
                FreeBSD 10.2-STABLE

                1 Reply Last reply Reply Quote 0
                • S Offline
                  Steve_B Netgate
                  last edited by

                  Would you please update and retest? I found that this fix was merged and appears to correct the issue.

                  Als ik kan

                  1 Reply Last reply Reply Quote 0
                  • T Offline
                    tcsac
                    last edited by

                    I don't have a good way to test it with the system I'm currently running, but it appears to be fixed.  If I pick an interface that's invalid, in the past it would spit out those php errors, when I do it now, it actually responds with something reasonable:

                    The following input errors were detected:
                    Interface supplied as member is invalid
                    Interface supplied as member is invalid

                    1 Reply Last reply Reply Quote 0
                    • First post
                      Last post
                    Copyright 2025 Rubicon Communications LLC (Netgate). All rights reserved.