Firewall Log Widget Entries



  • The entries in the firewall log widget are too big and take up too much screen space.  See image.  Perhaps a smaller font for that widget?




  • That's the result of this PR.

    https://github.com/pfsense/pfsense/pull/2436

    Hoping they revert it.

    Considering the context, audience, and space constraints those abbreviations are appropriate.


  • Developer Netgate

    I think we should probably back that one out and look at where it makes sense to retain the abbreviations. I'll take a look.



  • @Steve_B:

    I think we should probably back that one out and look at where it makes sense to retain the abbreviations. I'll take a look.

    He looked and he has backed out the change: https://github.com/pfsense/pfsense/commit/909002e29bd709534cb771284dd8919aff6d1665
    :)



  • Yes anything there that made columns unnecessarily wide should be reverted.

    Anyone see anything outside of what Steve reverted back that's problematic?



  • @cmb:

    Yes anything there that made columns unnecessarily wide should be reverted.

    Anyone see anything outside of what Steve reverted back that's problematic?

    diag_states_summary.php:
    Source Ports; Either abbreviate both source and destination or neither.

    firewall_nat.php:
    return all to as was.
    Frequently many of those fields have nothing in them but an asterisk.

    status_logs_filter.php:
    return all to as was.
    space better utilized by descriptions displayed as column.

    status_logs_filter_dynamic.php:
    if desired for consistency with status_logs_filter.php
    descriptions are not display in this mode so space is not so much a concern.

    Spelling out destination on the widget is probably fine since the field contents is pretty wide anyways.

    thanks


Log in to reply