Netgate Discussion Forum
    • Categories
    • Recent
    • Tags
    • Popular
    • Users
    • Search
    • Register
    • Login

    URL Table Alias Edit Bug

    Scheduled Pinned Locked Moved
    2.3-RC Snapshot Feedback and Issues - ARCHIVED
    3
    5
    1.3k
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • N
      NOYB
      last edited by

      Hey phil, or anyone who what's to contribute.  Here's a bug for ya.

      Firewall / Aliases Edit - Type URL Table (IPs)

      The address "mask" is being used as the update frequency in days.  But it does not seem to be retained (not populated with saved value when editing an existing alias).

      Looks like it saves it to the config.  Just doesn't seem to load it from config when editing.

      1 Reply Last reply Reply Quote 0
      • P
        phil.davis
        last edited by

        What format are you using to input the URL?
        I guess you have managed to successfully save one of these aliases. I tried using a format that I have in production use on a 2.2.6 system, like:

        http://server.company.org/block_lists/facebook.txt

        and the webGUI tells me "Please match the requested format".

        So the first thing I need to get past is to know what is now the "requested format" of the URL or fix the bug in input validation for that case.

        As the Greek philosopher Isosceles used to say, "There are 3 sides to every triangle."
        If I helped you, then help someone else - buy someone a gift from the INF catalog http://secure.inf.org/gifts/usd/

        1 Reply Last reply Reply Quote 0
        • N
          NOYB
          last edited by

          The html pattern there is incorrect.  Submitted a PR for it a few days ago but has not been merged.
          That field gets used for a variety of formats.  IPv4, IPv6, Alias, Port #, and URLs.  So for some types the character set is pretty well defined.  But not for URL.  The underscore and perhaps slashes in your URL is what's breaking it.

          https://github.com/pfsense/pfsense/pull/2449

          1 Reply Last reply Reply Quote 0
          • S
            Steve_B Netgate
            last edited by

            Sorry, I missed that one. Its a nice PR too :)

            Now merged.

            Thanks

            Als ik kan

            1 Reply Last reply Reply Quote 0
            • P
              phil.davis
              last edited by

              That was good to have it merged - saves messing about with possible conflicts.
              Here is PR https://github.com/pfsense/pfsense/pull/2463 to fix the problem with not re-loading the updatefreq on edit.

              As the Greek philosopher Isosceles used to say, "There are 3 sides to every triangle."
              If I helped you, then help someone else - buy someone a gift from the INF catalog http://secure.inf.org/gifts/usd/

              1 Reply Last reply Reply Quote 0
              • First post
                Last post