Firewall NAT GUI features



    1. Firewall NAT Port Forward and Outbound - the GUI has "add to the top" and "add to the end" buttons.
      But Firewall NAT 1:1 has only a single "add" button.

    Should we make 1:1 have both "add to the top" and "add to the end" buttons to be consistent?

    1. Firewall NAT 1:1 has a button to toggle disabled status of each mapping.
      But Firewall NAT Port Forward does not have that at all, and Firewall NAT Outbound shows the disabled status but does not let the user click to toggle it.

    Should we make them all have the "toggle disabled status" feature the same as 1:1?

    1. I made PR https://github.com/pfsense/pfsense/pull/2473 to make Firewall NAT NPt have all the "standard" GUI features for rule add/delete/duplicate/reorder… as 1:1 - that makes the GUI of both of those look and behave consistently.

    I am happy to do (1) and (2) if nobody has a reason not to.



  • Sounds good to me.  I say go for it.



  • +1



  • https://github.com/pfsense/pfsense/pull/2479 Provide "add top" and "add bottom" buttons for NAT 1:1 and NPt
    https://github.com/pfsense/pfsense/pull/2480 Firewall NAT Port Forward rule enable/disable toggle
    https://github.com/pfsense/pfsense/pull/2481 Allow enable/disable rule for Firewall NAT Out

    Those address all the NAT GUI consistency items in this thread. After all that, I think that all the Firewall/NAT/* GUI pages will have consistent features.



  • That has all been merged. Please report any further inconsistencies that you notice.



  • How about the enabled/disabled ex and check marks being red and green like they are in firewall rules.  Just a shading of the same color doesn't standout as well.



  • @NOYB:

    How about the enabled/disabled ex and check marks being red and green like they are in firewall rules.  Just a shading of the same color doesn't standout as well.

    In Firewall Rules the tick/cross indicates a pass/block rule. Currently the front Firewall Rules tabular display does not have a tick/cross column for enable/disable of the rule.
    So it might be a bit confusing for green/red to indicate pass/block in one context and enable/disable in another.

    Should the enabled/disabled colors be a different pair to the pass/block colors?
    Maybe blue tick (enabled - like now) and orange cross (disabled)? or?


Log in to reply