Netgate Discussion Forum
    • Categories
    • Recent
    • Tags
    • Popular
    • Users
    • Search
    • Register
    • Login

    Firewall NAT GUI features

    Scheduled Pinned Locked Moved 2.3-RC Snapshot Feedback and Issues - ARCHIVED
    7 Posts 3 Posters 2.1k Views
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • P
      phil.davis
      last edited by

      1. Firewall NAT Port Forward and Outbound - the GUI has "add to the top" and "add to the end" buttons.
        But Firewall NAT 1:1 has only a single "add" button.

      Should we make 1:1 have both "add to the top" and "add to the end" buttons to be consistent?

      1. Firewall NAT 1:1 has a button to toggle disabled status of each mapping.
        But Firewall NAT Port Forward does not have that at all, and Firewall NAT Outbound shows the disabled status but does not let the user click to toggle it.

      Should we make them all have the "toggle disabled status" feature the same as 1:1?

      1. I made PR https://github.com/pfsense/pfsense/pull/2473 to make Firewall NAT NPt have all the "standard" GUI features for rule add/delete/duplicate/reorder… as 1:1 - that makes the GUI of both of those look and behave consistently.

      I am happy to do (1) and (2) if nobody has a reason not to.

      As the Greek philosopher Isosceles used to say, "There are 3 sides to every triangle."
      If I helped you, then help someone else - buy someone a gift from the INF catalog http://secure.inf.org/gifts/usd/

      1 Reply Last reply Reply Quote 0
      • N
        NOYB
        last edited by

        Sounds good to me.  I say go for it.

        1 Reply Last reply Reply Quote 0
        • M
          maverick_slo
          last edited by

          +1

          1 Reply Last reply Reply Quote 0
          • P
            phil.davis
            last edited by

            https://github.com/pfsense/pfsense/pull/2479 Provide "add top" and "add bottom" buttons for NAT 1:1 and NPt
            https://github.com/pfsense/pfsense/pull/2480 Firewall NAT Port Forward rule enable/disable toggle
            https://github.com/pfsense/pfsense/pull/2481 Allow enable/disable rule for Firewall NAT Out

            Those address all the NAT GUI consistency items in this thread. After all that, I think that all the Firewall/NAT/* GUI pages will have consistent features.

            As the Greek philosopher Isosceles used to say, "There are 3 sides to every triangle."
            If I helped you, then help someone else - buy someone a gift from the INF catalog http://secure.inf.org/gifts/usd/

            1 Reply Last reply Reply Quote 0
            • P
              phil.davis
              last edited by

              That has all been merged. Please report any further inconsistencies that you notice.

              As the Greek philosopher Isosceles used to say, "There are 3 sides to every triangle."
              If I helped you, then help someone else - buy someone a gift from the INF catalog http://secure.inf.org/gifts/usd/

              1 Reply Last reply Reply Quote 0
              • N
                NOYB
                last edited by

                How about the enabled/disabled ex and check marks being red and green like they are in firewall rules.  Just a shading of the same color doesn't standout as well.

                1 Reply Last reply Reply Quote 0
                • P
                  phil.davis
                  last edited by

                  @NOYB:

                  How about the enabled/disabled ex and check marks being red and green like they are in firewall rules.  Just a shading of the same color doesn't standout as well.

                  In Firewall Rules the tick/cross indicates a pass/block rule. Currently the front Firewall Rules tabular display does not have a tick/cross column for enable/disable of the rule.
                  So it might be a bit confusing for green/red to indicate pass/block in one context and enable/disable in another.

                  Should the enabled/disabled colors be a different pair to the pass/block colors?
                  Maybe blue tick (enabled - like now) and orange cross (disabled)? or?

                  As the Greek philosopher Isosceles used to say, "There are 3 sides to every triangle."
                  If I helped you, then help someone else - buy someone a gift from the INF catalog http://secure.inf.org/gifts/usd/

                  1 Reply Last reply Reply Quote 0
                  • First post
                    Last post
                  Copyright 2025 Rubicon Communications LLC (Netgate). All rights reserved.