NEW Monitoring graph

jdillard

Hmm this doesn`2t look right.
I intentionally selected IPsec iface as in last 8 hours there was 0 traffic.
Green line seems to be left over from quality graph.
I checked with multiple browsers, same behaviour.

Did you have a graph selected before going back to none on the right axis? I haven't figured out a fix for that yet…

maverick_slo

Yup, thats the case.
Default I have 2 wans quality then I change to traffic and remove right axis…

jdillard

@maverick_slo:

Yup, thats the case.
Default I have 2 wans quality then I change to traffic and remove right axis…

I just changed it to draw the graphs from scratch every time and it fixed this issue (and also got rid of a bunch of duplicate code). Everything should behave the same, but you may want to double check everything.

MikeV7896

@jdillard:

…but try running the following instead of editing:
sort -u -o /usr/local/etc/php/extensions.ini /usr/local/etc/php/extensions.ini

Yeah, there's nothing to sort in an empty file… :)

Unless one of those filenames should be something else? :)

Edit: Or, unless you were referring to sorting AFTER updating? Couldn't tell...

jdillard

I somehow missed the empty part of the post :-[

Let me get back with Garga, he set up that part.

NOYB

@jdillard:

@maverick_slo:

Yup, thats the case.
Default I have 2 wans quality then I change to traffic and remove right axis…

I just changed it to draw the graphs from scratch every time and it fixed this issue (and also got rid of a bunch of duplicate code). Everything should behave the same, but you may want to double check everything.

Would be nice if the draw_graph function had an option to "redraw" instead. Seems that draw from scratch should only be needed if the graph options have changed. That way updating same graph would be smoother, and probably more efficient too.

jdillard

I might have to redo that for after 2.3 and can include the auto-update and multi-option stuff you worked on at that point.

There has got to be a better way that reuses more of the code…

NOYB

@jdillard:

I might have to redo that for after 2.3 and can include the auto-update and multi-option stuff you worked on at that point.

There has got to be a better way that reuses more of the code…

Thanks for the setting expectations update. I've been and still am using both the auto updating and quick links and love them.

P.S. With draw from scratch the graph type works now. So may want to enable bar graph selection.

NOYB

After the latest monitoring rev I notice that if the graph is refreshed while a tool-tip is displayed that the tool-tip becomes permanent. Moving the mouse/pointer back over the graph will still bring up a new tool-tip display but the not remove the previous one.

heper

@maverick_slo:

Hmm this doesn`2t look right.
I intentionally selected IPsec iface as in last 8 hours there was 0 traffic.
Green line seems to be left over from quality graph.
I checked with multiple browsers, same behaviour.

yes when changing rrd type or interface it, sometimes, it keeps the lines of the previous graph.

maverick_slo

Hi all!

Latest package fixed my issue.
Thanks!

jdillard

@NOYB:

@jdillard:

I might have to redo that for after 2.3 and can include the auto-update and multi-option stuff you worked on at that point.

There has got to be a better way that reuses more of the code…

Thanks for the setting expectations update. I've been and still am using both the auto updating and quick links and love them.

P.S. With draw from scratch the graph type works now. So may want to enable bar graph selection.

No problem. Thanks for all the help! Seriously.

The code has been a little volatile, but I think it is about to settle down. I see moving a lot of repetitive code to functions (but that shouldn't really effect future additions much) and also adding an update bit to the draw_function that skips over code on an update (just an idea at this point). Just trying to keep the code maintainable so we can keep adding to it without the complexity killing us.

jdillard

@heper:

yes when changing rrd type or interface it, sometimes, it keeps the lines of the previous graph.

This is fixed now: https://forum.pfsense.org/index.php?topic=107790.msg605180#msg605180

jdillard

@NOYB:

After the latest monitoring rev I notice that if the graph is refreshed while a tool-tip is displayed that the tool-tip becomes permanent. Moving the mouse/pointer back over the graph will still bring up a new tool-tip display but the not remove the previous one.

Just pushed an update that fixes this. thanks for catching/reporting it!

jdillard

@virgiliomi:

@jdillard:
…but try running the following instead of editing:
sort -u -o /usr/local/etc/php/extensions.ini /usr/local/etc/php/extensions.ini
Yeah, there's nothing to sort in an empty file… :)

Unless one of those filenames should be something else? :)

Edit: Or, unless you were referring to sorting AFTER updating? Couldn't tell...

After talking with Garga we aren't quite sure what happened as it seems to have only affected a few people I would make the fix (fill in the file) and upgrade normally after. That problem seems to have hit at a certain snapshot and not come up since, so hopefully whatever caused the issue is behind us.

NOYB

I've also seen the call to undefined function fetch_rrd() a few times over the past couple of weeks.
In my case it has only happened after a "crash" on second reboot after update.

Steps:

Update (auto reboots and all is fine).
Console option 6 (shutdown).
Create VM snapshot.
Boot pfSense - something goes awry and screen messages scroll for a few seconds like disk clean up from ungraceful shutdown. System auto reboots fine but then fetch_rrd() call issue occurs.

I've never tried to trouble shoot cause. Just restore previous VM snapshot and re-update.

emko

for the last two builds i cant get the graphs to show

where the graph is to show i get a red box with "Error: SyntaxError: Unexpected token F"

and in the logs i get

Crash report details:

PHP Errors:
[26-Mar-2016 02:16:58 Etc/GMT-7] PHP Fatal error: Call to undefined function rrd_fetch() in /usr/local/www/rrd_fetch_json.php on line 130

emko

@emko:

for the last two builds i cant get the graphs to show

where the graph is to show i get a red box with "Error: SyntaxError: Unexpected token F"

and in the logs i get

Crash report details:

PHP Errors:
[26-Mar-2016 02:16:58 Etc/GMT-7] PHP Fatal error: Call to undefined function rrd_fetch() in /usr/local/www/rrd_fetch_json.php on line 130

I am on

2.3-BETA (amd64)
built on Sat Mar 26 19:54:12 CDT 2016
FreeBSD 10.3-RELEASE

still same problem does no one else have this?

MikeV7896

@emko:

still same problem does no one else have this?

Follow the directions in this post, then I'd reboot to make sure PHP is all clean. If you're not a console editor type, you can use Diagnostics > Edit File to edit the file in question (it'll likely be blank). Paste in the code from that post, then save the file and reboot.

jdillard

@emko:

@emko:

for the last two builds i cant get the graphs to show

where the graph is to show i get a red box with "Error: SyntaxError: Unexpected token F"

and in the logs i get

Crash report details:

PHP Errors:
[26-Mar-2016 02:16:58 Etc/GMT-7] PHP Fatal error: Call to undefined function rrd_fetch() in /usr/local/www/rrd_fetch_json.php on line 130

I am on

2.3-BETA (amd64)
built on Sat Mar 26 19:54:12 CDT 2016
FreeBSD 10.3-RELEASE

still same problem does no one else have this?

I created a redmine ticket that summarizes the information from this thread:

https://redmine.pfsense.org/issues/6041

If you have anything to add I would do it there as to keep the information in one place.

edit: Garga thinks he already found a fix (talk about fast!): https://github.com/pfsense/pfsense/commit/475f0b6dbd9d93e96e58b4b54870c9aa760e99f7