Netgate Discussion Forum
    • Categories
    • Recent
    • Tags
    • Popular
    • Users
    • Search
    • Register
    • Login

    Firewall Alias Item Double Quotation Mark Causes ACL Display Issue

    Scheduled Pinned Locked Moved 2.3-RC Snapshot Feedback and Issues - ARCHIVED
    3 Posts 3 Posters 1.0k Views
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • G
      Gram
      last edited by

      It looks like the double quote character isn't properly escaped on Firewall Alias list items. It causes some issues when viewing the ACL.

      Working without double quotation:

      Broken with double quotation:

      Screenshot_20160402_160051.png
      Screenshot_20160402_160051.png_thumb
      Screenshot_20160402_160129.png
      Screenshot_20160402_160129.png_thumb
      Screenshot_20160402_160345.png
      Screenshot_20160402_160345.png_thumb
      Screenshot_20160402_160424.png
      Screenshot_20160402_160424.png_thumb

      1 Reply Last reply Reply Quote 0
      • J
        JorgeOliveira
        last edited by

        Hello,

        I have dug a little on the issue and seems certain parts of the GUI don't have calls to htmlspecialchars and such may cause this problem.

        I'd advise the following change on /usr/local/www/guiconfig.inc line 1115:

        $content .= 			$alias_details[$idx];
        

        To

        $content .= 			htmlspecialchars($alias_details[$idx]);
        

        This may fix the issue you're seeing and hopefully not cause any drawbacks.

        Regards,
        Jorge M. Oliveira

        My views have absolutely no warranty express or implied. Always do your own research.

        1 Reply Last reply Reply Quote 0
        • S
          Steve_B Netgate
          last edited by

          Thanks.

          The suggested fix has been applied.

          Als ik kan

          1 Reply Last reply Reply Quote 0
          • First post
            Last post
          Copyright 2025 Rubicon Communications LLC (Netgate). All rights reserved.