Notices > GEOM Mirror Status Change, "gmirror" Button broken & annoying Notices

[fusl]

Hi,

running 2.3-RELEASE, after a power outage today I noticed that pfSense keeps track of the gmirror status which will end up spamming notices until the rebuild/sync is done:

[quite]gmirror - Mirror pfSenseMirror drive status changed. Old: (ada0 (SYNCHRONIZING, 2%), ada1 (ACTIVE)) New: (ada0 (SYNCHRONIZING, 4%), ada1 (ACTIVE))  @ 2016-04-29 12:47:09
gmirror - Mirror pfSenseMirror drive status changed. Old: (ada0 (SYNCHRONIZING, 4%), ada1 (ACTIVE)) New: (ada0 (SYNCHRONIZING, 5%), ada1 (ACTIVE))  @ 2016-04-29 12:48:09
gmirror - Mirror pfSenseMirror drive status changed. Old: (ada0 (SYNCHRONIZING, 5%), ada1 (ACTIVE)) New: (ada0 (SYNCHRONIZING, 6%), ada1 (ACTIVE))  @ 2016-04-29 12:49:09
gmirror - Mirror pfSenseMirror drive status changed. Old: (ada0 (SYNCHRONIZING, 6%), ada1 (ACTIVE)) New: (ada0 (SYNCHRONIZING, 8%), ada1 (ACTIVE))  @ 2016-04-29 12:50:09
gmirror - Mirror pfSenseMirror drive status changed. Old: (ada0 (SYNCHRONIZING, 8%), ada1 (ACTIVE)) New: (ada0 (SYNCHRONIZING, 9%), ada1 (ACTIVE))  @ 2016-04-29 12:51:09
gmirror - Mirror pfSenseMirror drive status changed. Old: (ada0 (SYNCHRONIZING, 9%), ada1 (ACTIVE)) New: (ada0 (SYNCHRONIZING, 11%), ada1 (ACTIVE)) @ 2016-04-29 12:52:09
gmirror - Mirror pfSenseMirror drive status changed. Old: (ada0 (SYNCHRONIZING, 11%), ada1 (ACTIVE)) New: (ada0 (SYNCHRONIZING, 12%), ada1 (ACTIVE))    @ 2016-04-29 12:53:09
gmirror - Mirror pfSenseMirror drive status changed. Old: (ada0 (SYNCHRONIZING, 12%), ada1 (ACTIVE)) New: (ada0 (SYNCHRONIZING, 13%), ada1 (ACTIVE))    @ 2016-04-29 12:54:10
gmirror - Mirror pfSenseMirror drive status changed. Old: (ada0 (SYNCHRONIZING, 13%), ada1 (ACTIVE)) New: (ada0 (SYNCHRONIZING, 15%), ada1 (ACTIVE))    @ 2016-04-29 12:55:10
gmirror - Mirror pfSenseMirror drive status changed. Old: (ada0 (SYNCHRONIZING, 15%), ada1 (ACTIVE)) New: (ada0 (SYNCHRONIZING, 16%), ada1 (ACTIVE))    @ 2016-04-29 12:56:10
gmirror - Mirror pfSenseMirror drive status changed. Old: (ada0 (SYNCHRONIZING, 16%), ada1 (ACTIVE)) New: (ada0 (SYNCHRONIZING, 18%), ada1 (ACTIVE))    @ 2016-04-29 12:57:10
gmirror - Mirror pfSenseMirror drive status changed. Old: (ada0 (SYNCHRONIZING, 18%), ada1 (ACTIVE)) New: (ada0 (SYNCHRONIZING, 19%), ada1 (ACTIVE))    @ 2016-04-29 12:58:10
gmirror - Mirror pfSenseMirror drive status changed. Old: (ada0 (SYNCHRONIZING, 20%), ada1 (ACTIVE)) New: (ada0 (SYNCHRONIZING, 22%), ada1 (ACTIVE))    @ 2016-04-29 13:00:10
gmirror - Mirror pfSenseMirror drive status changed. Old: (ada0 (SYNCHRONIZING, 22%), ada1 (ACTIVE)) New: (ada0 (SYNCHRONIZING, 23%), ada1 (ACTIVE))    @ 2016-04-29 13:01:10[/quote}

This is really annoying and a single notice for status change from OK to SYNCHRONIZING and SYNCHRONIZING back to OK (or whatever the status of an in-sync gmirror is) should be fine.

Second, the GUI apparently links the text "gmirror" to somewhere, however this link doesn't exist:

[code]* gmirror -
Mirror pfSenseMirror drive status changed. Old: (ada0 (SYNCHRONIZING, 20%), ada1 (ACTIVE)) New: (ada0 (SYNCHRONIZING, 22%), ada1 (ACTIVE)) @ 2016-04-29 13:00:10

[jimp]

It sends a notice if the new status is different than the old status. Detecting just a change from one complete state to another would require a lot more logic.

The spamminess is a side effect of it checking that status each minute. Though if it did the check less often there's a chance it could miss something important.

Personally, I like the updates to know it's still progressing. If the rebuild stalled I'd know about it fairly quickly.