new System Patches v2.0

luckman212

@jimp Ok got it, thank you

JeGr

@jimp Hey Jim,

just tested the new Patches System and custom patches that worked fine before (2.5.2 with the old system patches module) aren't fetched anymore. In particular, there's a possible fix for the GW failback regression that we tested and cherry picked from the Redmine:

GW failback regression
Commit ID: ec73bb89489d830ec21c4e04ffa3ec401791b55d

Entering that in the Desc/ID fields and saving worked perfectly with 2.5.2.
In the new SysPatch Package, saving and fetching that results in only the URL being expanded but nothing thereafter. Even if the URL is correct (I copy&pasted it into a browser - shows the diff just fine), it isn't fetched into system patches anymore.

Tested on: SG2100, 22.01, newest Package 2.0_3 installed before.

Edit: confirmed, on an older system with 22.01 installed and System Patches in version 1.2_7 it's working just fine. So seems 2.0.x has broken something in fetching Github IDs

Cheers

chudak

@jegr

Just tried that commit
It was fetched but can't be applied

JeGr

@chudak If you edit your "test" can you see if the ID got expanded to the URI? That seems to work but otherwise the fetch leave the content field empty. In an older version of system patches (1.2_7) that worked and still works perfectly fine. And of course - without content - nothing can be applied or reverted ;)

Gertjan

@jegr @chudak Jimp said in another thread / post that the patch system has a little issue : patch link is expanded, but patch is not downloaded - "Patch Contents" box stays empty.
That will get resolved 'soon'.

The expanded patch URL can be used in a browser to see the patch, then copy all, and paste in the "Patch Contents" box and you'll be fine.

jimp

New package is building now with fixes for the fetch issue and a couple new patches.

chudak

@jimp said in new System Patches v2.0:

New package is building now with fixes for the fetch issue and a couple new patches.

Updated, applied fixes, and tested fetch, all good!

Thx @jimp

luckman212

@jimp I had to flip my update branch from 22.05 to 22.01 in order to see the 2.0_4 version. I installed it and then flipped back to the 22.05 track. Is that "normal"?

jimp

Snapshots only get packages built overnight with the full snapshot build so they whole set is consistent as we may make several changes throughout the day.

It'll come along naturally when you pick up the new snapshot tomorrow morning.

chudak

@luckman212 said in new System Patches v2.0:

@jimp I had to flip my update branch from 22.05 to 22.01 in order to see the 2.0_4 version. I installed it and then flipped back to the 22.05 track. Is that "normal"?

I didn’t have to do this
FYI