PHP Errors after 23.01 upgrade

maverickws

Just got this error when changed a configuration on pfblockerng-devetl:

Crash report begins.  Anonymous machine information:

amd64
14.0-CURRENT
FreeBSD 14.0-CURRENT #0 plus-RELENG_23_01-n256037-6e914874a5e: Fri Feb 10 20:30:29 UTC 2023     root@freebsd:/var/jenkins/workspace/pfSense-Plus-snapshots-23_01-main/obj/amd64/VDZvZksF/var/jenkins/workspace/pfSense-Plus-snapshots-23_01-main/sources/FreeBS

Crash report details:

PHP Errors:
[17-Feb-2023 12:24:13 Europe/Lisbon] PHP Fatal error:  Uncaught TypeError: Cannot access offset of type string on string in /usr/local/www/xmlrpc.php(147) : eval()'d code:14
Stack trace:
#0 /usr/local/www/xmlrpc.php(147): eval()
#1 /usr/local/share/pear/XML/RPC2/Server/CallHandler/Instance.php(141): pfsense_xmlrpc_server->exec_php('\nini_set('displ...')
#2 /usr/local/share/pear/XML/RPC2/Backend/Php/Server.php(135): XML_RPC2_Server_Callhandler_Instance->__call('pfsense.exec_ph...', Array)
#3 /usr/local/share/pear/XML/RPC2/Backend/Php/Server.php(99): XML_RPC2_Backend_Php_Server->getResponse()
#4 /usr/local/www/xmlrpc.php(988): XML_RPC2_Backend_Php_Server->handleCall()
#5 {main}
  thrown in /usr/local/www/xmlrpc.php(147) : eval()'d code on line 14

No FreeBSD crash data found.

The error itself seems a pfSense error not directly with the module.

jimp

That is not coming from pfSense itself as far as I can see. You have something external hitting the XMLRPC service on the firewall and it is using some outdated syntax.

The last couple times we saw similar reports on the Beta/RC version it was from the Home Assistant integration and I think in the case with the error you're getting, updating the integration solved it.

If that is not the case for you, monitor /var/log/nginx.log and see what is sending POST requests to xmlrpc.php and trace it back from there.

maverickws

Hi @jimp thanks a lot for the reply.
Well, I do have an HA instance in the local network. But when you mention "updating the integration solved it", I'm not entirely sure what you mean, by this I mean I have HA up to date and I don't have any "integration package" installed on pfSense.

Should I delete the integration from HA and reinstall it?

Thanks!!

jimp

I mean the pfSense integration in Home Assistant needed to be updated, not anything on pfSense itself or in the core of Home Assistant.

I'm not sure how that might usually be done since I'm not terribly familiar with Home Assistant/HACS yet, but uninstalling and installing the latest copy of the integration from HACS (or Git if you installed that way) would be a good place to start.

maverickws

Ok so I'm not the greatest pro in HA either, I actually have it running configured it simply to gather some values history and pass devices to Apple's HomeKit.

I deleted the pfSense integration, then re-added and reconfigured it in HA.

Doing the same action on pfSense:

Firewall > pfBlockerNG > tick off "enable" and save results in the same error.

stephenw10

Looks like a different issue. This was what we saw previously: https://redmine.pfsense.org/issues/13944
That is in 23.01-REL though.

You might check the thread from that to how your HA config differs from those users who are no longer seeing errors:
https://forum.netgate.com/topic/177508/flock-error-after-upgrading

Steve

maverickws

@stephenw10 alright so I applied the proposed fix on that topic (flock-error) and that fix solved it. Thanks!

stephenw10

The patch shown? That is already in 23.01. It would be odd if you were able to apply it again.

maverickws

@stephenw10 I guess I just removed and pasted and didn't really pay attention to what was before. But confirmed on another 23.01 and indeed it is.

So I have no idea about what 'fixed it'. I repeat the same steps as before when I got the error, and I can't replicate.