pfSense Plus 23.01 XMLRPC Sync problems when addiing CARP VIPs

Crash report begins.  Anonymous machine information:

amd64
14.0-CURRENT
FreeBSD 14.0-CURRENT #0 plus-RELENG_23_01-n256037-6e914874a5e: Fri Feb 10 20:30:29 UTC 2023     root@freebsd:/var/jenkins/workspace/pfSense-Plus-snapshots-23_01-main/obj/amd64/VDZvZksF/var/jenkins/workspace/pfSense-Plus-snapshots-23_01-main/sources/FreeBS

Crash report details:

PHP Errors:
[07-Mar-2023 00:09:46 Europe/Berlin] PHP Fatal error:  Uncaught TypeError: Cannot access offset of type string on string in /usr/local/www/xmlrpc.php:399
Stack trace:
#0 /usr/local/share/pear/XML/RPC2/Server/CallHandler/Instance.php(141): pfsense_xmlrpc_server->restore_config_section(Array, 900)
#1 /usr/local/share/pear/XML/RPC2/Backend/Php/Server.php(135): XML_RPC2_Server_Callhandler_Instance->__call('pfsense.restore...', Array)
#2 /usr/local/share/pear/XML/RPC2/Backend/Php/Server.php(99): XML_RPC2_Backend_Php_Server->getResponse()
#3 /usr/local/www/xmlrpc.php(988): XML_RPC2_Backend_Php_Server->handleCall()
#4 {main}
  thrown in /usr/local/www/xmlrpc.php on line 399
[07-Mar-2023 00:10:58 Europe/Berlin] PHP Fatal error:  Uncaught TypeError: Cannot access offset of type string on string in /usr/local/www/xmlrpc.php:399
Stack trace:
#0 /usr/local/share/pear/XML/RPC2/Server/CallHandler/Instance.php(141): pfsense_xmlrpc_server->restore_config_section(Array, 900)
#1 /usr/local/share/pear/XML/RPC2/Backend/Php/Server.php(135): XML_RPC2_Server_Callhandler_Instance->__call('pfsense.restore...', Array)
#2 /usr/local/share/pear/XML/RPC2/Backend/Php/Server.php(99): XML_RPC2_Backend_Php_Server->getResponse()
#3 /usr/local/www/xmlrpc.php(988): XML_RPC2_Backend_Php_Server->handleCall()
#4 {main}
  thrown in /usr/local/www/xmlrpc.php on line 399
[07-Mar-2023 00:12:10 Europe/Berlin] PHP Fatal error:  Uncaught TypeError: Cannot access offset of type string on string in /usr/local/www/xmlrpc.php:399
Stack trace:
#0 /usr/local/share/pear/XML/RPC2/Server/CallHandler/Instance.php(141): pfsense_xmlrpc_server->restore_config_section(Array, 900)
#1 /usr/local/share/pear/XML/RPC2/Backend/Php/Server.php(135): XML_RPC2_Server_Callhandler_Instance->__call('pfsense.restore...', Array)
#2 /usr/local/share/pear/XML/RPC2/Backend/Php/Server.php(99): XML_RPC2_Backend_Php_Server->getResponse()
#3 /usr/local/www/xmlrpc.php(988): XML_RPC2_Backend_Php_Server->handleCall()
#4 {main}
  thrown in /usr/local/www/xmlrpc.php on line 399



No FreeBSD crash data found.

Line 399 is around this code part in xmlrpc.php:

                $vipbackup = array();
                $oldvips = array();
                if (isset($sections['virtualip']) &&
                    is_array($config['virtualip']['vip'])) {
                        foreach ($config['virtualip']['vip'] as $vip) {

Therefore, I deselected "Virtual IP" under "Select options to sync" and at least it does not generate these crash reports anymore. Of course, it wont sync the VIP settings.

PS: I opened a ticket at Netgate's TAC Support.

roesh

It seems to be a known issue: https://redmine.pfsense.org/issues/14034

williwinkie

Same problem here, got two new 1541's[08-Mar-2023 12:23:52 Europe/Berlin] PHP Fatal error: Uncaught TypeError: Cannot access offset of type string on string in /usr/local/www/xmlrpc.php:399
Stack trace:
#0 /usr/local/share/pear/XML/RPC2/Server/CallHandler/Instance.php(141): pfsense_xmlrpc_server->restore_config_section(Array, 900)
#1 /usr/local/share/pear/XML/RPC2/Backend/Php/Server.php(135): XML_RPC2_Server_Callhandler_Instance->__call('pfsense.restore...', Array)
#2 /usr/local/share/pear/XML/RPC2/Backend/Php/Server.php(99): XML_RPC2_Backend_Php_Server->getResponse()
#3 /usr/local/www/xmlrpc.php(988): XML_RPC2_Backend_Php_Server->handleCall()
#4 {main}
thrown in /usr/local/www/xmlrpc.php on line 399

Not the first time I've setup HA Systems, usually work straight away but this one is making me go bald

jimp

As mentioned above it's a bug in 23.01 (#14034)

The configuration on the secondary has an empty <virtualips> tag which is tripping up that PHP code. If you go on the secondary and add a dummy VIP, then the sync will succeed and you can delete the dummy entry if the sync doesn't do that on its own.

roesh

@jimp Yes, once the secondary pfsense has some CARP virtual IP addresses, the error vanishes.

Deselecting the "Virtual IP" under "Select options to sync" does not work in the end, if one likes to also use DHCP failover.

nick.loenders

@roesh @jimp

I added another new CARP VIP, but the interface stays DOWN ?