Traffic Graph PHP error

jordanp123

When watching traffic on the traffic graph (using iftop), I receieve a PHP error after letting it run for several minutes. I wasn't sure if this is a known issue or just something specific to my installation but its happened a few times now. PHP_errors.log.zip

stephenw10

Didn't see anything for that so I opened one: https://redmine.pfsense.org/issues/14236

Steve

jimp

I haven't managed to reproduce this yet but I can see how it might happen and I worked up what I hope is a fix.

You can install the System Patches package and then create an entry for 2eb25975691c95ea86c0df0a60c16bb9a70d4067 to apply the fix.

If you can apply that and run with it for a while and confirm that (a) the table data is displayed correctly and (b) there are no PHP errors, that would be very helpful. Thanks!

jordanp123

@jimp
Applied the patch just a minute ago, everything so far appears to be running well, I'll keep the window running for awhile to see if anything happens and I'll report back, all the data its reporting though appears to be what I would expect.

jordanp123

@jimp
Everything has worked perfect, data looks good and no crashes, even after leaving the window up for about 2 hours.

mcury

I was able to reproduce it.
I'll apply this patch.

PHP errors

PHP ERROR: Type: 1, File: /etc/inc/util.inc, Line: 2208, Message: Uncaught TypeError: round(): Argument #1 ($num) must be of type int|float, string given in /etc/inc/util.inc:2208
Stack trace:
#0 /etc/inc/util.inc(2208): round('', 2)
#1 /usr/local/pfSense/include/www/bandwidth_by_ip.inc(172): format_number('', 2)
#2 /usr/local/www/bandwidth_by_ip.php(36): printBandwidth('wan', 'local', 'in', '', 'iftop')
#3 {main}