23.01 Squid issue

stephenw10

No, I mean in the main pfSense config file (/cfconf/config.xml) did it create a set of tags: <squidreversegeneral>
The lack of that config section is what causes that error.

Steve

psUser

@stephenw10

               </patches>
               <squidreversegeneral></squidreversegeneral>
               <ntopng>
                       <config>

stephenw10

Ok, so if you save the settings on the Squid Reverse page does that config get populated?

Where exactly are you seeing the error?

psUser

@stephenw10

if I do change or with changing anything I press "save" button, I will be "redirected" to some page:

https://192.168.3.1/pkg_edit.php?xml=squid.xml&id=0

Fatal error: Uncaught TypeError: Cannot access offset of type string on string in /usr/local/pkg/squid_reverse.inc:414 Stack trace: #0 /usr/local/pkg/squid.inc(751): squid_reverse_enabled() #1 /usr/local/www/pkg_edit.php(137) : eval()'d code(1): squid_validate_general(Array, Array) #2 /usr/local/www/pkg_edit.php(137): eval() #3 {main} thrown in /usr/local/pkg/squid_reverse.inc on line 414 PHP ERROR: Type: 1, File: /usr/local/pkg/squid_reverse.inc, Line: 414, Message: Uncaught TypeError: Cannot access offset of type string on string in /usr/local/pkg/squid_reverse.inc:414 Stack trace: #0 /usr/local/pkg/squid.inc(751): squid_reverse_enabled() #1 /usr/local/www/pkg_edit.php(137) : eval()'d code(1): squid_validate_general(Array, Array) #2 /usr/local/www/pkg_edit.php(137): eval() #3 {main} thrown

Zrzut ekranu z 2023-03-20 17-16-35.png

And then when I refresh GUI:

Netgate pfSense Plus has detected a crash report or programming bug. Click here for more information.

Crash report begins.  Anonymous machine information:

amd64
14.0-CURRENT
FreeBSD 14.0-CURRENT #0 plus-RELENG_23_01-n256037-6e914874a5e: Fri Feb 10 20:30:29 UTC 2023     root@freebsd:/var/jenkins/workspace/pfSense-Plus-snapshots-23_01-main/obj/amd64/VDZvZksF/var/jenkins/workspace/pfSense-Plus-snapshots-23_01-main/sources/FreeBS

Crash report details:

PHP Errors:
[20-Mar-2023 09:49:44 Europe/Warsaw] PHP Fatal error:  Uncaught TypeError: Cannot access offset of type string on string in /usr/local/pkg/squid_reverse.inc:414
Stack trace:
#0 /usr/local/pkg/squid.inc(751): squid_reverse_enabled()
#1 /usr/local/www/pkg_edit.php(137) : eval()'d code(1): squid_validate_general(Array, Array)
#2 /usr/local/www/pkg_edit.php(137): eval()
#3 {main}
  thrown in /usr/local/pkg/squid_reverse.inc on line 414
[20-Mar-2023 09:49:56 Europe/Warsaw] PHP Fatal error:  Uncaught TypeError: Cannot access offset of type string on string in /usr/local/pkg/squid_reverse.inc:414
Stack trace:
#0 /usr/local/pkg/squid.inc(751): squid_reverse_enabled()
#1 /usr/local/www/pkg_edit.php(137) : eval()'d code(1): squid_validate_general(Array, Array)
#2 /usr/local/www/pkg_edit.php(137): eval()
#3 {main}
  thrown in /usr/local/pkg/squid_reverse.inc on line 414
[20-Mar-2023 09:52:16 Europe/Warsaw] PHP Fatal error:  Uncaught TypeError: Cannot access offset of type string on string in /usr/local/pkg/squid_reverse.inc:414
Stack trace:
#0 /usr/local/pkg/squid.inc(751): squid_reverse_enabled()
#1 /usr/local/www/pkg_edit.php(137) : eval()'d code(1): squid_validate_general(Array, Array)
#2 /usr/local/www/pkg_edit.php(137): eval()
#3 {main}
  thrown in /usr/local/pkg/squid_reverse.inc on line 414
[20-Mar-2023 09:54:43 Europe/Warsaw] PHP Fatal error:  Uncaught TypeError: Cannot access offset of type string on string in /usr/local/pkg/squid_reverse.inc:414
Stack trace:
#0 /usr/local/pkg/squid.inc(751): squid_reverse_enabled()
#1 /usr/local/www/pkg_edit.php(137) : eval()'d code(1): squid_validate_general(Array, Array)
#2 /usr/local/www/pkg_edit.php(137): eval()
#3 {main}
  thrown in /usr/local/pkg/squid_reverse.inc on line 414
[20-Mar-2023 09:55:49 Europe/Warsaw] PHP Fatal error:  Uncaught TypeError: Cannot access offset of type string on string in /usr/local/pkg/squid_reverse.inc:414
Stack trace:
#0 /usr/local/pkg/squid.inc(751): squid_reverse_enabled()
#1 /usr/local/www/pkg_edit.php(137) : eval()'d code(1): squid_validate_general(Array, Array)
#2 /usr/local/www/pkg_edit.php(137): eval()
#3 {main}
  thrown in /usr/local/pkg/squid_reverse.inc on line 414
[20-Mar-2023 09:58:46 Europe/Warsaw] PHP Fatal error:  Uncaught TypeError: Cannot access offset of type string on string in /usr/local/pkg/squid_reverse.inc:414
Stack trace:
#0 /usr/local/pkg/squid.inc(751): squid_reverse_enabled()
#1 /usr/local/www/pkg_edit.php(137) : eval()'d code(1): squid_validate_general(Array, Array)
#2 /usr/local/www/pkg_edit.php(137): eval()
#3 {main}
  thrown in /usr/local/pkg/squid_reverse.inc on line 414
[20-Mar-2023 10:00:46 Europe/Warsaw] PHP Fatal error:  Uncaught TypeError: Cannot access offset of type string on string in /usr/local/pkg/squid_reverse.inc:414
Stack trace:
#0 /usr/local/pkg/squid.inc(751): squid_reverse_enabled()
#1 /usr/local/www/pkg_edit.php(137) : eval()'d code(1): squid_validate_general(Array, Array)
#2 /usr/local/www/pkg_edit.php(137): eval()
#3 {main}
  thrown in /usr/local/pkg/squid_reverse.inc on line 414
[20-Mar-2023 10:02:10 Europe/Warsaw] PHP Fatal error:  Uncaught TypeError: Cannot access offset of type string on string in /usr/local/pkg/squid_reverse.inc:414
Stack trace:
#0 /usr/local/pkg/squid.inc(751): squid_reverse_enabled()
#1 /usr/local/www/pkg_edit.php(137) : eval()'d code(1): squid_validate_general(Array, Array)
#2 /usr/local/www/pkg_edit.php(137): eval()
#3 {main}
  thrown in /usr/local/pkg/squid_reverse.inc on line 414
[20-Mar-2023 10:17:19 Europe/Warsaw] PHP Fatal error:  Uncaught TypeError: Cannot access offset of type string on string in /usr/local/pkg/squid_reverse.inc:414
Stack trace:
#0 /usr/local/pkg/squid.inc(751): squid_reverse_enabled()
#1 /usr/local/www/pkg_edit.php(137) : eval()'d code(1): squid_validate_general(Array, Array)
#2 /usr/local/www/pkg_edit.php(137): eval()
#3 {main}
  thrown in /usr/local/pkg/squid_reverse.inc on line 414



No FreeBSD crash data found.```

and any change isnt saved, and as I see doesnt get populated

psUser

@stephenw10

ok I make it works :

disabled in GUI - save worked
changed interfaces for squid - save button still works

from now on I wasnt able to enable in GUI squid, so Ive enabled squid by changing cfg file:

<enable_squid></enable_squid>
into
<enable_squid>on</enable_squid>

opened GUI and started squid, changes for now works

ofc save button still behave as it was before, so Im not able to make any changes in squid in GUI.

stephenw10

Hmm, and the <squidreversegeneral> section remains empty? You're unable to save the Reverse Squid page?

psUser

@stephenw10
yes empty,

                </patches>
                <squidreversegeneral></squidreversegeneral>
                <ntopng>
                        <config>
                                <enable>on</enable>
                                <keepdata>on</keepdata>

and yes Im unable to save the Reverse Squid page with the same error.

stephenw10

And that was the case both with and without Squid enabled?

Hmm, unclear what could cause that then. We might need to see your config directly to know more.

You should add your variation to the open bug for this:
https://redmine.pfsense.org/issues/13984

Steve

ben-ihelputech

It seems to me that squidguard is a dead project. The website for the project is down, and the last snapshot on the wayback machine for the site was almost a year ago. The error is blocking us from upgrading our firewalls. Should we consider using another solution, or will NetGate try to upgrade the package?

JonathanLee

@ben-ihelputech has it started working well so it was shut off ?? Mine works great never better. They updated the package also look up squid on Google Feb 2023 release. Don't give up I got it working. But I needed a fresh install. The redmine package will eventually get fixed

ben-ihelputech

@jonathanlee Squid proxy is still up, but squidguard is what I was referring to. www.http://squidguard.org/. This seems to be the bit of code causing issues.

stephenw10

It's seen patches more recently in FreeBSD:
https://www.freshports.org/www/squidguard/

JonathanLee

@stephenw10 I love Squidguard it works well for me. I use a French blacklist that works good.

ben-ihelputech

@stephenw10 That's good to hear. Is there a git repository where squidguard is being worked on? I would like to work on the project, but information seems fragmented.

stephenw10

Probably: https://github.com/freebsd/freebsd-ports/tree/main/www/squidguard

JonathanLee

https://redmine.pfsense.org/issues/13984#change-67231

They have movement and a pull request in. Patches have been created for Squid and Squidguard!!! Yeahhh

JonathanLee

https://redmine.pfsense.org/issues/13984

Yeahhh

hugoeyng

@jonathanlee How do I install the patches?

URL/Commit ID?

Path Strip Count?

Base Directory?

Ignore Whitespace?

Auto Apply?

stephenw10

Set the path strip count to 4, leave other settings default.

I uploaded the patch files directly but you could also copy/paste the diff text.

JonathanLee

@hugoeyng you can use the URL and fetch it, for this one I downloaded the text file, use the new one made a couple hours ago. After paste that text into the box in custom patch. And move the level 4 leave everything else. Save it has option to debug make sure it shows ok green for you can apply. Apply and reboot. If it shows an error debug and unapply it. Reboot.

Marcos created a new file today the other one had a small issue on it when I tested it last night.