23.01 Squid issue

ben-ihelputech

@stephenw10 That's good to hear. Is there a git repository where squidguard is being worked on? I would like to work on the project, but information seems fragmented.

stephenw10

Probably: https://github.com/freebsd/freebsd-ports/tree/main/www/squidguard

JonathanLee

https://redmine.pfsense.org/issues/13984#change-67231

They have movement and a pull request in. Patches have been created for Squid and Squidguard!!! Yeahhh

JonathanLee

https://redmine.pfsense.org/issues/13984

Yeahhh

hugoeyng

@jonathanlee How do I install the patches?

URL/Commit ID?

Path Strip Count?

Base Directory?

Ignore Whitespace?

Auto Apply?

stephenw10

Set the path strip count to 4, leave other settings default.

I uploaded the patch files directly but you could also copy/paste the diff text.

JonathanLee

@hugoeyng you can use the URL and fetch it, for this one I downloaded the text file, use the new one made a couple hours ago. After paste that text into the box in custom patch. And move the level 4 leave everything else. Save it has option to debug make sure it shows ok green for you can apply. Apply and reboot. If it shows an error debug and unapply it. Reboot.

Marcos created a new file today the other one had a small issue on it when I tested it last night.

JonathanLee

@hugoeyng I just started doing patches too the patch package is amazing.

JonathanLee

Make sure you use Marcos latest version as there was an issue found last night with the other patch. The latest text file is in the redmine

Screenshot 2023-05-03 at 1.18.24 PM.png

hugoeyng

@stephenw10 @JonathanLee Hello, Firends.

An error message was showed:

JonathanLee

@hugoeyng open that file with a text editior and paste it into that box "Patch Contents" Upload will not work because it has to be complied by the program it is source code right now.

hugoeyng

@jonathanlee @stephenw10 I copied the code fo the files into the box "Patch contents" and applied but now another (another line at least) error occurs:

JonathanLee

@hugoeyng did you apply both files? There is also a Squidguard text in that redmine Marcos wants both applied.

Screenshot 2023-05-03 at 2.20.28 PM.png

This text file Squid Proxy

Screenshot 2023-05-03 at 2.20.28 PM.png

This text file Squid Guard

hugoeyng

@jonathanlee I created one Custom Systema Patch to each file.

JonathanLee

@hugoeyng can you get a screen shot of the error codes in logs and post it to the redmine?

hugoeyng

@jonathanlee I am not sure I have permission to do it. The error message is:

PHP errors
PHP ERROR: Type: 1, File: /usr/local/pkg/squidguard.inc, Line: 1184, Message: Uncaught TypeError: Cannot access offset of type string on string in /usr/local/pkg/squidguard.inc:1184
Stack trace:
#0 /usr/local/pkg/squidguard.inc(1038): convert_pfxml_to_sgxml_time(Array)
#1 /usr/local/pkg/squidguard.inc(93): convert_pfxml_to_sgxml()
#2 /etc/inc/pkg-utils.inc(691): require_once('/usr/local/pkg/...')
#3 /etc/rc.start_packages(66): sync_package('squidGuard')
#4 {main}
thrown @ 2023-05-03 18:12:49

hugoeyng

@jonathanlee The log:

Crash report begins. Anonymous machine information:

amd64
14.0-CURRENT
FreeBSD 14.0-CURRENT #0 plus-RELENG_23_01-n256037-6e914874a5e: Fri Feb 10 20:30:29 UTC 2023 root@freebsd:/var/jenkins/workspace/pfSense-Plus-snapshots-23_01-main/obj/amd64/VDZvZksF/var/jenkins/workspace/pfSense-Plus-snapshots-23_01-main/sources/FreeBS

Crash report details:

PHP Errors:
[03-May-2023 18:12:49 America/Sao_Paulo] PHP Fatal error: Uncaught TypeError: Cannot access offset of type string on string in /usr/local/pkg/squidguard.inc:1184
Stack trace:
#0 /usr/local/pkg/squidguard.inc(1038): convert_pfxml_to_sgxml_time(Array)
#1 /usr/local/pkg/squidguard.inc(93): convert_pfxml_to_sgxml()
#2 /etc/inc/pkg-utils.inc(691): require_once('/usr/local/pkg/...')
#3 /etc/rc.start_packages(66): sync_package('squidGuard')
#4 {main}
thrown in /usr/local/pkg/squidguard.inc on line 1184
[03-May-2023 18:34:31 America/Sao_Paulo] PHP Fatal error: Uncaught TypeError: Cannot access offset of type string on string in /usr/local/pkg/squidguard.inc:1184
Stack trace:
#0 /usr/local/pkg/squidguard.inc(1038): convert_pfxml_to_sgxml_time(Array)
#1 /usr/local/pkg/squidguard.inc(93): convert_pfxml_to_sgxml()
#2 /etc/inc/pkg-utils.inc(691): require_once('/usr/local/pkg/...')
#3 /etc/rc.start_packages(66): sync_package('squidGuard')
#4 {main}
thrown in /usr/local/pkg/squidguard.inc on line 1184
[03-May-2023 18:34:41 America/Sao_Paulo] PHP Fatal error: Uncaught TypeError: Cannot access offset of type string on string in /usr/local/pkg/squidguard.inc:1184
Stack trace:
#0 /usr/local/pkg/squidguard.inc(1038): convert_pfxml_to_sgxml_time(Array)
#1 /usr/local/pkg/squidguard.inc(93): convert_pfxml_to_sgxml()
#2 /etc/inc/pkg-utils.inc(1068): require_once('/usr/local/pkg/...')
#3 /etc/rc.packages(80): delete_package_xml('squidGuard', 'deinstall')
#4 {main}
thrown in /usr/local/pkg/squidguard.inc on line 1184
[03-May-2023 18:34:42 America/Sao_Paulo] PHP Fatal error: Uncaught TypeError: Cannot access offset of type string on string in /usr/local/pkg/squidguard.inc:1193
Stack trace:
#0 /usr/local/pkg/squidguard.inc(1047): convert_pfxml_to_sgxml_time(Array)
#1 /usr/local/pkg/squidguard.inc(93): convert_pfxml_to_sgxml()
#2 /etc/inc/pkg-utils.inc(868): require_once('/usr/local/pkg/...')
#3 /etc/rc.packages(76): install_package_xml('squidGuard')
#4 {main}
thrown in /usr/local/pkg/squidguard.inc on line 1193

No FreeBSD crash data found.

ben-ihelputech

@hugoeyng Are you using high availability sync for squidguard?

hugoeyng

@ben-ihelputech Where could I see that? I have no access to SquidGuard setup since this bug appeared

JonathanLee

@hugoeyng Your going to have to revert the patch back. I will add your notes to redmine