Traffic graph not shown for local ips

[johnpoz]

@scorpoin said in Traffic graph not shown for local ips:

s there any patch to fix this issue.

yeah @stephenw10 posted a link to it.. Just download that diff, copy and past its stuff into the patches package (you have to install that)..

See here.. I just called it traffic..

The link to the dif steve posted

https://forum.netgate.com/assets/uploads/files/1697639190805-1092.diff

Sure seems to have fixed it on my 2.7 VM..

[scorpoin]

@johnpoz
@stephenw10

I have applied the given patch but yet not change , I'm using Pfsense CE 2.7 or do I need to reboot machine ? I have tried with patch file upload as well as paste the content into patch content box.

Regards

[stephenw10]

Did you apply the patch after creating it?

[scorpoin]

@stephenw10

Correct me if I'm wrong , below is for ipv6

(($filter == "local") && ((ip_in_subnet($infoarray[0], $intsubnet)) || (ip_in_subnet($infoarray[0], $intsubnet6)))) 

If it is can I change that variable from 6 to 4 using ipv4

(($filter == "local") && ((ip_in_subnet($infoarray[0], $intsubnet)) || (ip_in_subnet($infoarray[0], $intsubnet4)))) 

yes I did create patch and just copied that content and paste it into patch text area and save /apply .

When doing ssh to pfsense according to patch path /src/usr .... it does not exist but below path is there.

/usr/local/pfSense/include/www/bandwidth_by_ip.inc

that path having the actual file , I guess some how patch does not applied , changes are not reflect into above file .

[stephenw10]

If the patch has the wrong path or the path strip count it wrong etc you would not be able to apply and the 'apply' button will not show. If it showed and you were able to click it it should have applied.

The variable $intsubnet contains the interface IPv4 subnet. $instsubnet6 holds the interface IPv6 subnet. That line checks that the IP is in one of them before displayinbg it if 'local' is set.

Steve

[scorpoin]

@stephenw10

Patch applied but didnt work for me :/ .

[jrey]

@stephenw10

Observation from 23.09.b.20231023.1701

if the selection is "rate (standard)" the IP list will populate and then clear immediately with each refresh (so the list mostly appears empty)

if the selection is "iftop (experimental)" the IP list will populate and then just refresh with the update (so there is always IP addresses in the list)

Edit: and the selection for WAN does the same thing. "rate" standard shows the IP updates periodically and clears list. "iftop" the ip stays in the list and the bandwidths just refresh.

[stephenw10]

Yes, that's true. The output from rate is filtered every time it refreshes and the list is rewritten each time.

One thing I have seen is that if you change from rate to iftop (or the other way) you may need to switch interfaces in order to see that.

[jrey]

@stephenw10

when on rate it always clears immediately after a refresh, and when on iftop is does not. Doesn't matter what else you flip back and forth. Able to reproduce 100%

rate = refresh, clear list (you only see the IPs momentarily)
iftop = refresh, list not cleared. (likely more correctly stated as clear, refresh)

but the end result is you can see the IP list on iftop and not on rate
at least with 23.09.b.20231023.1701 that is my observation.

[stephenw10]

What exactly do you see then? I see what I'm expecting there:

Most of those are other pfSense instances pinging the LAN.

[jrey]

@stephenw10

with rate set - the list populates momentarily (on every refresh), clears then is blank
so mostly displays like this (can't really tell what was on the list because it goes blank as soon as the list is done, the IPs are listed only as long as it takes to draw the list.)

on the there hand, with iftop (it just refreshes, there is always something shown (it might actually be a clear->refresh, the refresh is too fast to tell) but the result is like this and certainly the list is changing based on the refresh.

[jrey]

@stephenw10

Can eliminate the browser - just tried the same test from another box with different OS / browser and it does exactly the same thing there.

[tedquade]

@jrey I have the same issue as you.

Ted

[stephenw10]

If you start something continuous does it show up on every refresh?

[tedquade]

@stephenw10 Data to the right of the graph shows briefly then disappears.

Ted

[jrey]

@stephenw10

it is consistent in operation, the graph is updating as the traffic changes the list is always displaying when refreshed as described. There is never a case where there is no traffic, if that's what you mean be "start something continuous" there is always traffic, although the IPs might change and sort as expected.

rate = refresh -> ends in blank list (the list isn't visible long enough to read)

iftop = refresh -> ends with list still displayed.

[stephenw10]

Hmm, and the process you start is passing enough traffic that client should be top of the list?

[jrey]

@stephenw10
You tell me

is this enough traffic to make IP address show on the list ? and again they do show momentarily until the refresh is done then the list clears

this is rate (I can't really tell you what the traffic is per IP because the list doesn't stay visible long enough. The list is mostly in a blank state except during an actual refresh, when the IPs appear briefly and immediately disappear) - point is, there is no value in "flashing" IPs in this list and not leaving them visible long enough from someone to read. if there are 5+ IPs on the list, (and this is common here), by the time you look and scan the list, to find the one you are looking for, the list is gone. So blank most of the time even thought the traffic is still flowing. Based on where I think you are going with "start something continuous" ) the list is empty. If the expectation is that, that IP should remain listed based on traffic level or duration, IMHO it does not. (aka packet capture on a specific IP confirms there is consistent traffic, and yet the list shows empty.)
additionally I've got an iPhone downloading the 17.1 iOS update as I type (the IP that phone is on is doing about 255M/sec and the list refreshed several times and clears - is blank) the download lasted about maybe about 10 seconds in total. The IP only showed on the list right at the start of the download, the list was empty for perhaps 8-9 of those seconds) ie "mostly empty" the IP did not remain listed for the duration of the download, even though other devices clearly appeared and left the list during the same timeframe.

this is most likely why the list is "flashing" and empty most of the time.
both not following long traffic for duration and;
short bursts traffic (< refresh interval) just come and go.

whereas this is iftop - there are always IPs listed (list is never blank) and they bounce around based on the sort order and what they are doing with each refresh. (the iPhone remained top of the list during the download)

[stephenw10]

And that's with the patch applied? For the one refresh it did appear did it show the correct bandwidth, 250Mbps?

[jrey]

@stephenw10

yes it did show the 250Mbps initially, but it also shows traffic with much lower rate initially as well. I don't think it has as much to do with rate as it does with duration of traffic

I believe the original discussion was regarding 2.7 and a mention of 23.05.1

so no patch applied prior, I'm on the Beta 23.09.b.20231023.1701
and wanted to report/confirm the observation there as well,
while waiting for the pending RC.

applied the patch, navigated back to the page and

not really seeing a difference for the amount of traffic on the graph. During that segment of graph shown from page load, 2 IPs have briefly appeared on the list, but certainly not remaining there while there is clearly traffic

logged out back in - no change
close browser - reload - login - no change

cached server side perhaps ? only thing I can think of is restart the web GUI or reboot the system. (or wait for the RC which will do both of those and test it again.)

But then I noticed that although it says applied (and I have the option to revert) it wasn't a 100% clean apply

Debug shows

Thanks