How to get Feedback on PRs

MatthewA1

I've been waiting 6 months for feedback on my PR #4658 for Redmine ticket #8794. Is there some process I'm not seeing for requesting feedback? At this point, the PR has conflicts that I'll need to correct, but I don't want to spend the time to do so if it's just never going to be reviewed. Is there someone to contact about this? Posting comments on both the PR and Redmine ticket hasn't resulted in any responses since the PR was initially opened.
If I just need to wait, that's fine, but at least some timeline or basic response would be appreciated.

marcosm

I'm happy to see people contributing to the project! The only thing left to do in that situation is wait; unfortunately it can take a while to get to these simply because a lot of the time there are other priorities that we need to focus our effort on.

MatthewA1

Thanks @marcosm , you actually reviewed that PR a couple days ago. I had just wanted to make sure it hadn't gotten lost or it was waiting on something else from me.
One follow-up question: As discussed in the comments of the PR, there's more work to be done in a future PR (such as supporting multiple keys). As the Redmine ticket is in the Feedback status and shows the work is 100% done plus it is simply titled "Support NTP Authentication," should I start that work under the same Redmine Ticket, or since it is improving what is now a supported feature, should I open a new Redmine Ticket first?

marcosm

@MatthewA1 It'd be best to put it in a new feature request that references the old one.

JonathanLee

What about Squid it is updated I see but certification issues with OpenSSL exist still. I am taking C next semester, I can't wait to start helping out more. They have set me up for full computer science major now, it is no longer pre computer science WHooHoo

marcosm

@JonathanLee There's no maintainer for the squid packages on pfSense - fixes/features are unlikely to be released for it. Until it's removed, any updates for it will likely be general maintenance patches.

JonathanLee

@marcosm Someone updated Squid from 5.8 to 6.X recently.

MatthewA1

@marcosm Opened as requested #15579
If the Assignee field is used for anyone (not just Netgate employees), feel free to assign to me.

michmoor

@JonathanLee He is stating there is no pfsense maintainer.
There’s the FreeBSD package maintainer and a Pfsense package maintainer.
If either one of these maintainers no longer have interest in a project it withers on the vine.
So yes Squid has been updated but unless there’s a hot fix to a security issue the package is done on pfsense

JonathanLee

@michmoor the 6.6 update is the security fix. It’s the latest version. Squid did fix a lot of things in the latest version of Squid and it is downloading in packages. I have this feeling big tech wants it dead because it works so well. It’s sad no reason other than the fact that it flys in the face of big tech abuse. It’s like a giant spot light.

Squid has so much to offer, it just needs some fresh code thrown at it again. I really want a container analysis system, that way it wouldn’t matter if a system has an invasive container the proxy it would see the fingerprints and alert cyber security services about the situation. That’s what cyber security needs. A workable mitigation for container and virtual machine issues, FreeBSD jails, invasive actors. A spotlight for invasive actors that are performing abusive data marshaling. There is got to be a solution, and proxy software that caches and accelerates is the answer to it, again it needs code and time.

JonathanLee

@michmoor you know big tech says, They say : "Squid is dangerous ..." You want to maintain it with me? We just need to fix the gui is all