Email Reports WebGUI crashes February 2025

[mtarbox]

Re: Email Reports WebGUI crashes when trying to edit the reports

This issue is still happening. I uninstalled, re-installed, and followed the link to the github diff file, and placed the changes in there. No dice.

4200/24.11-RELEASE /System_Patches 2.2.20_1/all patches applied
Here is line 44:
$a_cmds = $a_mailreports['cmd']['row'];

Crash report begins. Anonymous machine information:

amd64
15.0-CURRENT
FreeBSD 15.0-CURRENT #0 plus-RELENG_24_11-n256407-1bbb3194162: Fri Nov 22 05:08:46 UTC 2024 root@freebsd:/var/jenkins/workspace/pfSense-Plus-snapshots-24_11-main/obj/amd64/AKWlAIiM/var/jenkins/workspace/pfSense-Plus-snapshots-24_11-main/sources/FreeBS

Crash report details:

PHP Errors:
[18-Feb-2025 13:19:21 America/New_York] PHP Fatal error: Uncaught TypeError: Cannot access offset of type string on string in /usr/local/www/status_mail_report_edit.php:44
Stack trace:
#0 {main}
thrown in /usr/local/www/status_mail_report_edit.php on line 44

No FreeBSD crash data found.

[mtarbox]

Eh, I fixed it. Pulled that specific patch into the system and applied it.

Took me some time to figure it out. I didn't realize that you could pull a .diff patch file in and apply it.

[Gertjan]

@mtarbox said in Email Reports WebGUI crashes February 2025:

Took me some time to figure it out. I didn't realize that you could pull a .diff patch file in and apply it.

You pulled in what patch manually ?
What package ?
I think I know which one, but some one else will try to patch software that doesn't exist on his pfSense.

[mtarbox]

@Gertjan this one. https://github.com/pfsense/FreeBSD-ports/commit/c49098e2900a9211de44dc0b9937235ce9d638a2.diff

I pulled and applied it and woke up to an email report this morning.
This patch did not show up in patches at all. I rebooted post patch and was able to create a mail report and make selections.

[Gertjan]

@mtarbox said in Email Reports WebGUI crashes February 2025:

https://github.com/pfsense/FreeBSD-ports/commit/c49098e2900a9211de44dc0b9937235ce9d638a2.diff

Ah, ok, the pfSense-pkg-mailreport package.

Package make less - or, AFAIK, not use of the patches system.
If a patch exists fro them, then package is rebuild and you are proposed to update it.