New PPPoE backend, some feedback

benbng

@louis2 can you see if you have any luck bringing up the IPv6 gateway with the following?

Diagnostics > Command Prompt (Shell Command): netstat -6rWn | grep ::/0 | awk '{print $2}' > /tmp/pppoe0_routerv6
Diagnostics > Command Prompt (PHP Command): setup_gateways_monitor();
Status > Filter Reload (Reload Filter)

stephenw10

Those of you seeing the pending gateway are you all seeing it correctly if you switch back to mpd5?

I think we have a good handle on the problem here if so. Working on the correct fix.

benbng

@stephenw10 yep no issues when using mpd5 (with no changes to config) on CE 2.8.0

Glad to hear things are being looked into, let me know if I can test anything/provide any more logs.

marcosm

@benbng Here's a patch you can test on 2.8.0 to work around the lack of RA issue:
https://nc.netgate.com/nextcloud/s/bt2fWWjdzT4KFHy

benbng

@marcosm I've applied that and it's working great, thank you!

stephenw10

Nice. Thanks for testing!

louis2

@benbng

No, and the reaction on
setup_gateways_monitor(); => Badly placed ()'s.

stephenw10

Try the above patch. Your situation is exactly what it should address.

louis2

@stephenw10

I did test this patch (https://nc.netgate.com/nextcloud/s/bt2fWWjdzT4KFHy), at least I hope I did.

I never did add a patch to the test set before:

did add the URL
add
did not know how to start it
so I did say start at boot
and did a reboot

If this was the correct procedure .... the patch did not work !

stephenw10

The URL field is only for the direct commit ID. For this I would just copy/paste the patch text into the new patch directly.

Once you've created it an 'Apply' button will appear if it can be applied correctly. Click the button to apply it.

https://docs.netgate.com/pfsense/en/latest/development/system-patches.html#adding-a-custom-patch

louis2

@stephenw10

Perhaps I will try that tomorrow, however why not adding the patch as ^test patch with small decription^ to the normal patch set / function !!??

stephenw10

You mean as part of the recommended patch list within the package?

That's only used for known good patches between releases, not for tests like this.

rlinnemann

To clarify on what's happening with the pending gateway, in your instances IPV6CP negotiation establishes the IPv6 endpoints on the PPP session, and the link local peer address is intended to be the gateway for your DHCPv6 assigned address, with no RAs to nominate a gateway. The interface gateway is correctly set to the address of the peer endpoint by the driver, but the existing LL address on the interface is not updated with the remote destination address, and that destination address is expected to be present in order to identify the PPP gateway when the gateway monitoring setup is triggered. The patch intuits the PPP gateway from the routing table instead of the interface address in the IPv6 case. I'm working on a correction to the driver that should eliminate the need for this special case handling.