new if_pppoe Backend - getting HA/CARP to work like in MPD

perrin

@w0w thanks for sharing those scripts.

I did invest some time to create a pfSense package for handling PPPoe High Availability using CARP - more or less the same way it worked before.

My package has a GUI for selecting the PPPoE interface(s) and the corresponding CARP interface. Whenever a CARP event occurs for the selected interfaces, the corresponding PPPoE interface is taken down on BACKUP and brought up on MASTER, just as your scripts do.

As my logic is responding to the CARP event directly, there is no need for a timely approach using a main loop and sleep.

i've uploaded the files and the most recent pkg to GitHub:
https://github.com/perrin-1/pfSense-pppoe-ha

I'd be happy if someone would test that on their machines.

zjamali

@perrin i have downloaded and try on my env and i encounter that the pppoe interface still up on backup node. I have leave 2 issue into github project.

perrin

@zjamali Did you try a manual reconcile?
Can you post the log output and your config?

zjamali

This post is deleted!

zjamali

@perrin as below the only log i have. i clicked the reconcile now button.

perrin

@zjamali i suspect that i might have an old pkg in the github repo. can you please check the file pppoe_ha_even.php (in /usr/local/sbin) and check if the function reconcile_all (line 176ff) looks like this:

function reconcile_all() {
    $rows = ppha_get_rows();
    if (!$rows){ ha_log("Reconcile: no mappings configured"); return; }
    ha_log("Running reconcile for all configured mappings");
    $vips = config_get_path('virtualip/vip', []);
    foreach ($rows as $row) {
        if (empty($row['enabled']) || empty($row['vipref']) || empty($row['iface'])) continue;
        $vip = $vips[$row['vipref']] ?? null;
        if (!$vip || ($vip['mode'] ?? '')!=='carp') continue;
        $vhid = (int)($vip['vhid'] ?? -1); if ($vhid<0) continue;

        $state = get_carp_state_for_vhid($vhid) ?? 'INIT';
        $friendly = (string)$row['iface'];
        $real = real_ifname_for_friendly($friendly);
        if (!$real){ ha_log("Reconcile: {$friendly} real if not found; skip"); continue; }

        if ($state==='MASTER'){ ha_log("Reconcile: VHID {$vhid} MASTER - UP {$friendly} ({$real})"); iface_up($real); }
        elseif ($state==='BACKUP'){ ha_log("Reconcile: VHID {$vhid} BACKUP - DOWN {$friendly} ({$real})"); iface_down($real); }
        elseif ($state==='INIT'){ ha_log("Reconcile: VHID {$vhid} INIT - DOWN {$friendly} ({$real})"); iface_down($real); }
        else { ha_log("Reconcile: VHID {$vhid} {$state} - no action"); }
    }
}

the script should log the set interface states (UP, DOWN) in the log - thats why I am wondering...

zjamali

@perrin i have compared with yours above, its match

zjamali

seems like $rows not getting any value and not go into the foreach loop

too soon, its already have the return for no mapping

perrin

@zjamali said in new if_pppoe Backend - getting HA/CARP to work like in MPD:

seems like $rows not getting any value and not go into the foreach loop

yes, this is what i am suspecting as well. can you check your config.xml and look for the <pppoeha> section. it should look something like this:

 <pppoeha>
                        <config>
                                <row>
                                        <enabled>ON</enabled>
                                        <iface>wan</iface>
                                        <vipref>17</vipref>
                                </row>
                        </config>
                </pppoeha>

zjamali

@perrin said in new if_pppoe Backend - getting HA/CARP to work like in MPD:

yes, this is what i am suspecting as well. can you check your config.xml and look for the <pppoeha> section. it should look something like this:

 <pppoeha>
                        <config>
                                <row>
                                        <enabled>ON</enabled>
                                        <iface>wan</iface>
                                        <vipref>17</vipref>
                                </row>
                        </config>
                </pppoeha>

Where i can find this config.xml?

perrin

@zjamali ah sorry. you can either download a backup (under backup/restore) or directly on the box with ssh do something like:

grep -A10 pppoeha /conf/config.xml

zjamali

@perrin

zjamali

said in new if_pppoe Backend - getting HA/CARP to work like in MPD:

@perrin

is it because vipref == 0? my first vhid comes with id = 0

Yup, that cause it. i changed to VHID LAN, id != 0, its appear in log

perrin

@zjamali great, thanks for figuring that out. I need to check why it's not working with vipref=0.

currently i have no idea why this happens. vipref 0 is just the first item in the vips. config_get_path is a standard pfsense function.

Maybe it is something with the way you configured that vip? is your first VIP configured differently ffrom the one you were using later?

zjamali

@perrin Its the first vip configured in both pfsense node. So it gets id = 0.

perrin

@zjamali this is the way the dropdown in the PPPoE-HA GUI looks in my production firewall:

in my case VHID 18 is the one that is configured for failover.

Can you check if yours maybe starts with VHID 0?

zjamali

@perrin Mine also start with VHID 1 but if you go to Firewall -> Virtual IP, there is listing of all VIP, you hover on the edit button for first VHID, the url link will say its id=0

id = 0 is for internal system id for record creation whilst VHID 1 is for user POV, if i am not mistaken.

perrin

@zjamali yep, same here. I'll debug why it is not working on the first VIP later.
Can you temporarely work with a different VIP?

zjamali

@perrin said in new if_pppoe Backend - getting HA/CARP to work like in MPD:

@zjamali yep, same here. I'll debug why it is not working on the first VIP later.
Can you temporarely work with a different VIP?

Should be OK. no issue