$50 for tftp-server-name DHCP option

billm · May 10, 2006, 12:07 AM

@robbyt:

how about a more generic dhcp option#->value field?

No thanks. It won't be used very often and we are not going to start cluttering the interface with this stuff for 1% usage.

As it is, this will likely only go in as a hidden config.xml option anyway. I'll consider making it an array value that allows arbitrary dhcp options. Maybe some day we'll figure out a compromise between the advanced features and the normal features that won't require editing config.xml - for now, that's the only real option. Needless to say, this isn't going in 1.0 regardless of how it's implemented.

–Bill

robbyt · May 10, 2006, 6:13 PM

@sullrich:

@robbyt:

how about a more generic dhcp option#->value field?

No thanks. It won't be used very often and we are not going to start cluttering the interface with this stuff for 1% usage.

i can understand, and in someways agree with you. But you should perhaps re-examine the this. For example, at my office- i run an asterisk server with about 60-70 polycom phones. The latest polycom firmware lets you specify the sip server as a dhcp option. (i think it's like option# 165 or something like that) You can push out all sorts of other wonderful and usefull stuff from dhcp: static routes, wins, ntp, and so on…

I can understand not having this ability due to complexity of implimentation, but this seems like a fairly trivial thing (other then interface bloat)

(attached is a screenshot from ipcop's dhcp server options)

cayblood · May 10, 2006, 8:50 PM

This bounty has been claimed by Daniel S. Haischt, who sent us some patched files, from which we were able to create a modification with a more minimal impact.

To add this feature, mount the filesystem in a writeable mode (if not already) with:


mount -w /

and then add the following code to /etc/inc/services.inc, starting at line 238:


if ($dhcpifconf['tftp-server-name'])
    $dhcpdconf .= " option tftp-server-name \"{#dhcpifconf['tftp-server-name']}\";\n";

Then just change your config.xml and add


<tftp-server-name>X.X.X.X</tftp-server-name>

under pfsense/dhcpd/lan. That should do it.

I agree with robbyt that adding the ability to set DHCP options is a common thing that is not supporting a 5% minority but actually would be used by a lot of people, and the changes to the interface would be minimal.

Best wishes,
Carl

sullrich · May 10, 2006, 9:04 PM

This has been commited to -HEAD.

Thanks!

DanielSHaischt · May 10, 2006, 9:17 PM

If you want I can post the GUI related mods that I did to services_dhcp.php as well.

Regards
Daniel S. Haischt

billm · May 10, 2006, 9:20 PM

@cayblood:

This bounty has been claimed by Daniel S. Haischt, who sent us some patched files, from which we were able to create a modification with a more minimal impact.

To add this feature, mount the filesystem in a writeable mode (if not already) with:
mount -w /
and then add the following code to /etc/inc/services.inc, starting at line 238:
if ($dhcpifconf['tftp-server-name'])
    $dhcpdconf .= " option tftp-server-name \"{#dhcpifconf['tftp-server-name']}\";\n";
Then just change your config.xml and add
<tftp-server-name>X.X.X.X</tftp-server-name>
under pfsense/dhcpd/lan. That should do it.

I agree with robbyt that adding the ability to set DHCP options is a common thing that is not supporting a 5% minority but actually would be used by a lot of people, and the changes to the interface would be minimal.

Best wishes,
Carl

fwiw, the better patch would have been something along the lines of:


foreach($dhcpifconf['options'] as $optname => $dhcpopt) {
	$dhcpdconf .= " option {$optname} \"{$dhcpopt}\";\n";
}

and then added


 <options><tftp-server-name>foobar</tftp-server-name></options>

to config.xml in the same place. If someone creates a diff (that has been tested) with the above code concept, I'll commit it to HEAD (and only HEAD).

–Bill

billm · May 10, 2006, 9:20 PM

or nm…the previous code was commited. thus ends my interest in this. :)

--Bill

keefe007 · Jun 12, 2006, 10:43 PM

Is this going to be in the next GUI too?

hoba · Jun 12, 2006, 10:55 PM

@sullrich:

@robbyt:

how about a more generic dhcp option#->value field?

No thanks. It won't be used very often and we are not going to start cluttering the interface with this stuff for 1% usage.

With this said it most probably will remain a hidden xml option.

keefe007 · Jun 12, 2006, 11:27 PM

I think many many people would use a feature such as this. IP phones are becoming more and more popular and the easiest way to configure a network of them is with the tftp DHCP option. I know this option would be used more than some of the other more specialized options that are already in pfsense. I truely hope more people voice their need for this feature and you reconsider adding it to the gui.

sullrich · Jun 12, 2006, 11:28 PM

@keefe007:

I think many many people would use a feature such as this. IP phones are becoming more and more popular and the easiest way to configure a network of them is with the tftp DHCP option. I know this option would be used more than some of the other more specialized options that are already in pfsense. I truely hope more people voice their need for this feature and you reconsider adding it to the gui.

I'll meet you half way. You do the GUI work and I'll commit.

DanielSHaischt · Jun 13, 2006, 4:57 PM

The attached diff (against CVS HEAD) contains some GUI related mods as requested by keefe007.

services_dhcp.php.txt

sullrich · Jun 13, 2006, 4:58 PM

0KB

DanielSHaischt · Jun 13, 2006, 4:59 PM

@sullrich:

0KB

Yep, unfortunatly :(

services_dhcp.php.txt

kerryg · Jul 19, 2006, 3:40 AM

As an installer of Asterisk PBX systems, the ability to push different DHCP options such as boot server, NTP server, and time offset, are absolute requirements in choosing a firewall/DHCP server. Without means of providing this function to DHCP clients such as IP phones, the usefullness of PFSense is greatly diminished. Its ok for now to be able to add them to a config file but a long term solution to provide this functionality is crucial to the success of PFSense within the IP PBX market.

-Kerry

robbyt · Jul 19, 2006, 4:35 AM

@kerryg:

As an installer of Asterisk PBX systems, the ability to push different DHCP options such as boot server, NTP server, and time offset, are absolute requirements in choosing a firewall/DHCP server. Without means of providing this function to DHCP clients such as IP phones, the usefullness of PFSense is greatly diminished. Its ok for now to be able to add them to a config file but a long term solution to provide this functionality is crucial to the success of PFSense within the IP PBX market.

-Kerry

agree 100%!
for asterisk support alone, a more flexible DHCP server is a killer feature.

DHCP server interface works really well in IPCOP, better then any other i've seen.

eric · Jul 19, 2006, 9:11 PM

I agree with the last two posts :)

databeestje · Aug 11, 2006, 1:31 PM

Weird thought, make it available as a advanced option and hide it behind a advanced button.

That appears to work really well for current code in RELENG_1

dave99 · Mar 14, 2007, 4:45 PM

Was there ever a final resolution on this? If so, what is the proper format for the config.xml & services.inc file. I tried all the variations I could find, none seemed to work with my cisco phones.

databeestje · Mar 15, 2007, 8:34 PM

I would like to claim the bounty.

It's added to both RELENG_1 and HEAD.

It should be on the services_dhcp.php page.

It will be hidden behind a "advanced" button.
seth.mos@xs4all.nl for paypal