Netgate Discussion Forum
    • Categories
    • Recent
    • Tags
    • Popular
    • Users
    • Search
    • Register
    • Login

    $50 for tftp-server-name DHCP option

    Scheduled Pinned Locked Moved Completed Bounties
    31 Posts 14 Posters 48.2k Views
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • D
      DanielSHaischt
      last edited by

      If you want I can post the GUI related mods that I did to services_dhcp.php as well.

      Regards
      Daniel S. Haischt

      Mit freundlichen Gruessen / With kind regards
      DAn.I.El S. Haischt

      1 Reply Last reply Reply Quote 0
      • B
        billm
        last edited by

        @cayblood:

        This bounty has been claimed by Daniel S. Haischt, who sent us some patched files, from which we were able to create a modification with a more minimal impact.

        To add this feature, mount the filesystem in a writeable mode (if not already) with:

        
        mount -w /
        
        

        and then add the following code to /etc/inc/services.inc, starting at line 238:

        
        if ($dhcpifconf['tftp-server-name'])
            $dhcpdconf .= " option tftp-server-name \"{#dhcpifconf['tftp-server-name']}\";\n";
        
        

        Then just change your config.xml and add

        
        <tftp-server-name>X.X.X.X</tftp-server-name>
        
        

        under pfsense/dhcpd/lan. That should do it.

        I agree with robbyt that adding the ability to set DHCP options is a common thing that is not supporting a 5% minority but actually would be used by a lot of people, and the changes to the interface would be minimal.

        Best wishes,
        Carl

        fwiw, the better patch would have been something along the lines of:

        
        foreach($dhcpifconf['options'] as $optname => $dhcpopt) {
        	$dhcpdconf .= " option {$optname} \"{$dhcpopt}\";\n";
        }
        
        

        and then added

        
         <options><tftp-server-name>foobar</tftp-server-name></options> 
        
        

        to config.xml in the same place.  If someone creates a diff (that has been tested) with the above code concept, I'll commit it to HEAD (and only HEAD).

        –Bill

        pfSense core developer
        blog - http://www.ucsecurity.com/
        twitter - billmarquette

        1 Reply Last reply Reply Quote 0
        • B
          billm
          last edited by

          or nm…the previous code was commited.  thus ends my interest in this. :)

          --Bill

          pfSense core developer
          blog - http://www.ucsecurity.com/
          twitter - billmarquette

          1 Reply Last reply Reply Quote 0
          • K
            keefe007
            last edited by

            Is this going to be in the next GUI too?

            1 Reply Last reply Reply Quote 0
            • H
              hoba
              last edited by

              @sullrich:

              @robbyt:

              how about a more generic dhcp option#->value field?

              No thanks.  It won't be used very often and we are not going to start cluttering the interface with this stuff for 1% usage.

              With this said it most probably will remain a hidden xml option.

              1 Reply Last reply Reply Quote 0
              • K
                keefe007
                last edited by

                I think many many people would use a feature such as this.  IP phones are becoming more and more popular and the easiest way to configure a network of them is with the tftp DHCP option.  I know this option would be used more than some of the other more specialized options that are already in pfsense.  I truely hope more people voice their need for this feature and you reconsider adding it to the gui.

                1 Reply Last reply Reply Quote 0
                • S
                  sullrich
                  last edited by

                  @keefe007:

                  I think many many people would use a feature such as this.  IP phones are becoming more and more popular and the easiest way to configure a network of them is with the tftp DHCP option.  I know this option would be used more than some of the other more specialized options that are already in pfsense.  I truely hope more people voice their need for this feature and you reconsider adding it to the gui.

                  I'll meet you half way.  You do the GUI work and I'll commit.

                  1 Reply Last reply Reply Quote 0
                  • D
                    DanielSHaischt
                    last edited by

                    The attached diff (against CVS HEAD) contains some GUI related mods as requested by keefe007.

                    services_dhcp.php.txt

                    Mit freundlichen Gruessen / With kind regards
                    DAn.I.El S. Haischt

                    1 Reply Last reply Reply Quote 0
                    • S
                      sullrich
                      last edited by

                      0KB

                      1 Reply Last reply Reply Quote 0
                      • D
                        DanielSHaischt
                        last edited by

                        @sullrich:

                        0KB

                        Yep, unfortunatly :(

                        services_dhcp.php.txt

                        Mit freundlichen Gruessen / With kind regards
                        DAn.I.El S. Haischt

                        1 Reply Last reply Reply Quote 0
                        • K
                          kerryg
                          last edited by

                          As an installer of Asterisk PBX systems, the ability to push different DHCP options such as boot server, NTP server, and time offset, are absolute requirements in choosing a firewall/DHCP server. Without means of providing this function to DHCP clients such as IP phones, the usefullness of PFSense is greatly diminished. Its ok for now to be able to add them to a config file but a long term solution to provide this functionality is crucial to the success of PFSense within the IP PBX market.

                          -Kerry

                          1 Reply Last reply Reply Quote 0
                          • R
                            robbyt
                            last edited by

                            @kerryg:

                            As an installer of Asterisk PBX systems, the ability to push different DHCP options such as boot server, NTP server, and time offset, are absolute requirements in choosing a firewall/DHCP server. Without means of providing this function to DHCP clients such as IP phones, the usefullness of PFSense is greatly diminished. Its ok for now to be able to add them to a config file but a long term solution to provide this functionality is crucial to the success of PFSense within the IP PBX market.

                            -Kerry

                            agree 100%!
                            for asterisk support alone, a more flexible DHCP server is a killer feature.

                            DHCP server interface works really well in IPCOP, better then any other i've seen.

                            1 Reply Last reply Reply Quote 0
                            • E
                              eric
                              last edited by

                              I agree with the last two posts  :)

                              1 Reply Last reply Reply Quote 0
                              • D
                                databeestje
                                last edited by

                                Weird thought, make it available as a advanced option and hide it behind a advanced button.

                                That appears to work really well for current code in RELENG_1

                                1 Reply Last reply Reply Quote 0
                                • D
                                  dave99
                                  last edited by

                                  Was there ever a final resolution on this? If so, what is the proper format for the config.xml & services.inc file. I tried all the variations I could find, none seemed to work with my cisco phones.

                                  1 Reply Last reply Reply Quote 0
                                  • D
                                    databeestje
                                    last edited by

                                    I would like to claim the bounty.

                                    It's added to both RELENG_1 and HEAD.

                                    It should be on the services_dhcp.php page.

                                    It will be hidden behind a "advanced" button.
                                    seth.mos@xs4all.nl for paypal

                                    1 Reply Last reply Reply Quote 0
                                    • B
                                      Berg
                                      last edited by

                                      Hello,

                                      I just completed a search for "option 66" to see if PFSense supported it and came upon this post.

                                      I too would use this for an Asterisk system.

                                      What is the status of this initiative ? Is anyone else looking for this ? Is anyone using this now ?

                                      TIA.

                                      1 Reply Last reply Reply Quote 0
                                      • B
                                        ben.suffolk
                                        last edited by

                                        @sullrich:

                                        This has been commited to -HEAD.

                                        I'm still a little unsure of your release processes, when will a commit to HEAD (from May 2006) make it into a snapshot, or an actual release?

                                        I had a look in the code from 1.2-BETA-1-TESTING-SNAPSHOT-06-04-2007 but its not in there.

                                        Regards

                                        Ben

                                        1 Reply Last reply Reply Quote 0
                                        • dotdashD
                                          dotdash
                                          last edited by

                                          AFAIK, there is no set schedule for HEAD features getting into release.
                                          However, it should have hit RELENG_1. Perhaps no one ponied up the bounty…
                                          @databeestje:

                                          I would like to claim the bounty.

                                          It's added to both RELENG_1 and HEAD.

                                          It should be on the services_dhcp.php page.

                                          It will be hidden behind a "advanced" button.
                                          seth.mos@xs4all.nl for paypal

                                          1 Reply Last reply Reply Quote 0
                                          • B
                                            ben.suffolk
                                            last edited by

                                            @dotdash:

                                            AFAIK, there is no set schedule for HEAD features getting into release.
                                            However, it should have hit RELENG_1. Perhaps no one ponied up the bounty…

                                            That bit by databeestje confused me a bit because the bounty had already been claimed previously :

                                            @cayblood:

                                            This bounty has been claimed by Daniel S. Haischt, who sent us some patched files, from which we were able to create a modification with a more minimal impact.

                                            Regards

                                            Ben

                                            1 Reply Last reply Reply Quote 0
                                            • First post
                                              Last post
                                            Copyright 2025 Rubicon Communications LLC (Netgate). All rights reserved.