HTML center tag
-
Hi,
pfSense uses the
<center>HTML tag. However center was deprecated in HTML 4.01 and it is not valid XHTML.
It is used in auth.inc, not sure if there are more, I'll check later.
For auth.inc I would remove the<center>tages and add a style to the table to center it.
If this is the wrong place to suggest the above changes, please let me know.
Christian</center>
</center>
-
Hi,
pfSense uses the
<center>HTML tag. However center was deprecated in HTML 4.01 and it is not valid XHTML.
It is used in auth.inc, not sure if there are more, I'll check later.
For auth.inc I would remove the<center>tages and add a style to the table to center it.
If this is the wrong place to suggest the above changes, please let me know.
Christian
</center></center>
Care to supply a patch?
–Bill
-
We are working to bring the interface into standards and we well know of a lot of problems, including this.
Reporting them without a patch will fall nowhere. Either supply a patch or enjoy the free ride.
-
Hi,
I'll try to supply a patch tomorrow, when I have access to a proper computer again.
Where are patches posted? Here in the Forum?
Christian
-
Add the diff file as attachment to your post here or send it as attachment to support@pfsense.com (make sure you are subscribed there already). Also provide aq patch that applies against the HEAD tree, not RELENG.
-
Add the diff file as attachment to your post here or send it as attachment to support@pfsense.com (make sure you are subscribed there already). Also provide aq patch that applies against the HEAD tree, not RELENG.
As this only applies to HEAD, I'd certainly hope it's not against RELENG_1 :)
–Bill
-
OK, I have done it, attachet is my first patch.
While removing the center tag, I changed a couple of formating things that weren't consistent and other issues.
It is not necessary to have autocomplete="off" in every input element, it is enough to put it in the form tag.
I also replaced the login_focus and the NiftyCheck scripts with one page_load script.At the end of the HTML page ( ) there is an php echo instead of just wrinting it in the plain HTML. And just after the echo there is an } but I can't seem to find the opening { for it - I'm not that good in php.
Can the echo be removed and should the } go too?As I said, it's my first patch, so if it isn't ok, I'll try again. If you want I'll also remove the echo metioned above.
Christian
-
Thanks for this. But can you remake the patch with diff -rub ?
-
-
Commited, thanks!