Pkg_edit bug?

dvserg

Default url for pkg_edit contains
/pkg_edit.php?xml=package_name.xml&id=0

Example from package.xml


 <tab><text>Package text</text>
    <url>/pkg_edit.php?xml=package_name.xml&id=0</url></tab>

But if '&id=0' is absent ('<url>/pkg_edit.php?xml=package_name.xml</url>'),
then in config.xml for this package builds multiple 'config' sections

 <packagename><config>...</config> 
 <config>...</config></packagename>

Really must be one section

May be need correct this part?
pkg_edit.php line 69


$id = $_GET['id'];
if (isset($_POST['id']))
	$id = $_POST['id'];

to this (or near) - define $id=0 as default, if them not in url


$id = $_GET['id'];
if (isset($_POST['id']))
	$id = $_POST['id'];
else
             $id=0; // or $id='0'; ??

fernandotcl

That's not a bug, it's a feature. ;-)

No really, it's on purpose. When you click in a "+" icon in a pkg.php page, you'll be redirected to pkg_edit.php without id=X, which means exactly "add a new config item". It's not pretty, but then new XML stuff should use cg2 instead anyways.

dvserg

@fernandotcl:

That's not a bug, it's a feature. ;-)

No really, it's on purpose. When you click in a "+" icon in a pkg.php page, you'll be redirected to pkg_edit.php without id=X, which means exactly "add a new config item". It's not pretty, but then new XML stuff should use cg2 instead anyways.

About pkg.php i know ::)
What this - cg2? This mean php module for package in next version pfSense? I right understand?

sullrich

http://wiki.pfsense.com/wikka.php?wakka=CoreGUI2Introduction

dvserg

Ohm.. :D
Thx.