Package installation possible BUG

dvserg

File /etc/inc/pkg-utils.inc
Func install_package_xml


		/*   if a require exists, include it.  this will
		 *   show us where an error exists in a package
		 *   instead of making us blindly guess
		 */
		if($pkg_config['include_file'] <> "") {
			$static_output = "Loading package instructions...";
			update_output_window($static_output);
			fwrite($fd_log, "require_once('include_file')\n");

# here variable $config['installedpackages']['package'][$pkgid]['name']  is exists

			require_once($pkg_config['include_file']);

# here variable $config['installedpackages']['package'][$pkgid]['name']  undefined
		}

If i install package squid3 (and other), then i have installed menu/service/package but not in installed_packages list.

cmb

This sounds like the same thing I'm seeing with the OpenVPN Client Export package, it works fine, but it's not listed for uninstall. I opened a ticket, if you find a cause dvserg please comment on this ticket.
http://redmine.pfsense.org/issues/show/309

jimp

I thought I opened a ticket for this but perhaps not.

Any time a require is done on something that includes config.inc again, it blows away $config and package data is lost.

Usually this can be fixed by altering the package's .inc file to stop including things that are no longer necessary.

dvserg

Maybe say what config already loaded ?

! do not reload config file from packages include !

global $config_inc_loaded ;
$config_inc_loaded = true;
require_once($pkg_config['include_file']);

My packages after reinstall is showed in installed list.

eri--

config.inc is not anymore required neither exists in 2.0 !

jimp

If it's not supposed to exist on 2.0, perhaps it should be removed during upgrades. It's still present on my 2.0 test box.

dvserg

Probably need make temporary fix. This behavior can crash of config.xml.

jimp

Ermal, is it really supposed to be gone in 2.0? I still show it as being present in the git repo in etc/inc/config.inc

And it's still included in quite a few places in /etc/rc, and in /usr/local/www and I imagine it is used in other places as well.