Dashboard: Traffic Graph *FIXED*

roi

It does not make a change.
I will screen capture and upload a pic later.

jimp

The way that the widgets work, the updates are triggered every <x>seconds, so it may also be that because the data request and drawing take some time, it is delayed a little on drawing but the actual updates happen as soon as possible.

This would probably be more apparent on embedded systems.</x>

c0urier

Hi jimp,

It works fine on pfsense 1.2.3 (i386) - But on 2.0-BETA4 (amd64) built on Mon Oct 11 14:48:49 UTC 2010 it does not work and not any of the earlier releases.

jimp

You need to give a lot more detail than "it does not work".

As much detail as possible, how much of delay, how it was measured, etc, etc. A vague problem description is nobody's friend.

chudy

approximately(don't have milisec timer)
5sec refresh interval = 10sec graph update (CPU usages 1%)
1sec refresh interval = 5sec graph update (CPU usages 1%)

wan vs lan graph
lan delayed 3/4 of the graph(out of sync)

same machine used from pfsense123 to pfsense20

jimp

Is that 10 seconds every update, or only the first update?

The initial updates don't happen until 5-10 seconds after the index page loads. The AJAX updates don't immediately start to fire, or it consumes too much CPU.

chudy

Updates until the wan full graph.
lan 3/4 of wan. both 1sec & 5sec refresh interval.

anyway whats important for me is the sync of wan & lan

Dashboard displayed:
Traffic Graphs only

jimp

Looking at the code, we introduce a 3 second delay between graph updates on purpose. Probably to let embedded systems catch up, but the logic isn't quite right because over time it just gets farther and farther apart. I'll see if there is something that can be done.

jimp

This should be somewhat fixed now. I made it so the graph updates are still staggered a little, but only the initial update is delayed, not each subsequent update as well.

They all stay in line for me now, but it might be interesting to know if it works well on embedded systems (I don't have my alix imaged and ready to test at the moment). It may not be in the next snapshot, but should be in the one after that.

roi

On Oct 10 22:01:17 build it's out of sync.
I'll see when the next will come out.

Maybe put a tik for selecting if it's an embedded or standard.
on my Athlon 2000+ CPU was still 1% when I set the update rate to 1 sec with two graph's open.

chudy

@jimp
Would you be kind to give us some patch?

c0urier

Hi jimp,

It updates after the interval you set now - Which means it can update every second - Thanks!

@ chudy, I've upgraded to the latest snapshot and it works there: 2.0-BETA4 (amd64) built on Tue Oct 12 06:44:49 UTC 2010

jimp

This may be enough:
https://rcs.pfsense.org/projects/pfsense/repos/mainline/commits/9228de6c4d231ab1325014e8341f5d0f981a0af0

Though I did this bit of whitespace fixing first, so you might need it:
https://rcs.pfsense.org/projects/pfsense/repos/mainline/commits/719dcffb6e6bef6e911fe570067699917cccbc84

roi

With snap built on Tue Oct 12 02:05:23 EDT 2010 it seem to be OK.