[feedback] PROXY settings misconfiguration

epi

Hi,
I installed the following snapshot:

Current version: 2.0-RC2
Built On: Wed May 18 21:03:18 EDT 2011
–--

First, thanks for adding support for retrieving packages and new firmware via proxy !!!

It works perfectly, but there are a small caveat:

FIRMWARE UPGRADE
Via System>Advance>Miscellaneous we can set the value for : 'proxyurl' and 'proxyport' that is fine.
Those values are later on used to check if there exists a new firmware update available.
But, the underlying script has a typo, it tries to set "CURLOPT_PROXYUSERPASS", which should be "CURLOPT_PROXYUSERPWD" (see: http://php.net/manual/en/function.curl-setopt.php),
as a consequence of this typo a warning message is shown on the GUI.


Warning: curl_setopt(): Invalid curl configuration option in /etc/inc/pfsense-utils.inc on line 1474

PACKAGES INSTALLATION

The proxy values should also be used when I try to retrieve list of available package and to install
a package. But, that is not the case, the underlying code has support for using proxy, but it
expects to retrieve the proxy information from 'httpproxy' and 'httpproxyport' instead of the 'proxyurl' and 'proxyport' that are set via the Miscellaneous GUI.


	$port = 0;
	$proxyurl = "";
	$proxyport = 0;
	$proxyuser = "";
	$proxypass = "";
	if (!empty($config['system']['httpproxy']))
		$proxyurl = $config['system']['httpproxy'];
	if (!empty($config['system']['httpproxyport']) && is_numeric($config['system']['httpproxyport']))
		$proxyport = $config['system']['httpproxyport'];
	if (!empty($config['system']['httpproxyuser']))
		$proxyuser = $config['system']['httpproxyuser'];
	if (!empty($config['system']['httpproxypass']))
		$proxypass = $config['system']['httpproxypass'];
	$cli = new XML_RPC_Client($xmlrpc_path, $xmlrpc_base_url, $port, $proxyurl, $proxyport, $proxyuser, $proxypass);

Again, thanks a lot for adding the proxy support I've being waiting for this for a long, long time

c.u.
Epi

eri--

Should be corrected.
Try with next version and thank you for reporting.

tstorr

I'd just like to say thanks for putting this feature in. It is a deal breaker for me and works just fine. Once again thanks for the great work.

Cheers

Trevor