Ntop not creating correct ntop.sh file on reboot

jimp

It shouldn't have affected any other packages unless they had some code to work around the fact that the old interface selection was broken. IMspector may have been trying to outsmart the bug.

Cino

@jimp:

It shouldn't have affected any other packages unless they had some code to work around the fact that the old interface selection was broken. IMspector may have been trying to outsmart the bug.

I think IMspector worked around it, but now it doesn't know what to do:

Before the code in my config.xml:


...
<iface_array>lan,opt4</iface_array>
<proto_array>msn,icq,yahoo,irc</proto_array>
...

after the code change, IMspector wont start if I make changes:


...
<iface_array>Array</iface_array>
<proto_array>Array</proto_array>
...

From the system log:


Jul 6 10:51:59 	imspector: Good-bye
Jul 6 10:51:59 	php: imspector: Stopping service: no interfaces and/or protocols selected
Jul 6 10:51:59 	php: imspector: Interface Array has no ip address, ignoring

I manually edited config.xml and it starts on startup… Just can't make any changes to via the web interface.

jimp

Hmm, interesting, since the only field name that should have had any change would have been named exactly interface_array, not the others. They should have had the same net effect as before.

jimp

Found it, I forgot one bit in the change I made.

https://github.com/bsdperimeter/pfsense/commit/292b356f8cdaf26b919009f1a1bc51a1ea02166f

I pushed all that into the ipv6 fork as well.

Cino

Thank you! That did the trick

ncolunga

Hi,

I'm having the same problem on 2.0 RC3 amd64 with ntop 4.0.1_1 v2 when i choose two ifs. i've checked pkg_edit.php but it's different to the code you posted.

Regards.

198:208
_$fieldname = $fields['fieldname'];
$fieldvalue = $POST[$fieldname];
if (is_array($fieldvalue))
$fieldvalue = implode(',', $fieldvalue);
else {
$fieldvalue = trim($fieldvalue);
if ($fields['encoding'] == 'base64')
$fieldvalue = base64_encode($fieldvalue);
}
if($fieldname)
$pkgarr[$fieldname] = $fieldvalue;

jimp

@ncolunga:

I'm having the same problem on 2.0 RC3 amd64 with ntop 4.0.1_1 v2 when i choose two ifs. i've checked pkg_edit.php but it's different to the code you posted.

What snapshot date are you on?

ncolunga

I've updated to Aug 1 firmware but this didnt solve the problem.

Thank you.

jimp

Are you using IPv6 code?

ncolunga

No, but i have done a new install, upgrade to Aug 2 firmware and now everything is ok. It seems to be related some way to my old config backup.

Thank you.