Country Block

tommyboy180

The large lists take up the default memory space. I was able to overcome this in IPblocklist version 3.5 by adding:

set limit table-entries 900000

I put this at the top of rules.debug. You can enter any amount that you think will be big enough but 900000 should cover all scenarios.
Hopefully there is a smooth way to add this option to the rules.debug file.

marcelloc

@tommyboy180:

The large lists take up the default memory space. I was able to overcome this in IPblocklist version 3.5 by adding:
set limit table-entries 900000
I put this at the top of rules.debug. You can enter any amount that you think will be big enough but 900000 should cover all scenarios.
Hopefully there is a smooth way to add this option to the rules.debug file.

I have no idea how to do this, but I will take a look on it.

~~For a stand alone use, all my tests went fine. tomorrow I will check sync problems~~.

All tests with pfBlocker, including sync between pfsenses boxes were sucessfull.

Did you liked the new options in gui? It was what you were thinking?

Cino

Great work!! I am having an issue tho: i'm getting this error with i click on the top spammers tab:

Warning: fopen(/usr/local/pkg/pfblocker_topspammers.xml): failed to open stream: No such file or directory in /etc/inc/xmlparse.inc on line 175

Warning: Invalid argument supplied for foreach() in /usr/local/www/pkg_edit.php on line 418

I did go thru and removed every entry of countryblock and pfblocker in my config and file system before doing installing the package again.. same results

running:
2.1-DEVELOPMENT (i386)
built on Tue Sep 13 17:28:43 EDT 2011
FreeBSD 8.1-RELEASE-p4

P.S my last git sync was this morning

marcelloc

Reinstall the package, there was a missing file in pfBlocker.xml

I've fixed this few hours ago. Btw i'll test this in a vm.

Cino

I did another re-install. Same results.. Let me know how your test turns out… Wondering if its because i'm running 2.1

marcelloc

@Cino:

I did another re-install. Same results.. Let me know how your test turns out… Wondering if its because i'm running 2.1

Does 2.1 uses same pkg repo as 2.0?

Cino

@marcelloc:

@Cino:

I did another re-install. Same results.. Let me know how your test turns out… Wondering if its because i'm running 2.1

Does 2.1 uses same pkg repo as 2.0?

as far as i know, yes

marcelloc

I found the error.

I'm fixing it right now.

Cino

@marcelloc:

I found the error.

I'm fixing it right now.

that did it.. Thank you!!! Only using the country blocking right now, over the weekend, i'll give the ip-list side a tried

marcelloc

pfBlocker 0.1.2 is out.

Now with widget.

tommyboy180

I we can't figure out how to increase the table size limits for large lists like level1 then perhaps we can break the lists into multiple tables.

Example:
table limit will be 10,000 entries. More entries will go into another table. So if Level1 has 35,000 lines the we will have 3 tables

pfblocker - 10000 lines
pfblocker1 - 10000 lines
pfblocker2 - 10000 lines
pfblocker3 - 5000 lines

What do you think? I hope we can find a way to increase the memory limit.

marcelloc

Could be a solution for this problem.

I'm still looking for a way to do it without multiple tables or file hacks.

Does it happens on x64 versions with for example 4g ram?

And thanks for widget clue. :)

marcelloc

I've included all countries and levels 1,2,3 plus some ads, virus, etc

total:449418 Networks

no erros.

my system is x64 with more then 4g ram.

tommyboy180

The problem is it isn't a RAM limitation. It's a memory max allocation variable that is small to begin with. So no matter how much RAM you have on x86 or x64 you will get that error once that limitation is hit.

This is why it is a problem. We need to be able to raise that limit other wise the functionality will be greatly limited, leaving users to fall back on IP-Blocklist.

tommyboy180

449418 Networks seems very small for level1, 2, and 3 with others. Are you sure those lists were all successful?

marcelloc

Could we include in GUI an option to increase this value and advise users that its unsupported?

EDIT:

wc -l in level files downloaded in cidr from fetch:

245749 level1
85703 level2
18753 level3
350205 total

tommyboy180

kk. We could give the users the option. It would just be inserting that text every time that file gets recreated. I've already done most of the work in IP-Blocklist and Countryblock.

/usr/local/pkg/pf/pf-blocker.sh


#!/bin/sh
export t=`grep -n 'User Aliases' /tmp/rules.debug |grep -o '[0-9]\{1,2\}'`
t=$(($t+'1'))
#Insert table-entry limit 
/usr/bin/sed -i -e '/900000/d' /tmp/rules.debug

while read line
	do a=$(($a+1)); 
	#echo $a;
	if [ "$a" = "$t" ]; then
		echo "" >> /tmp/rules.debug.tmp
		echo "set limit table-entries 900000" >> /tmp/rules.debug
	fi
	echo $line >> /tmp/rules.debug
done < "/tmp/rules.debug"

This code isn't tested but it's on the right track. We will have to have it check if the user has enabled this feature. I do this is IP-Blocklist and countryblock. Basically if the user enables it the package will create a file. If it's disabled the the file will be deleted. The script above will check if the file exists```
if [ -e FILE ] ....code here

marcelloc

ok, I think its good enough to prevent errors until some 'core developer' could help us.

I'll try to put it in php way for most code compatibility.

The last thing to finish pfBlocker is cron package integration.

tommyboy180

Cron for the updates?

marcelloc

use cron package instead of editing /etc/cront for lists updates…