Forum tables seem to be broken

jimp

It's been broken for years… I tried to fix it once, never did find the css responsible, but I didn't have much time to spend on it then. It's something in SMF. Not sure if it's part of the theme or what.

stephenw10

While reading up on how BBCode tables are supposed to work I stumbled on this forum post.

It seems to idicate the behaviour of the table tag is at least partially controlled by the subs.php file:


array(
				'tag' => 'table',
				'before' => '',
				'after' => '

',
				'trim' => 'inside',
				'require_children' => array('tr'),
				'block_level' => true,
			),

So perhaps it's not inheriting the colour for what ever reason. Perhaps it could just be set to black instead.
Beyond my skills TBH.

Steve

jimp

Looks like it is actually inherited, from the main css of the theme…

body, td, th , tr
{
        color: #ffffff;
        font-size: small;
        font-family: verdana, sans-serif;
}

Changing that also changes the color of many other areas on the site, like the page number at the bottom of the thread though.

Metu69salemi

So recreation of css is next thing

stephenw10

@jimp:

Changing that also changes the color of many other areas on the site, like the page number at the bottom of the thread though.

That would be bad. So why not just change the table tag to not inherit the style:


                                'tag' => 'table',
				'before' => '',
				'after' => '

',
				'trim' => 'inside',
				'require_children' => array('tr'),
				'block_level' => true,

Or am I missing something obvious?

Steve

jimp

Tried that (that's how it is now, check the html source) apparently the css takes precedence.

jimp

aha, the table tag didn't do it, but the td tag did.

stephenw10

Excellent! ;D

Of course now this thread is littered with tables. :D

Steve

wallabybob

Thanks Jimp.

I have SMF 1.1.4 installed on my home server and it displays tables with black text and usesOf course the page layout looks rather different.

Perhaps the real problem is in the pfSense stylesheet.

The default style sheet on the SMF 1.1.4 installation includes:```

/* By default (td, body..) use verdana in black. */
body, td, th , tr
{
color: #000000;
font-size: small;
font-family: verdana, sans-serif;
}


I have only minimal experience with stylesheets so wouldn't suggest that anyone take this speculation very seriously: I wonder about the style sheet snippet Jimp posted earlier. Some parts of the default pfSense theme have white text on a black background (style smalltext?) but other parts have black text on a light background (style post?). Perhaps the style sheet part that generates black text on a light background needs to also do so for "td".

wallabybob

Its broken again. Or maybe I just imagined display of tables was fixed.

jimp

How about now?

wallabybob

@jimp:

How about now?

Looks good! Verified in preview and post. Thanks.