[ER] scrollable drop-down menus in pfsense_ng theme…

stephenw10

260 pixels seems a bit low to me. I wouldn't want this on a standard machine if it didn't need it. What length menu can you fit on a netbook (1024x600) screen? In full screen mode?

Steve

phil.davis

I use a netbook a lot, carry it around and plug it into an external monitor at home and work. It is annoying when dropdown lists, menus, dialog boxes etc extend down below the screen and I can't easily select the lower items, or press the OK button! When there is something to test, I am happy to put it through its paces, switching between the netbook screen and external monitor, seeing if things automatically adjust etc.
Hopefully the scrollbars only appear if the menu won't fit on the screen - so people with big screens will never see them.

ccesario

@jimp:

Github was reporting that it couldn't be merged in for some reason. Might need updated and resubmitted as a new pull request.

Ok Jimp. I resubmitted the pull request with my respository sync.

thanks

jimp

Would there be some way to make that dynamic based on the window height? Seems that should only need to kick in for small screens. I do not want scrollbars on my full size window when it's capable of showing the whole menu.

ccesario

Well,

The this pull request https://github.com/bsdperimeter/pfsense/pull/144 add scrollbar in dropdown menu based in window height.

I think this may solve the problem of big and small screens

;)

jimp

I shrank my window's vertical size way down (it was a tiny strip across) and it didn't kick in for me… hmm.

jimp

aha, had to clear cache first (or shift+reload)

jimp

looks good! Though the menu could actually be a little longer. It's sized base on the height but it's leaving quite a bit of room under it

ccesario

@jimp:

looks good! Though the menu could actually be a little longer. It's sized base on the height but it's leaving quite a bit of room under it

Nice!

To increase menu size, change the value '100' in line 32 of file /usr/local/www/themes/pfsense_ng/loader.js
hwindow = (jQuery(window).height()-100);

I usage the formule: 'window.height - 100' to define menu size, so per example: 'window.height - 50' increase the dropdown menu

:)

jimp

35 seems to be the most comfortable fit for me, I committed that change. It leaves enough room for the bottom of the menu, the shadow, and few px worth of open space (Tried it on FF, Chrome, and Opera)

ccesario

@jimp:

35 seems to be the most comfortable fit for me, I committed that change. It leaves enough room for the bottom of the menu, the shadow, and few px worth of open space (Tried it on FF, Chrome, and Opera)

Cool!

Thank you :)

phil.davis

I loaded:
2.1-BETA0 (i386)
built on Wed Jun 13 20:47:21 EDT 2012
FreeBSD 8.3-RELEASE-p3

Using Firefox 13.0 browser.

As Jim did, I had to cleared my cache once to get the scrollbars happening.
The scollbars happen based on the browser window size when I login. Works well for me.
If I resize the browser window while logged in, the scrollbars don't come or go, the dropdown menu doesn't get longer or shorter. But I guess that is fine. The fine touch would be to make the dropdown menu sizing/scrollbar calculation get re-invoked from some window-resizing callback - then it would adjust itself automagically when the window is resized - but I have no idea about implementing stuff like this.
I should have played more before posting - after resizing the window a simple page reload makes the menus and scrollbars adjust to the new window size. Also, selecting something from the menus makes a whole new page draw up, which also resets the menus and scrollbars to the new window size. All working very nicely for me.

This is very handy when working from small screens. Particularly for the Diagnostics and Status menus, that are fairly long. Murphy's Law in this case states that you will always want to select the first item on the menu that is not visible. Now Murphy will have to think of something else :)

Thanks for this handy UI feature.

ccesario

@phil.davis:

I loaded:
2.1-BETA0 (i386)
built on Wed Jun 13 20:47:21 EDT 2012
FreeBSD 8.3-RELEASE-p3

Using Firefox 13.0 browser.

As Jim did, I had to cleared my cache once to get the scrollbars happening.
The scollbars happen based on the browser window size when I login. Works well for me.
If I resize the browser window while logged in, the scrollbars don't come or go, the dropdown menu doesn't get longer or shorter. But I guess that is fine. The fine touch would be to make the dropdown menu sizing/scrollbar calculation get re-invoked from some window-resizing callback - then it would adjust itself automagically when the window is resized - but I have no idea about implementing stuff like this.
I should have played more before posting - after resizing the window a simple page reload makes the menus and scrollbars adjust to the new window size. Also, selecting something from the menus makes a whole new page draw up, which also resets the menus and scrollbars to the new window size. All working very nicely for me.

This is very handy when working from small screens. Particularly for the Diagnostics and Status menus, that are fairly long. Murphy's Law in this case states that you will always want to select the first item on the menu that is not visible. Now Murphy will have to think of something else :)

Thanks for this handy UI feature.

Really this is a very handy when working from small screens (I usage)
Thank you by feedback :)