Netgate Discussion Forum
    • Categories
    • Recent
    • Tags
    • Popular
    • Users
    • Search
    • Register
    • Login

    Temperature Widget

    Scheduled Pinned Locked Moved 2.1 Snapshot Feedback and Problems - RETIRED
    95 Posts 15 Posters 44.6k Views
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • stephenw10S
      stephenw10 Netgate Administrator
      last edited by

      The only reason I mentioned the PIII is:

      @https://github.com/freebsd/freebsd-head/blob/master/sys/dev/coretemp/coretemp.c#L166:

      /*

      • Some CPUs, namely the PIII, don't have thermal sensors, but
      • report them when the CPUID check is performed in
      • coretemp_identify(). This leads to a later GPF when the sensor
      • is queried via a MSR, so we stop here.
        */
        if (cpu_model < 0xe)
        return (ENXIO);

      If we used code similar to coretemp_identify the percentage of systems where coretemp was loaded incorrectly would be very small I would think.

      Steve

      Edit: Too ambiguous.

      1 Reply Last reply Reply Quote 0
      • W
        wallabybob
        last edited by

        @stephenw10:

        If we used code similar to coretemp_identify the percentage of systems where coretemp was loaded incorrectly would be very small I would think.eadily have

        Duplicated logic can quickly become a maintenance pain: who wants to track coretemp.c for changes in CPUs it supports, especially when that logic is not in one neat area.

        Based on Jimp's post
        @jimp:

        Yes, loading coretemp would be practically a no-op on an unsupported system. As when it's in the kernel, it simply does not attach if the hardware is not present. However, it will consume some memory just for having been loaded. Not a ton, but when every bit counts, loading it unnecessarily should be avoided.

        I would suggest to anyone who cares:
        1. Check if loadable device drivers which report an error in their probe or attach functions get unloaded automatically.
        2a. If so, the "ongoing" cost of always loading coretemp on Intel CPUs would be quite small.
        2b. If not, check for the coretemp sysctl(s) and if not there, kldunload coretemp to recover most (all?) the memory used by coretemp.

        1 Reply Last reply Reply Quote 0
        • rcfaR
          rcfa
          last edited by

          Whenever you figure out which way to proceed, and implement that in a specific snapshot, would you please be so kind as to let us know what we should/must do with the manually installed coretemp.ko and boot config lines at that point?
          I'd hate to have strange behavior or errors because the manual config clashes with what's done automatically..

          1 Reply Last reply Reply Quote 0
          • jimpJ
            jimp Rebel Alliance Developer Netgate
            last edited by

            If you put them in /boot/kernel/ then you don't have to do anything.

            Loading it with loader.conf would still be fine, it can't load twice so even if it was auto loaded it would be a no-op.

            Not really a wrong way to do it I'd say. I'm still leaning toward making it manual, it seems more in line with how we handle other such dilemmas.

            Remember: Upvote with the 👍 button for any user/post you find to be helpful, informative, or deserving of recognition!

            Need help fast? Netgate Global Support!

            Do not Chat/PM for help!

            1 Reply Last reply Reply Quote 0
            • rcfaR
              rcfa
              last edited by

              @jimp:

              If you put them in /boot/kernel/ then you don't have to do anything.

              Good.

              @jimp:

              Loading it with loader.conf would still be fine, it can't load twice so even if it was auto loaded it would be a no-op.

              Not really a wrong way to do it I'd say. I'm still leaning toward making it manual, it seems more in line with how we handle other such dilemmas.

              I wouldn't mind if we just had a check box in the appropriate place in the advanced setup pages, maybe with a pop-up list of choices what to use (coretemp, amdtemp, ACPI, etc.). Autodetection just screams like a lot of code maintenance in an open system where buggy BIOS, a variety of CPUs, etc. clash.

              1 Reply Last reply Reply Quote 0
              • jimpJ
                jimp Rebel Alliance Developer Netgate
                last edited by

                ACPI will always work no matter what.

                I'm thinking a drop down just like the crypto choice will do:

                None
                coretemp (Intel Core* CPUs)
                amdtemp (AMD CPUs)

                Would be nice to have some more accurate descriptive text to put there, have to come up with something to explain that it may not work, etc, etc.

                Remember: Upvote with the 👍 button for any user/post you find to be helpful, informative, or deserving of recognition!

                Need help fast? Netgate Global Support!

                Do not Chat/PM for help!

                1 Reply Last reply Reply Quote 0
                • rcfaR
                  rcfa
                  last edited by

                  @jimp:

                  ACPI will always work no matter what.

                  I'm thinking a drop down just like the crypto choice will do:

                  None
                  coretemp (Intel Core* CPUs)
                  amdtemp (AMD CPUs)

                  Would be nice to have some more accurate descriptive text to put there, have to come up with something to explain that it may not work, etc, etc.

                  Yup, that's what I was thinking about, like the crypto thing.
                  Couldn't instead of the None label be ACPI used? The idea ACPI would be a fall-back option, but if a CPU internal method is chosen, that's given preference if selected.

                  1 Reply Last reply Reply Quote 0
                  • M
                    m4f1050
                    last edited by

                    I am stuck with using mbmon, on my functions.inc.php I added one last check and copied mbmon to /usr/local/bin folder

                    
                    function get_temp() {
                    //      switch(get_hwtype()) {
                    //              default:
                    //                      return;
                    //      }
                    //
                    //      return $ret;
                    
                             $temp_out = "";
                             exec("/sbin/sysctl dev.cpu.0.temperature | /usr/bin/awk '{ print $2 }'
                    | /usr/bin/cut -d 'C' -f 1", $dfout);
                             $temp_out = trim($dfout[0]);
                             if ($temp_out == "") {
                               exec("/sbin/sysctl hw.acpi.thermal.tz0.temperature | /usr/bin/awk '{
                    print $2 }' | /usr/bin/cut -d 'C' -f 1", $dfout);
                               $temp_out = trim($dfout[0]);
                             }
                             if ($temp_out == "") {
                               exec("/usr/local/bin/mbmon -T1 -i -c1", $dfout);
                               $temp_out = trim($dfout[0]);
                             }
                    
                             return $temp_out;
                    }
                    
                    

                    How can I save this so it doesn't get overwritten every time I update pfSense?

                    Also I have WGXepc and serialbandaid.sh in /usr/local/bin but they get deleted as well… in /etc/rc I have WGXepc turning off my backlight and running serialbandaid.sh before the 'exit 0'...and in beep.sh I have it turning the Arm/Disarm LED to green on 'start' and to red on 'stop'

                    1 Reply Last reply Reply Quote 0
                    • jimpJ
                      jimp Rebel Alliance Developer Netgate
                      last edited by

                      Finally got back around to this…
                      https://github.com/bsdperimeter/pfsense/commit/f60156f68f615dc137391f3a909a0ee7a0c3c003

                      Remember: Upvote with the 👍 button for any user/post you find to be helpful, informative, or deserving of recognition!

                      Need help fast? Netgate Global Support!

                      Do not Chat/PM for help!

                      1 Reply Last reply Reply Quote 0
                      • S
                        strumf666
                        last edited by

                        Is this in the newest snapshot? Is there a cpu frequency widget also available? I am curious if cool&quiet is working.
                        Is anybody using e-350 and is able to read temperatures? I am using e35m1-m pro but I can't see temps with neither coretemp or amdtemp…

                        1 Reply Last reply Reply Quote 0
                        • jimpJ
                          jimp Rebel Alliance Developer Netgate
                          last edited by

                          There hasn't been a new snapshot in the last couple days, we're sorting out some issues with ipfw patches to get CP bandwidth counting working properly

                          Remember: Upvote with the 👍 button for any user/post you find to be helpful, informative, or deserving of recognition!

                          Need help fast? Netgate Global Support!

                          Do not Chat/PM for help!

                          1 Reply Last reply Reply Quote 0
                          • stephenw10S
                            stephenw10 Netgate Administrator
                            last edited by

                            amdtemp was patched for Brazos compatibility in Feb this year:
                            http://www.freebsd.org/cgi/query-pr.cgi?pr=156358
                            And was in fact tested as working specifically on the E35M1-M Pro.  :)

                            Steve

                            Edit: BUT it looks like only for FreeBSD 9.  :(

                            Edit: Ok some confusion from me!
                            It looks like a different, much larger, patch was added in Feb to support Brazos among other things. However it was applied to /head and didn't make it into the 8 tree.
                            The originally suggested (and tested) patch against 8.2 simply added the PCI IDs to the driver so that would be easy to apply yourself.

                            1 Reply Last reply Reply Quote 0
                            • S
                              strumf666
                              last edited by

                              I just add the red text to the amdtemp.c?

                              1 Reply Last reply Reply Quote 0
                              • stephenw10S
                                stephenw10 Netgate Administrator
                                last edited by

                                That's what I would try.
                                You will need a FreeBSD 8.3 machine to recompile it on of course.

                                Steve

                                1 Reply Last reply Reply Quote 0
                                • S
                                  strumf666
                                  last edited by

                                  Recompile? I'm a freebsd/linux n00b :)

                                  1 Reply Last reply Reply Quote 0
                                  • M
                                    m4f1050
                                    last edited by

                                    I was using a free shell account when I was trying to compile a wifi adapter driver and they were FreeBSD 8.3 which is why it wouldn't work on pf 2.0.1 but the have upgraded to 9.0 now :-/  I found one with FreeBSD 8.1 and I got the wifi working but access point didn't work so I went and got a TP Link 851 and finished my wireless ap project.

                                    You can look for a free shell maybe you get lucky..

                                    1 Reply Last reply Reply Quote 0
                                    • First post
                                      Last post
                                    Copyright 2025 Rubicon Communications LLC (Netgate). All rights reserved.