Snort Widget v0.3.2, Snort 2.9.2.3 pkg v. 2.5.1 Alerts Tab and Blocked tab fix
-
Do you have any alerts in the Snort alerts list?
What version of Snort and pfSense are you using? -
This should fix the 'foreach' error:
Snort Widget v0.3.2 fix (update 03-08-2012): Sorts all interfaces by date, displays ip and port, fixes Snort alert descriptions with ",". Uses firewall widget setting as number of entries. Removed bogus line. Fixed 'foreach' error when no alerts are found.
Just install Snort Widget v0.3.2 and replace the /usr/local/www/widgets/snort_alerts.widget.php with this:/* snort_alerts.widget.php Copyright (C) 2009 Jim Pingle mod 03-08-2012 Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met: 1\. Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer. 2\. Redistributions in binary form must reproduce the above copyright notice, this list of conditions and the following disclaimer in the documentation and/or other materials provided with the distribution. THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES, INClUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ global $config, $g; /* array sorting */ function sksort(&$array, $subkey="id", $sort_ascending=false) { if (count($array)) { $temp_array[key($array)] = array_shift($array); }; foreach ($array as $key => $val){ $offset = 0; $found = false; foreach ($temp_array as $tmp_key => $tmp_val) { if (!$found and strtolower($val[$subkey]) > strtolower($tmp_val[$subkey])) { $temp_array = array_merge((array)array_slice($temp_array,0,$offset), array($key => $val), array_slice($temp_array,$offset)); $found = true; }; $offset++; }; if (!$found) $temp_array = array_merge($temp_array, array($key => $val)); }; if ($sort_ascending) { $array = array_reverse($temp_array); } else $array = $temp_array; }; /* check if firewall widget variable is set */ if (!isset($nentries)) $nentries = 5; /* retrieve snort variables */ require_once("/usr/local/pkg/snort/snort.inc"); if (!is_array($config['installedpackages']['snortglobal']['rule'])) $config['installedpackages']['snortglobal']['rule'] = array(); $a_instance = &$config['installedpackages']['snortglobal']['rule']; /* read log file(s) */ $counter=0; foreach ($a_instance as $instanceid => $instance) { $snort_uuid = $a_instance[$instanceid]['uuid']; $if_real = snort_get_real_interface($a_instance[$instanceid]['interface']); /* make sure alert file exists */ if (file_exists("/var/log/snort/snort_{$if_real}{$snort_uuid}/alert")) { exec("tail -n{$nentries} /var/log/snort/snort_{$if_real}{$snort_uuid}/alert > /tmp/alert_{$snort_uuid}"); if (file_exists("/tmp/alert_{$snort_uuid}")) { $tmpblocked = array_flip(snort_get_blocked_ips()); /* 0 1 2 3 4 5 6 7 8 9 10 11 12 */ /* File format timestamp,sig_generator,sig_id,sig_rev,msg,proto,src,srcport,dst,dstport,id,classification,priority */ $fd = fopen("/tmp/alert_{$snort_uuid}", "r"); while (($fields = fgetcsv($fd, 1000, ',', '"')) !== FALSE) { if(count($fields) < 11) continue; $snort_alerts[$counter]['instanceid'] = $a_instance[$instanceid]['interface']; $snort_alerts[$counter]['timestamp'] = $fields[0]; $snort_alerts[$counter]['timeonly'] = substr($fields[0], 6, -8); $snort_alerts[$counter]['dateonly'] = substr($fields[0], 0, -17); $snort_alerts[$counter]['src'] = $fields[6]; $snort_alerts[$counter]['srcport'] = $fields[7]; $snort_alerts[$counter]['dst'] = $fields[8]; $snort_alerts[$counter]['dstport'] = $fields[9]; $snort_alerts[$counter]['priority'] = $fields[12]; $snort_alerts[$counter]['category'] = $fields[11]; $counter++; }; fclose($fd); @unlink("/tmp/alert_{$snort_uuid}"); }; }; }; /* display the result */ ?> if (is_array($snort_alerts)) { /* sort the array */ if (isset($config['syslog']['reverse'])) { sksort($snort_alerts, 'timestamp', false); } else { sksort($snort_alerts, 'timestamp', true); }; $counter=0; foreach ($snort_alerts as $alert) { echo(" "); $counter++; if($counter >= $nentries) break; } }; ?> | IF/Date | Src/Dst | Details | " . $alert['instanceid'] . " " . $alert['timeonly'] . " " . $alert['dateonly'] . " | " . $alert['src'] . ":" . $alert['srcport'] . " " . $alert['dst'] . ":" . $alert['dstport'] . " | Pri : " . $alert['priority'] . " Cat : " . $alert['category'] . " |Github pull request made.
-
I no longer get the error. Thanx! I also have no alerts, so I'm waiting to see if they show up. ;)
-
@fillmoreb: Thanks for the bugreport and testing.
@ermal: could you push this? -
I had the problem and the fix worked for me. Not see a block yet but no more error shows.
-
Thanks for the response. The widget will only display alerts if there are any.
-
I am waiting for ermal to pull the changes. ;)
-
Has this been pushed to production?
Should we be looking for a version change, or just reinstall the package? -
As soon as it has been pulled you just have to reinstall.
-
Looking forward to seeing this fix as well.
-
FYI: Widget issue:
Warning: Invalid argument supplied for foreach() in /usr/local/www/widgets/widgets/snort_alerts.widget.php on line 36is still there.
-
The 03-08 fix still not has been pulled…
If you have the error you have to fix it manually with the latest fix I sended 03-08-2012.
The file /usr/local/www/widgets/snort_alerts.widget.php should contain "mod 03-08-2012" at line 5. -
Date today: 12-11-29: Fix is not merged into the package. Seems to be like no (or very small) interest to fix it?????
-
Same here I got the same problem Warning:
Invalid argument supplied for foreach() in /usr/local/www/widgets/widgets/snort_alerts.widget.php on line 36 Warning: array_reverse(): The argument should be an array in /usr/local/www/widgets/widgets/snort_alerts.widget.php on line 50
-
I don't know why the fixes aren't pulled :-\
The problem only exists when you don't have any snort-alerts.
To fix it manually, re-install the Snort Widget package and replace the file as I describe in this post:
http://forum.pfsense.org/index.php/topic,51782.msg278917.html#msg278917 -
I re installed and it worked but now I have another problem with the pfsense dashboard page it self :D I only have one column for widgets not two :( how to solve this?