[FIXED] Traffic Shaper Wizard does not recognize Interfaces correctly

[luckman212]

I just backed up and am going to try rolling back to the FEB 19 20:09 build … will let you know if it works, at least then we can narrow down when it broke and look at changesets.  I already looked through redmine at the commits and didn't see anything glaringly obvious.  :(

[p1erre]

Just upgraded to the latest snapshot, the error still appears.
I get the error after I entered the number of LAN connections.
I also tried other wizards and i get the same error after i typed the number of WAN or LAN connections.
Attached my interface configuration and the error message.

Cheers Pierre


[phil.davis]

Upgraded to:
2.1-BETA1 (i386)
built on Fri Feb 22 06:01:13 EST 2013
FreeBSD 8.3-RELEASE-p6
The traffic shaper "By Interface" tab now shows only "WIFI" - it used to have LAN, WAN and OPT1 also.
Starting any of the wizards and progressing past entering a number of LAN or WAN interfaces results in messages like:

You have less interfaces than number of connections!

So it was working on Tue Feb 19 20:09:59 EST 2013 and broke somewhere between then and Fri Feb 22 06:01:13 EST 2013.

[phil.davis]

$xxx = get_real_interface("wan");
var_dump($xxx);
$res = is_altq_capable($xxx);
var_dump($res);

Result on old snaps:

string(3) "vr1"
bool(true)

Result on later snap:

string(3) "vr1"
bool(false)

/etc/inc/shaper.inc get_interface_list_to_show() uses is_altq_capable() to build its list.
It broke in https://github.com/bsdperimeter/pfsense/commit/2ccac12588f59039c88d06126762f41be2f65ce2
I need to do other things now, if someone fixes it good, otherwise I will look again later.

[luckman212]

thanks Phil, nice detective work there. Wouldn't simply changing /etc/inc/interfaces.inc at line 4526

if (in_array($int_family[0], $capable))

to

if (in_array($int_family, $capable))

fix the problem? or am I being too simplistic?

[phil.davis]

Yep, that's the fix. The pull request is here: https://github.com/bsdperimeter/pfsense/pull/431/files

[anas_xrt]

@phil.davis:

Yep, that's the fix. The pull request is here: https://github.com/bsdperimeter/pfsense/pull/431/files

I am using caswell CAD-0215 hardware, I still got the problem, on Traffic Shaper by Interface, I saw nothing appeared, once I use wizards, it shown the same problem as above detail. ???

My update version as below.

Current version: 2.1-BETA1
  NanoBSD Size : 4g
      Built On: Fri Feb 22 17:35:04 EST 2013

[luckman212]

Try the newest snapshot from Feb 23
I just installed it and it seems to contain the fix that Phil committed late last night

cheers all

[anas_xrt]

@luckman212:

Try the newest snapshot from Feb 23
I just installed it and it seems to contain the fix that Phil committed late last night

cheers all

Now it fixed. Thanks

Keep good work

[p1erre]

Thanks guys!

I updated also to the latest version and everything is working as usual.

Cherrs

[luckman212]

yep, now just need to figure out: http://forum.pfsense.org/index.php/topic,59298.0.html  :P