Netgate Discussion Forum
    • Categories
    • Recent
    • Tags
    • Popular
    • Users
    • Search
    • Register
    • Login

    Gitsync flushes states, as of a few days ago

    Scheduled Pinned Locked Moved 2.1 Snapshot Feedback and Problems - RETIRED
    11 Posts 5 Posters 5.2k Views
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • D
      dhatz
      last edited by

      I've noticed that since a few days ago, doing a gitsync (CLI# pfSsh.php playback gitsync RELENG_2_1) seems to kill open states (e.g. I have to restart all my ssh connections everytime I sync to latest webGUI code)

      1 Reply Last reply Reply Quote 0
      • jimpJ
        jimp Rebel Alliance Developer Netgate
        last edited by

        Do you have any gateways that are marked as down?

        See http://redmine.pfsense.org/issues/3181

        Remember: Upvote with the ๐Ÿ‘ button for any user/post you find to be helpful, informative, or deserving of recognition!

        Need help fast? Netgate Global Support!

        Do not Chat/PM for help!

        1 Reply Last reply Reply Quote 0
        • F
          fragged
          last edited by

          Either that or some other new change seems to kill states on regular filter reload. I lose SSH connection to pfsense and RDP connection to my home PC when I change a setting that triggers a filter reload.

          1 Reply Last reply Reply Quote 0
          • D
            doktornotor Banned
            last edited by

            @fragged:

            new change seems to kill states on regular filter reload. I lose SSH connection to pfsense and RDP connection to my home PC when I change a setting that triggers a filter reload.

            +1

            1 Reply Last reply Reply Quote 0
            • P
              phil.davis
              last edited by

              I had a system on a 3 Sep snapshot, just updating it now to the latest 4 Sep one that has been tagged as "2.1-RC2". While downloading the update file to my netbook the download kept stopping, and I had to pause continue it. I was making other config changes at the time, so I then made and effort to stop pressing "apply" while the download was running. It still kept stopping. This system has a few site-to-site OpenVPN links coming in to it, and I know they go up and down a lot. So probably there were OpenVPN link transitions happening.
              Anyway, I suspect that all states are being cleaned out quite often now, after this commit: https://github.com/pfsense/pfsense/commit/c59dd719e0a6d9ee8deecaa7bff0d6ee8c76e4ca
              If that is happening whenever a site-to-site OpenVPN goes up or down, then it will be painful for ordinary users of the main WAN.

              As the Greek philosopher Isosceles used to say, "There are 3 sides to every triangle."
              If I helped you, then help someone else - buy someone a gift from the INF catalog http://secure.inf.org/gifts/usd/

              1 Reply Last reply Reply Quote 0
              • D
                doktornotor Banned
                last edited by

                @phil.davis:

                Anyway, I suspect that all states are being cleaned out quite often now, after this commit: https://github.com/pfsense/pfsense/commit/c59dd719e0a6d9ee8deecaa7bff0d6ee8c76e4ca
                If that is happening whenever a site-to-site OpenVPN goes up or down, then it will be painful for ordinary users of the main WAN.

                No OVPN involved here. Simple, every filter reload seems to flush all states. Things such as cron triggered pfBlocker updates, or whatever. Kaboom, disconnected, go to logs, last thing before that is check_reload_status: Reloading filter. Needless to say, this is extremely annoying.

                1 Reply Last reply Reply Quote 0
                • jimpJ
                  jimp Rebel Alliance Developer Netgate
                  last edited by

                  Gitsync again, Ermal just pushed a fix, seems some of the logic went missing on the commit to change the behavior. Should be better now.

                  Remember: Upvote with the ๐Ÿ‘ button for any user/post you find to be helpful, informative, or deserving of recognition!

                  Need help fast? Netgate Global Support!

                  Do not Chat/PM for help!

                  1 Reply Last reply Reply Quote 0
                  • D
                    doktornotor Banned
                    last edited by

                    @jimp:

                    Gitsync again, Ermal just pushed a fix, seems some of the logic went missing on the commit to change the behavior. Should be better now.

                    Thanks, applied 5aa44e98465dcdb4bde806b5c3cb0a16d30dcb5d and 36fa13a632bad73fb2a8fdc2e9627e3190ea63c6, will watch how's it going.

                    1 Reply Last reply Reply Quote 0
                    • D
                      dhatz
                      last edited by

                      @jimp:

                      Gitsync again, Ermal just pushed a fix, seems some of the logic went missing on the commit to change the behavior. Should be better now.

                      Thanks, the issue reported in the first post seems to be fixed now.

                      1 Reply Last reply Reply Quote 0
                      • P
                        phil.davis
                        last edited by

                        I have updated 2 systems to a snap including the fix. I just downloaded a 200MB file that took 35 minutes, with both systems in the download path (One on the main WAN links, and a test box sitting behind it, and the client behind that). It ran at full WAN speed and finished perfectly.
                        Yesterday the download kept stopping and I had to pause/continue it constantly - presumably because of the state killing.
                        All is well with the world now.

                        As the Greek philosopher Isosceles used to say, "There are 3 sides to every triangle."
                        If I helped you, then help someone else - buy someone a gift from the INF catalog http://secure.inf.org/gifts/usd/

                        1 Reply Last reply Reply Quote 0
                        • D
                          doktornotor Banned
                          last edited by

                          WFM now, sanity restored. :D

                          1 Reply Last reply Reply Quote 0
                          • First post
                            Last post
                          Copyright 2025 Rubicon Communications LLC (Netgate). All rights reserved.