Firewall rules hitcount for pfSense 2.1.5 and 2.2.4
-
Thanks, works great.
But one odd thing I noticed is, that rules with multiple ports like those you fixed seem to get their counter cleared on every filter reload. At the same time, my other "normal" rules do not suffer from this.
Are you seeing this too, or am I doing something wrong? -
More features on version 0.4 for pfsense 2.2, now we can view hit count, list and kill States(with ajax to keep it light and fast).
-
Very nice!
Good job as always, marcelloc!
[]`s
Jack -
marcelloc, the lastest update works great, thanks again.
Still, the new hitcount feature reveals that some rules with multiple ports like "{ 25 465 587 }" or multiple protocols like "{ tcp udp }" get their packet/byte counter reset on reload. Evaluations / State Creations seem not affected. Nobody else seeing this?
-
Awesome feature!
Can't wait to see this merged upstream! ;D
-
Good job.
Test-driving it on a 2.2.4. Works as advertised.Git->Clone->Patch->Push-request this :)
-
+1 thanks Marcello, really useful feature.
Love to see that merged also ;D -
Pull request sent do 2.3-DEVELOPMENT
https://github.com/pfsense/pfsense/pull/1892
-
Very, very nice.
(Also: One more column of info feels like a step toward widescreen display!)
-
I suggest all who cant test to do it on 2.2 and/or 2.3-devel and comment on pull request. Maybe with more people testing, it get merged faster…
-
I suggest all who cant test to do it on 2.2 and/or 2.3-devel and comment on pull request. Maybe with more people testing, it get merged faster…
Done.
The more I play with this the more I like it.
On mouseover, I get the data I was trying (unsuccessfully) to glean out of pfTop. -
The more I play with this the more I like it.
me too. :)
On mouseover, I get the data I was trying (unsuccessfully) to glean out of pfTop.
Great!
-
Send a new pull request with almost all code working on 2.3 with bootstrap.
I'll need some help to adjust the code to popup traffic on rule click.
The code is there but is not visible after ajax return.https://github.com/pfsense/pfsense/pull/1901
-
I noticed that 2.3 is nearing Beta stage. Has your great improvement been merged with 2.3(and approved)?
-
I noticed that 2.3 is nearing Beta stage. Has your great improvement been merged with 2.3(and approved)?
unfortunately no. :(
-
I noticed that 2.3 is nearing Beta stage. Has your great improvement been merged with 2.3(and approved)?
unfortunately no. :(
That is just very sad news :'(
Was there any particular reason it didn't "make it"?(Then the question becomes. Are you going to try to get it committed for a higher version?)
-
Hmm, not nice because this was a super no brainer feature that was very very helpful >:(
I see the pull request has a "CLA label". I have no idea for what CLA stands in this case :-[ Could someone shed a light here? -
I see the pull request has a "CLA label". I have no idea for what CLA stands in this case :-[ Could someone shed a light here?[/quote]
That means that the contributor has correctly completed the relevant licensing agreement. So that is a good thing.From the comments on https://github.com/pfsense/pfsense/pull/1901 it seems that there is some thought to add some support in binaries to make it more efficent to do. But for some reason progress in those comments stops in late Sep 2015.
-
Cool feature ;)
However on 2.2.6 x32, with pfBlockerNG, it does break pftop/Label
Before it was : USERRULES: pfB_PR, after patching it shows :USERRULES: 1770001532and the Status: System logs: Firewall Rule column
Instead of displaying pfB_PRI3 auto rule (1770001532) it shows 1770001532 (1770001532) -
The trackerid is used to count rules match.
If it get merged one day we will need to change the way pfblocker get his rules.
