Layout suggestion

[divsys]

Any opposition to the typical "Pencil" for edit, "X" for delete, "Double folders" for copy (duplicate), and simple check-box for disable (with greyed out line after effect)?

Seems like they could do a fair bit to improve on the real-estate issues.  They may not be totally obvious to someone unfamiliar with the product, but if they are used in a consistent fashion a simple legend at the top and/or bottom of the page would make them very effective.

As far as layout, I agree the function after selection makes more sense (to me).

[Donny]

@divsys:

Any opposition to the typical "Pencil" for edit, "X" for delete, "Double folders" for copy (duplicate), and simple check-box for disable (with greyed out line after effect)?

Seems like they could do a fair bit to improve on the real-estate issues.  They may not be totally obvious to someone unfamiliar with the product, but if they are used in a consistent fashion a simple legend at the top and/or bottom of the page would make them very effective.

As far as layout, I agree the function after selection makes more sense (to me).

Many firewall they do same thing like "Pencil" for edit, "X" for delete, "Double folders" for copy (duplicate) but I think maybe pfSense team would like to be different.

[divsys]

Sorry, did you post the change?

I don't see it here…..

[Donny]

@divsys:

Sorry, did you post the change?

I don't see it here…..

Yes, I just changed it a few minute ago.

[divsys]

Ok, I see you edited a previous posting.

Just a suggestion, but it might be useful the post changes in a new message so we can see the "progression" of the layout changes proposed.

Just my $.02.

[Donny]

@divsys:

Ok, I see you edited a previous posting.

Just a suggestion, but it might be useful the post changes in a new message so we can see the "progression" of the layout changes proposed.

Just my $.02.

Ok thank u, I have make 2 new mockup. Maybe can help pfSense team to change something or maybe not in the future.


[Donny]

Last edit mockup layout.

Donny


[i814u2]

Additionally, if the bootstrap icons aren't fitting your needs, you can research FontAwesome as an alternative.

https://fortawesome.github.io/Font-Awesome/cheatsheet/

For the record, I would prefer a pencil for edit, trash can for delete, two files for copy (they are usually files not folders, if I may be a bit pendatic), and a checkbox for disable/enable.

The X works ok for removal actions but I think the trash can is more obvious when you first use a system.

I have no specific attachment to FontAwesome, we just use it at my work and were a bit late to the game in that regard. I mention it here in case other folks weren't aware of it.

[Steve_B]

firewall_rules.php (only) was edited to use font-awesome icons today. See what you think. I prefer this appearance, although I might make the icons slightly larger.

[heper]

just gitsync'd master and icons don't show up. it's just empty.

it's there in the html-source tho

							[](firewall_rules_edit.php?id=4 "Edit"")
							[](firewall_rules_edit.php?dup=4 "Copy")
							[](?act=toggle&if=lan&id=4 "Disable")
							[](?act=del&if=lan&id=4 "Delete")

would i need to do an actual update to a newer snapshot before the css is added?

[doktornotor]

I guess you should just wipe your browser cache.

[i814u2]

I just updated and I have the same issue. The html code is there but the icons don't show.

I checked a few things and found that the font-awesome css appears to be missing. It fails to load in the browser and when I attempted to find it manually, I couldn't.

Additionally, when that is fixed, just be aware that it is referenced with a relative path, and not specific like the pfsense.css file:

[phil.davis]

This commit https://github.com/pfsense/pfsense/commit/6ab2218f826fc38933235ddcd50184a8d6646a6b is called "Changed name of font-awesome folder" but all I can see in the commit is the deletion of all the fonts and associated folder. So I suspect that something when wrong with the intended commit to master. I don't see where the stuff is in master of pfsense repo.

[Donny]

I just thinking to change the layout a little bit. The icon is just only idea to lookout.

Donny


[Donny]

Status Dashboard, It is look more nice to using "available widgets" if you can change from + to icons.
When you use + it is mean that you want to add them to status dashboard, this i understand,
but when the users go to "available widgets" the users they also know or understand what they want to add, right.

PS. I just use an icons only for example

Donny


[doktornotor]

@phil.davis:

This commit https://github.com/pfsense/pfsense/commit/6ab2218f826fc38933235ddcd50184a8d6646a6b is called "Changed name of font-awesome folder" but all I can see in the commit is the deletion of all the fonts and associated folder. So I suspect that something when wrong with the intended commit to master. I don't see where the stuff is in master of pfsense repo.

Hmm, it was working if you gitsynced before that commit… Looks like someone committed some outdated checkout (not sure how's that even possible with git) or similar WTF. Sigh.  ::)

[Steve_B]

My apologies. After renaming the directory I failed to perform another "git add". I have to keep reminding myself that "It takes about a year to really learn git", or so say the interwabs  ;)

I just did the add/commit/push so it should be there shortly.

[Steve_B]

Just deleted the directory from my box and synced. It reappeared as expected.

[David_W]

@Steve_B:

My apologies. After renaming the directory I failed to perform another "git add". I have to keep reminding myself that "It takes about a year to really learn git", or so say the interwabs  ;)

git works on files, creating directories as needed.

Arguably a better solution would have been to mkdir the desired folder, git mv all the files, rmdir the old folder, git commit and git push.

[heper]

convert for system_gateways.php
https://github.com/pfsense/pfsense/pull/1992

for system_gateway_groups
https://github.com/pfsense/pfsense/pull/1993
i just noticed, i forgot to adjust the delete-confirmation-text after copy/pasting … stupid, sorry

for system_routes
https://github.com/pfsense/pfsense/pull/1994