IPv6 changes in 2.2.5

maverick_slo

@David_W:
We indeed have identical config as far as IPv6 goes.
BUT:

Without your patch my IPv6 works perfect.
With your patch my IPv6 works perfect.

I tried:
ISP modem power off and on.
Unplog PPPoE iface.
Disconnect/connect from iface status page.
Reboot.

In every scenario things worked 10/10 on test my IPv6 page.
Sometimes I had to wait for RA packet and then it worked (no need to disable win/android/linux NIC).

BR,
Greg

David_W

@maverick_slo:

Without your patch my IPv6 works perfect.
With your patch my IPv6 works perfect.

That means that my patch causes no regressions on your system, which is my largest concern over Issue 1. Any patch touching that functionality needs to make at least some previously broken systems work whilst not breaking previously working ones.

I expect your system will display Issue 2 without the patch, meaning your SLAAC IPv6 WAN address will have a random element on the first connection after boot. A predictable IPv6 WAN address is useful for uptime monitoring services that ping your WAN IPv6 address and/or if you use pfSense as an IPv6 VPN endpoint.

It's certainly helpful that your efforts have shaken out Redmine #5747.

maverick_slo

Yeah but I`m lone rnger I guess.
Nobody can repro it :(

cmb

Since David hasn't been around in a bit and several of us have confirmed his 2.3 patch is good (both fixes broken scenarios, and doesn't harm anything), I went ahead and committed it. There already was a ticket for one of the issues here.
https://redmine.pfsense.org/issues/5621

David_W

Thanks, Chris.

I've been really ill with a respiratory virus on top of my neuromuscular condition, which means my energy has had to remain focused on staying alive and is why I disappeared from the forum. My cough reflex doesn't work and my cough is ineffective, so it's a case of trying not to drown.

I'm not recovered yet and am still stuck in bed very breathless, but I'm much better than I was. It's now a case of hoping that my strength returns and I don't get a secondary infection of bacterial pneumonia. Bacterial pneumonia is never good news and, in my case, may well eventually take my life. I have been warned that another serious bout of pneumonia could require an ICU admission, which is something I'd rather avoid.

The patch was in a feature branch on GitHub ready for a pull request, then my health failed before I submitted the pull request. The important thing is that it has been merged - thanks. I'll leave the feature branch up for a while just in case you want to revert the flat merge and pull from the branch to include the commit history.

I've created a pull request for the RELENG_2_2 version of the patch. Whilst another 2.2 release seems unlikely, these fixes have been tested and were already in a GitHub feature branch. To my mind, it makes more sense to merge them than delete the feature branch.

maverick_slo

David, take care of yourself, health comes first!
I (and all of community) really appreciate what you did here, and wish you good luck!

cmb

Wow, very sorry to hear, David. Definitely take care of yourself! I was hoping it was just everyday life/day job that was consuming you for a bit, figured you'd be back. Wish that's all it was.

I know pneumonia is no joke, I was in the hospital 5 days with it about a decade ago. It was no fun as a normally healthy 25 year old, can't imagine having other complications to deal with as well. I couldn't even sit up without supplemental oxygen. Even after that experience it still took me a decade past that to finally quit smoking, but been smoke-free for over 7 months now. Those of us who have our health tend to take it for granted.

Take care, hope to see you around here for many years to come.

raymondjansen

@David_W:

2.2.6 (or, possibly, 2.2.5)

Revert the RFC 4638 patch, if you have that installed.

Revert any previous patch from this thread.

Install the System Patches package (if you haven't done so already) and create a patch as follows. If you are updating from an older version of the patch, the URL has changed, so you need to use this new URL and blank the Patch Contents box.

| Field | Contents |
| Description | PPP IPv6 fixes |
| URL/Commit ID | https://github.com/pfsense/pfsense/compare/RELENG_2_2…davidjwood:RELENG_2_2-ppp-ipv6-new.diff |
| Patch Contents | (leave blank) |
| Path Strip Count | 1 |
| Base Directory | / |
| Ignore Whitespace | (checked) |
| Auto Apply | (unchecked) |

Press the Save button, then, if necessary, press 'Fetch' next to the patch. At this point, the option to 'Apply' should appear, so press 'Apply'.

Apply the RFC 4638 patch, if you are using that.

Execute the sysctl command at the top of this section or reboot.

Hi,

If I follow the link for 2.2.6 I get nothing. The link for 2.3 is working fine. Does anybody have a correct link for 2.2.6 for me please?

Thanks,
Ray

hda

2.2.6. "Patch Contents" for pasting.

IPv6_pppoe_DWpatch4.txt

David_W

@raymondjansen:

If I follow the link for 2.2.6 I get nothing. The link for 2.3 is working fine. Does anybody have a correct link for 2.2.6 for me please?

The URL for 2.2.6 displays nothing because the patch was merged to the RELENG_2_2 branch of pfsense/pfsense. Instead of the URL, try the commit ID ec0643f7f1537ab6a18ed05fc015ecba598fcffc

The patch for 2.3 still displays but is obsolete, as the patch was merged (without commit history) into the master branch of pfsense/pfsense. It has been part of all 2.3 builds for over a month.

The full instructions are therefore:

Press the Save button, then, if necessary, press 'Fetch' next to the patch. At this point, the option to 'Apply' should appear, so press 'Apply'.

Reboot pfSense.

N.B. I haven't tested this method of applying the patch - the other alternative is to use the version hda posted.

hda

Hi David, great to read from you again :)

<github.com pfsense="" commit="" ec0643f7f1537ab6a18ed05fc015ecba598fcffc="">does yield, but from head on:


From 682d280755ee7bd2140dca84b5ee21659a4ae580 Mon Sep 17 00:00:00 2001
From: David Wood <david@xxxx.org.uk>Date: Thu, 24 Dec 2015 05:50:16 +0000
Subject: [PATCH 1/8] Make ppp-ipv6 the only way interface_dhcpv6_configure()
 is called on PPP interfaces

... snipped</david@xxxx.org.uk>

And following code content is very different from your last patch (4th) ;)</github.com>

David_W

@hda:

Hi David, great to read from you again :)

<github.com pfsense="" commit="" ec0643f7f1537ab6a18ed05fc015ecba598fcffc="">does yield, but from head on:
From 682d280755ee7bd2140dca84b5ee21659a4ae580 Mon Sep 17 00:00:00 2001
From: David Wood <david@xxxx.org.uk>Date: Thu, 24 Dec 2015 05:50:16 +0000
Subject: [PATCH 1/8] Make ppp-ipv6 the only way interface_dhcpv6_configure()
 is called on PPP interfaces

... snipped</david@xxxx.org.uk> 
And following code content is very different from your last patch (4th) ;)</github.com>

For some reason, System Patches chooses to use the .patch GitHub URL, which gives all the history including the many code snippets I later reversed. If it used the .diff GitHub URL, that produces a flat patch with no history, which is really what you want.

In this case, I suggest using https://github.com/pfsense/pfsense/commit/ec0643f7f1537ab6a18ed05fc015ecba598fcffc.diff as the URL.