haproxy-devel 0.59_1 net and haproxy 0.58_5 crash on install

amassi

@piba said in haproxy-devel 0.59_1 net and haproxy 0.58_5 crash on install:

PR

hank you, 0.59_6 fixed the issue for me too !

BN82

On latest snapshot (Thu Aug 23 07:20:11 EDT 2018) I got the following error :

Fatal error: Cannot redeclare getarraybyref() (previously declared in /etc/inc/pfsense-utils.inc:3402) in /usr/local/pkg/haproxy/haproxy_utils.inc on line 105
PHP ERROR: Type: 1, File: /usr/local/pkg/haproxy/haproxy_utils.inc, Line: 105, Message: Cannot redeclare getarraybyref() (previously declared in /etc/inc/pfsense-utils.inc:3402)Starting CRON... done.
Aug 23 20:56:31 php-fpm[334]: /rc.newwanip: rc.newwanip: Info: starting on ovpns1.
Aug 23 20:56:31 php-fpm[334]: /rc.newwanip: rc.newwanip: on (IP address: 172.17.8.1) (interface: OPENVPN_INT[opt2]) (real interface: ovpns1).
Aug 23 20:56:32 php-fpm[334]: /rc.newwanip: PHP ERROR: Type: 1, File: /usr/local/pkg/haproxy/haproxy_utils.inc, Line: 105, Message: Cannot redeclare getarraybyref() (previously declared in /etc/inc/pfsense-utils.inc:3402)
Aug 23 20:56:32 php-fpm[334]: /rc.newwanip: New alert found: PHP ERROR: Type: 1, File: /usr/local/pkg/haproxy/haproxy_utils.inc, Line: 105, Message: Cannot redeclare getarraybyref() (previously declared in /etc/inc/pfsense-utils.inc:3402)
Aug 23 20:56:32 php-fpm[335]: /rc.start_packages: Restarting/Starting all packages.
 Starting package LADVD...done.
 Starting package haproxy-devel...
Fatal error: Cannot redeclare getarraybyref() (previously declared in /etc/inc/pfsense-utils.inc:3402) in /usr/local/pkg/haproxy/haproxy_utils.inc on line 105
Aug 23 20:56:33 php-fpm[335]: /rc.start_packages: PHP ERROR: Type: 1, File: /usr/local/pkg/haproxy/haproxy_utils.inc, Line: 105, Message: Cannot redeclare getarraybyref() (previously declared in /etc/inc/pfsense-utils.inc:3402)
Aug 23 20:56:33 php-fpm[335]: /rc.start_packages: New alert found: PHP ERROR: Type: 1, File: /usr/local/pkg/haproxy/haproxy_utils.inc, Line: 105, Message: Cannot redeclare getarraybyref() (previously declared in /etc/inc/pfsense-utils.inc:3402)
PHP ERROR: Type: 1, File: /usr/local/pkg/haproxy/haproxy_utils.inc, Line: 105, Message: Cannot redeclare getarraybyref() (previously declared in /etc/inc/pfsense-utils.inc:3402)pfSense 2.4.4-DEVELOPMENT amd64 Thu Aug 23 07:20:11 EDT 2018
Bootup complete

Rgds,
BN

PiBa

@bn82
yup.. that function was added to base. now needs to be removed from the package

zwck

same problem on the latest nightly as well 2.4.4.a.20180826.0538 with haproxy_devel 59_9

PiBa

@zwck
indeed.. PR is still pending: https://github.com/pfsense/FreeBSD-ports/pull/555
hoped that would have been pulled a bit faster..

zwck

@piba maybe tomorrow

zwck

maybe the day after tomorrow :*(

PiBa

@zwck
Today it is
please give haproxy-devel 0.59_10 a try, if it installs properly AND no other issues are found i'm going to make the same changes for 'haproxy' package probably tomorrow. And then hopefully that to will get pulled before this week ends.

zwck

@piba I'll give you an update in approx 7hours!

maverick_slo

Not working see redmine.
Also ACME is not working due to same error.

zwck

@PiBa
Latest build: PFsense 2.4.4.a.20180829.1026 and HaProxy_devel 59_10 works for me

maverick_slo

Umm can`t see build 1026 of pfsense nor haproxy 10.
???

PiBa

@zwck
Thanks for testing.

I did find one more issue in haproxy_global.php when installing 'fresh'.. fix coming up soon (i hope)..

@maverick_slo,
i dunno why it wouldn't be available for you.. Its been there since last night:
https://beta.pfsense.org/packages/pfSense_master_amd64-pfSense_devel/All/pfSense-pkg-haproxy-devel-0.59_10.txz

maverick_slo

Ha, option 13 from console did the trick.
Testing now, both packages.

PiBa

@maverick_slo
I'm interested in your results .

@ all haproxy package users
'Everything' regarding these array/item issues in haproxy should be fixed with current 0.59_11 version. If not please let me know the exact error you get and when that happens.

zwck

I actually just updated on my second box to the recent nightly and 59_11 works like a charm!

Thanks for your hard work

maverick_slo

Hello!

Same here, everything is OK, running great.
Thanks man!

PiBa

Thank you guys for testing and reporting back.

Hugovsky

well... after upgrade from_9, this shows up:


PHP errors

    PHP ERROR: Type: 1, File: /usr/local/pkg/haproxy/haproxy.inc, Line: 2338, Message: Uncaught Error: Call to undefined function getarraybyref() in /usr/local/pkg/haproxy/haproxy.inc:2338
    Stack trace:
    #0 /usr/local/pkg/haproxy/haproxy.inc(650): haproxy_check_run(1)
    #1 /etc/inc/pkg-utils.inc(748) : eval()'d code(1): haproxy_custom_php_install_command()
    #2 /etc/inc/pkg-utils.inc(748): eval()
    #3 /etc/inc/pkg-utils.inc(835): eval_once('haproxy_custom_...')
    #4 /etc/rc.packages(74): install_package_xml('haproxy-devel')
    #5 {main}
    thrown @ 2018-09-04 15:19:46

Executing custom_php_install_command()...
Fatal error: Uncaught Error: Call to undefined function getarraybyref() in /usr/local/pkg/haproxy/haproxy.inc:2338
Stack trace:
#0 /usr/local/pkg/haproxy/haproxy.inc(650): haproxy_check_run(1)
#1 /etc/inc/pkg-utils.inc(748) : eval()'d code(1): haproxy_custom_php_install_command()
#2 /etc/inc/pkg-utils.inc(748): eval()
#3 /etc/inc/pkg-utils.inc(835): eval_once('haproxy_custom_...')
#4 /etc/rc.packages(74): install_package_xml('haproxy-devel')
#5 {main}
  thrown in /usr/local/pkg/haproxy/haproxy.inc on line 2338
PHP ERROR: Type: 1, File: /usr/local/pkg/haproxy/haproxy.inc, Line: 2338, Message: Uncaught Error: Call to undefined function getarraybyref() in /usr/local/pkg/haproxy/haproxy.inc:2338
Stack trace:
#0 /usr/local/pkg/haproxy/haproxy.inc(650): haproxy_check_run(1)
#1 /etc/inc/pkg-utils.inc(748) : eval()'d code(1): haproxy_custom_php_install_command()
#2 /etc/inc/pkg-utils.inc(748): eval()
#3 /etc/inc/pkg-utils.inc(835): eval_once('haproxy_custom_...')
#4 /etc/rc.packages(74): install_package_xml('haproxy-devel')
#5 {main}
  thrownpkg-static: POST-INSTALL script failed

I'm using

2.4.4-DEVELOPMENT (amd64)
built on Tue Jul 17 07:57:02 EDT 2018
FreeBSD 11.2-RELEASE

Should I upgrade base pfsense first?

PiBa

@hugovsky
Yes, a newer base pfSense version would have that 'missing function' included.