FYI: crash during 2.2.3 upgrade

rcfa

Got the following crash report during the upgrade, and of course the mandatory stale package installation lock:

Crash report begins.  Anonymous machine information:

amd64
10.1-RELEASE-p13
FreeBSD 10.1-RELEASE-p13 #0 c77d1b2(releng/10.1)-dirty: Tue Jun 23 17:00:47 CDT 2015     root@pfs22-amd64-builder:/usr/obj.amd64/usr/pfSensesrc/src/sys/pfSense_SMP.10

Crash report details:

PHP Errors:
[25-Jun-2015 22:44:59 Etc/UTC] PHP Fatal error:  Cannot redeclare byte_convert() (previously declared in /usr/local/pkg/vhosts.inc:58) in /usr/local/pkg/backup.inc on line 43

Filename: /var/crash/minfree
2048

Any clues as to what's causing this?

doktornotor

Probably the broken vhosts package? I'd not that pfSense box is not place for webhosting.

phil.davis

The "backup" and "vhosts" packages both have function byte_convert().
"vhosts" checks to see if the function exists before defining it. backup does not. So it depends what order the ".inc" files are included as to whether the "Cannot redeclare" error happens.
I will make a pull request on GitHub in a few minutes to fix it…

phil.davis

https://github.com/pfsense/pfsense-packages/pull/890
This backup.inc should fix it:
https://github.com/phil-davis/pfsense-packages/blob/backup/config/backup/backup.inc
This would have been a problem in all pfSense versions if you have Backup and Vhosts packages both installed.

rcfa

@doktornotor:

Probably the broken vhosts package? I'd not that pfSense box is not place for webhosting.

If it's good enough for load balancing, web acceleration, squid based filtering proxy, pfSense web based GUI etc. then surely it can handle serving a low traffic static web site…
If that's a security problem, then the more complex things mentioned before are even more of a problem.

In other words: if there's a problem with pfSense serving static web pages I would have to ditch pfSense and look for an alternative solution to network security.

rcfa

So, great, previous crash fixed, ran the "reinstall all packages" routine to test, but now I get this crash:

Crash report begins.  Anonymous machine information:

amd64
10.1-RELEASE-p13
FreeBSD 10.1-RELEASE-p13 #0 c77d1b2(releng/10.1)-dirty: Tue Jun 23 17:00:47 CDT 2015     root@pfs22-amd64-builder:/usr/obj.amd64/usr/pfSensesrc/src/sys/pfSense_SMP.10

Crash report details:

PHP Errors:
[29-Jun-2015 12:35:33 Etc/UTC] PHP Fatal error:  require_once(): Failed opening required '/usr/local/pkg/shellcmd.inc' (include_path='.:/etc/inc:/usr/local/www:/usr/local/captiveportal:/usr/local/pkg') in /etc/inc/filter.inc on line 3852

Another thing that would be useful: if version updates wouldn't mess with the crontab file: after each update I have to re-add the 'MAILTO=""' line in order not to get swamped with notification e-mails; even better if we'd get notifications e-mails when there are package and/or OS updates ready. But those are different issues…