Reverse Squid no longer working on latest development branch

stephenw10

@kiokoman said in Squid no longer working on latest development branch:

i'm unable to reproduce this

In reverse mode?

kiokoman

i put some random stuff inside and it was working, i will try again

stephenw10

May be something else required to 'tickle' it. Like something in the array contents... or a lack of contents etc.

kiokoman

ah ok found it.. yeah it put Array in the config
bug https://redmine.pfsense.org/issues/10367

    foreach (explode(",", $ifaces) as $i => $iface) {
            $real_ifaces[] = squid_get_real_interface_address($iface);
            if ($real_ifaces[$i][0]) {

$real_ifaces[] contain only "Array"

nafeasonto

Good job finding it. I love when people listen to me. Thanks for taking the time to read the post.

viktor_g

Fix:
https://github.com/pfsense/FreeBSD-ports/pull/805

stephenw10

Rapido!

kiokoman

nice work as always viktor

nafeasonto

@kiokoman you updating the package on Pfsense?

kiokoman

nope, i'm just a regular user like you, viktor have done the work, now Jim and Renato will do the update

stephenw10

Pretty simple patch, you could just modify /usr/local/pkg/squid_reverse.inc yourself to test it.

https://github.com/pfsense/FreeBSD-ports/commit/7716b1cb15b3d5ad7985118bc4716565a1c7dbfc?diff=unified

Steve

nafeasonto

@stephenw10 The modifications in the link you told me worked. Thanks.

Will you be modifying the package for the future?

stephenw10

Not me personally but it will almost certainly be pulled in, yes.

Steve

nafeasonto

@stephenw10 okay great, thank you.

nafeasonto

@stephenw10 For some reason on reboot, it went back to the old settings.

stephenw10

It reverted the file? Curious.

You could apply it using the system patches package. You can set that to auto-apply if required.

Steve

stephenw10

That change is merged now. It's in the Squid package 0.4.44_15 which you should now see available.

Steve

nafeasonto

Awesome dude thank you.