Several issues upon 2.5.0 upgrade

maverickws

So looking at this:

https://redmine.pfsense.org/issues/9527

I don't really understand this "issue", as before having RFC2307 style membership WORKED JUST FINE, as others mentioned this has been working for a long time with extended query, querying the right containers. I really don't know what was the issue of the OP of that issue.

What I know is that now if I have RFC 2307 checked the authentication fails, and if I uncheck it it doesn't work as it returns no group.

@jimp I noticed you participated on that issue, could you please elucidate why was that "fix" merged, for a problem that honestly did not exist?

Doing an extended query memberOf=cn=fwadmin,cn=groups,cn=accounts,dc=domain,dc=io fails.

And Chris Linstruth said he tested against FreeIPA 2 months ago with what version?? what settings were those against what FreeIPA version?

jimp

The group membership worked fine but using them in the extended queries did not, as explained on that Redmine issue.

RFC 2307bis (AD Style) is not the same as RFC 2307 (OpenLDAP style)

For AD and anything else that uses RFC 2307bis you wouldn't want to check the RFC 2307 box.

As you can also see by the comments on the Redmine issue it was tested by multiple people with different LDAP servers as well, so it's possible there is some different issue at play or maybe something worked in the past by accident with the wrong settings.

maverickws

@jimp alright already learned about the RFC 2307 checkbox not being compatible with 2307bis ... moving on.

I see one person complaining on a redmine issue saying something wasn't working and here and all around you have people saying it did work for years until this update where its broken.

I can't say I'm an LDAP expert but I don't get what you mean that "group membership worked fine but using them in the extended queries did not" as I had it on the extended queries AND IT DID WORK FINE (or am I missing what extended queries we're talking here? Is some other "extended query" beside the one available on the authentication server config?).

Also, what version was tested really? That would be very interesting to learn. I have IDM/IPA 4.8.4 the same version as Chris said he tested against, if he tested using pfSense 2.4.5 then YES IT WAS WORKING. With 2.5.0 is not.

So I ask again, what version of pfSense did he test, and with what settings?

I've always heard throughout my life "if something isn't broken, don't fix it"

jimp

Fetching groups from LDAP worked fine before, but trying to use an extended query to filter results so that the auth could only ever match a specific group did not, at least not for the person who submitted that PR.

There are so many differences in LDAP structures it's no surprise that there is some variation here, but those changes have also been in snapshots since September and worked for at least the people who took the time to test them before the release.

I can't speak to their specific settings, but it's working well for me with OpenLDAP and RFC 2307 groups, but I'm not using extended queries to filter anything. My LDAP settings haven't been adjusted in years, and they have kept working. As you can see on that issue when they broke, I reverted the change until the code was corrected.

maverickws

@jimp I get that it wasn't working for the person who submitted the PR but there's an whole universe of people using both OpenLDAP and FreeIPA (which is exactly the same as Red Hat IDM) and using extended queries and it has been working fine for years. I've had extended query enabled from the start filtering results and it worked.

I actually wasn't aware that "RFC 2307bis" was used by IPA/IDM, but I went to confirm that, and apparently it is so. The extended query is on the "MSAD Style" as called on the GUI: memberOf=cn=fwadmin,cn=groups,cn=accounts,dc=domain,dc=io

I kindly ask you, please, if you have contact with Chris Linstruth, who said that tested against FreeIPA 4.8.4, could he pass you what settings he used, or maybe come here and shed some light on the matter? Thanks

jimp

Have you tried reverting the changes from that issue to test if that really is your problem? This thread is lengthy and I am short on time so I can't go back and check every post.

The complaint on that Redmine issue was for extended query for groups with RFC 2307, not -bis, so if you were actually using -bis style before then it could have been working for you. The RFC 2307 checkbox would change how the LDAP search worked to return groups, but if you were filtering to only one group that checkbox probably wasn't having much of any effect in the end.

@Derelict is the one who tested FreeIPA, so maybe he can chime in and tell you what his setup is like. I know he's fairly busy though so I don't know if he has time right now.

maverickws

Thank you @jimp for the mention.

I agree this thread is lengthy I'm actually here already doing overtime at work cause I lost a lot of time here and let other responsibilities got behind. Will take a closer look to it on Monday hopefully with some more feedback here and I'll try to go through the issue and see about the changes.

Polle

@mjsengineer Confirmed - unchecking"LDAP Server uses RFC 2307 style group membership" fixes things for me too. Authentication test under diagnostics works and OpenVPN authentication too.

So is this a bug in pfSense? Our LDAP server is 389-DS - if I read the posts correctly, the same problem appeared with other LDAP servers so I tend to believe things should be fixed on pfSense side.
For those not liking the term 'bug' I'm also ok with a non-compliance ;-)

maverickws

@polle 389-DS is Red Hat's Directory Server the same used by FreeIPA and Red Hat IDM uses RFC 2307bis (wasn't aware of this detail either).
So I guess regarding this we're all on the same boat. This change and its impact should, however, be documented.

BossaOps

@lucsuryo I looked into Radius/LDAP 2FA with TOTP, won't go into too much detail, but have a look at proxying the requests through things that can do 2FA..

cboenning

I stumbled upon this after experiencing the same issues with LDAP Authentication when used with RedHat IdM/FreeIPA. Following settings worked for us on RedHat IdM (from RHEL 7) as well as FreeIPA (from CentOS 7). Our pfSense 2.4.x Instances are still using other settings, but 2.5.0 required us to go with the following.

Won't get into details with Server-Setting etc as it's site specific, but may be the following is proper directions for "the RHEL folks":
Search scope: Entire Subtree
Base DN: cn=accounts,dc=idm,dc=example,dc=com
Authentication containers: cn=users
Extended Query: unchecked (probably site specific)
Bind credentials: site specific
User naming attribute: uid
Group naming attribute: cn
Group member attribute: memberOf
RFC 2307 Groups: unchecked
Group Object Class: posixGroup

maverickws

@cboenning man f***ing amazing kudus for you.

I had
Group member attribute: memberUid

changing that to memberOf fixed my still existing issues.
You da man!!!! Cheers!!!